From: Aaron Schulz <aschulz@wikimedia.org>
Date: Wed, 21 May 2014 22:50:15 +0000 (-0700)
Subject: Removed begin/commit calls that result in error spam
X-Git-Tag: 1.31.0-rc.0~15620^2
X-Git-Url: http://git.cyclocoop.org/%40spipnet%40?a=commitdiff_plain;h=02f17b579060;p=lhc%2Fweb%2Fwiklou.git

Removed begin/commit calls that result in error spam

* The delete calls already try to start transactions. Also CLI scripts
  run in autocommit mode anyway.

Change-Id: I433691b3e4e578983e4e15334248f029e0b0d277
---

diff --git a/maintenance/deleteEqualMessages.php b/maintenance/deleteEqualMessages.php
index c30a86e4a7..1a54df1ea5 100644
--- a/maintenance/deleteEqualMessages.php
+++ b/maintenance/deleteEqualMessages.php
@@ -172,7 +172,6 @@ class DeleteEqualMessages extends Maintenance {
 		foreach ( $messageInfo['results'] as $result ) {
 			wfWaitForSlaves();
 			$dbw->ping();
-			$dbw->begin( __METHOD__ );
 			$title = Title::makeTitle( NS_MEDIAWIKI, $result['title'] );
 			$this->output( "\n* [[$title]]" );
 			$page = WikiPage::factory( $title );
@@ -185,7 +184,6 @@ class DeleteEqualMessages extends Maintenance {
 				$error = ''; // Passed by ref
 				$page->doDeleteArticle( 'Orphaned talk page of no longer required message', false, 0, false, $error, $user );
 			}
-			$dbw->commit( __METHOD__ );
 		}
 		$this->output( "\n\ndone!\n" );
 	}