From d21518a3a3bf491bf17a49e6393da19d1bd189d6 Mon Sep 17 00:00:00 2001
From: Volker E <volker.e@wikimedia.org>
Date: Wed, 21 Nov 2018 18:13:45 -0800
Subject: [PATCH] Replace mixin by inline styles

Replacing `.agora-label-styling()` by inline styles.
It is not useful to have a mixin for this only used in two selectors
of forms.less

Change-Id: I807fdbdca11d2ad6fea120d76c3a56471260c8cb
---
 .../src/mediawiki.less/mediawiki.ui/mixins.less    | 12 ------------
 resources/src/mediawiki.ui/components/forms.less   | 14 ++++++++++++--
 2 files changed, 12 insertions(+), 14 deletions(-)

diff --git a/resources/src/mediawiki.less/mediawiki.ui/mixins.less b/resources/src/mediawiki.less/mediawiki.ui/mixins.less
index 58319f5b72..ddf847d515 100644
--- a/resources/src/mediawiki.less/mediawiki.ui/mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.ui/mixins.less
@@ -1,15 +1,3 @@
-// ----------------------------------------------------------------------------
-// Form styling mixins
-// ----------------------------------------------------------------------------
-.agora-label-styling() {
-	font-size: 0.9em;
-	color: @colorText;
-
-	* {
-		font-weight: normal;
-	}
-}
-
 // ----------------------------------------------------------------------------
 // Button styling
 // ----------------------------------------------------------------------------
diff --git a/resources/src/mediawiki.ui/components/forms.less b/resources/src/mediawiki.ui/components/forms.less
index 892ba4efba..a018d4e3ab 100644
--- a/resources/src/mediawiki.ui/components/forms.less
+++ b/resources/src/mediawiki.ui/components/forms.less
@@ -58,11 +58,16 @@
 
 	> label {
 		display: block;
+		color: @colorText;
 		.box-sizing( border-box );
-		.agora-label-styling();
 		width: auto;
 		margin: 0 0 0.2em;
 		padding: 0;
+		font-size: 0.9em;
+
+		* {
+			font-weight: normal;
+		}
 	}
 
 	// Override input styling just for checkboxes and radio inputs.
@@ -159,5 +164,10 @@
 // You generally don't need to use this class if <label> is within an Agora
 // form container such as mw-ui-vform
 .mw-ui-label {
-	.agora-label-styling();
+	color: @colorText;
+	font-size: 0.9em;
+
+	* {
+		font-weight: normal;
+	}
 }
-- 
2.20.1