From cd1f6888ddb243d7a31fab219addb48f37ff5909 Mon Sep 17 00:00:00 2001 From: Platonides Date: Thu, 30 Dec 2010 16:16:16 +0000 Subject: [PATCH] ResourceLoader::register() works differently since r77011. This test isn't useful anymore. --- tests/phpunit/includes/ResourceLoaderTest.php | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/tests/phpunit/includes/ResourceLoaderTest.php b/tests/phpunit/includes/ResourceLoaderTest.php index 8de178a951..76f0ba874c 100644 --- a/tests/phpunit/includes/ResourceLoaderTest.php +++ b/tests/phpunit/includes/ResourceLoaderTest.php @@ -46,20 +46,6 @@ class ResourceLoaderTest extends PHPUnit_Framework_TestCase { $resourceLoader->register( $name, $module ); $this->assertEquals( $module, $resourceLoader->getModule( $name ) ); } - - /** - * Allthough ResourceLoader::register uses type hinting to prevent arbitrary information being passed through as a - * ResourceLoaderModule object, null can still get through. - * - * @depends testCreatingNewResourceLoaderCallsRegistrationHook - * @covers ResourceLoader::register - * @covers ResourceLoader::getModule - * @expectedException MWException - */ - public function testRegisteringNullModuleThrowsAnException( ResourceLoader $resourceLoader ) { - $this->markTestIncomplete( "Broken by r77011" ); - $resourceLoader->register( 'TEST.nullModule', null ); - } } /* Stubs */ @@ -68,4 +54,4 @@ class ResourceLoaderTestModule extends ResourceLoaderModule { } /* Hooks */ global $wgHooks; -$wgHooks['ResourceLoaderRegisterModules'][] = 'ResourceLoaderTest::resourceLoaderRegisterModules'; \ No newline at end of file +$wgHooks['ResourceLoaderRegisterModules'][] = 'ResourceLoaderTest::resourceLoaderRegisterModules'; -- 2.20.1