From c407ffc869704125ad26cc9643a655fe1fec0c13 Mon Sep 17 00:00:00 2001 From: Fomafix Date: Sat, 1 Sep 2018 16:07:57 +0200 Subject: [PATCH] resourceloader: Avoid duplicate existence check The check above with the mw.loader.register( name ) ensures that hasOwn.call( registry, name ) is always true. Change-Id: I10e2a23bd5c11fbf53fd4fc59ba2e5d94f157254 --- resources/src/startup/mediawiki.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/src/startup/mediawiki.js b/resources/src/startup/mediawiki.js index f927aade54..e665403ddb 100644 --- a/resources/src/startup/mediawiki.js +++ b/resources/src/startup/mediawiki.js @@ -1828,7 +1828,7 @@ mw.loader.register( name ); } // Check for duplicate implementation - if ( hasOwn.call( registry, name ) && registry[ name ].script !== undefined ) { + if ( registry[ name ].script !== undefined ) { throw new Error( 'module already implemented: ' + name ); } if ( version ) { -- 2.20.1