From a3f692672c84348d2afc5ac72fa6d8f134b6da41 Mon Sep 17 00:00:00 2001 From: Aryeh Gregor Date: Tue, 27 May 2008 16:23:23 +0000 Subject: [PATCH] Testing whether "!$this" is true makes absolutely no sense. Either we're in an object context, in which case it's always true; or we're not, like if the method was called statically, in which case the code is seriously buggy and *should* crash with a fatal error so we can fix it ASAP (which it will, now, on the next line when a method of $this is called). --- includes/Title.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/Title.php b/includes/Title.php index c7ea91551f..a4d7d68624 100644 --- a/includes/Title.php +++ b/includes/Title.php @@ -2394,7 +2394,7 @@ class Title { */ public function isValidMoveOperation( &$nt, $auth = true ) { $errors = array(); - if( !$this or !$nt ) { + if( !$nt ) { // Normally we'd add this to $errors, but we'll get // lots of syntax errors if $nt is not an object return array(array('badtitletext')); -- 2.20.1