From 8218d6eb9f0615fe66dd2429fcb165799dd1a7e5 Mon Sep 17 00:00:00 2001 From: Roan Kattouw Date: Mon, 7 Jun 2010 16:19:09 +0000 Subject: [PATCH] (bug 23570) Fix an instance of a javascript: link in core --- includes/DefaultSettings.php | 2 +- skins/common/wikibits.js | 5 ++++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/includes/DefaultSettings.php b/includes/DefaultSettings.php index daa1a8e158..69df146e06 100644 --- a/includes/DefaultSettings.php +++ b/includes/DefaultSettings.php @@ -1676,7 +1676,7 @@ $wgCacheEpoch = '20030516000000'; * to ensure that client-side caches do not keep obsolete copies of global * styles. */ -$wgStyleVersion = '284'; +$wgStyleVersion = '285'; # Server-side caching: diff --git a/skins/common/wikibits.js b/skins/common/wikibits.js index 0454bba165..1bf36b82e2 100644 --- a/skins/common/wikibits.js +++ b/skins/common/wikibits.js @@ -145,7 +145,9 @@ function showTocToggle() { var toggleLink = document.createElement( 'a' ); toggleLink.id = 'togglelink'; toggleLink.className = 'internal'; - toggleLink.href = 'javascript:toggleToc()'; + toggleLink.href = '#'; + toggleLink.onclick = toggleToc; + toggleLink.appendChild( document.createTextNode( tocHideText ) ); outerSpan.appendChild( document.createTextNode( '[' ) ); @@ -187,6 +189,7 @@ function toggleToc() { document.cookie = "hidetoc=1"; tocmain.className = 'toc tochidden'; } + return false; } var mwEditButtons = []; -- 2.20.1