From 766549999c6edade0d57a8ec89584f772285e783 Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 5 Apr 2019 01:09:30 +0100 Subject: [PATCH] jobqueue: Document Title as valid param type for compat (2) MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Follows-up 9b4938c40d02c, and 4bff6f1558. The latter of which updated ::factory() instead of __construct(). Oops. This should fix build failures that are preventing merges in repos where Phan is finding Job::__construct(string, Title) where it currently fails as follows: CompileArticleMetadataJob.php:11 PhanTypeMismatchArgument Argument 2 (params) is …\Title|string but \Job::__construct() takes array As Phan is reading the php doc I guess. Change-Id: I128d57ead6bcb9dbae99d41a1f23192c3f6fbdba --- includes/jobqueue/Job.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includes/jobqueue/Job.php b/includes/jobqueue/Job.php index 0b5e62df89..55cb942a3f 100644 --- a/includes/jobqueue/Job.php +++ b/includes/jobqueue/Job.php @@ -106,7 +106,7 @@ abstract class Job implements IJobSpecification { /** * @param string $command - * @param array $params + * @param array|Title $params */ public function __construct( $command, $params = [] ) { if ( $params instanceof Title ) { -- 2.20.1