From 74a2d73ac9054fafb654474a38f51c8638283bdd Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Tue, 11 Feb 2014 21:44:34 -0800 Subject: [PATCH] Only call ->clearInstanceCache() if $targetUser instanceof User Bug: 61252 Change-Id: Ibb79ca9a27e50b58fdd5dd541e243054fb095753 --- includes/specials/SpecialUserrights.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/includes/specials/SpecialUserrights.php b/includes/specials/SpecialUserrights.php index b4757e0fa1..a6b36024e8 100644 --- a/includes/specials/SpecialUserrights.php +++ b/includes/specials/SpecialUserrights.php @@ -152,7 +152,10 @@ class UserrightsPage extends SpecialPage { } $targetUser = $status->value; - $targetUser->clearInstanceCache(); + if ( $targetUser instanceof User ) { // UserRightsProxy doesn't have this method (bug 61252) + $targetUser->clearInstanceCache(); // bug 38989 + } + if ( $request->getVal( 'conflictcheck-originalgroups' ) !== implode( ',', $targetUser->getGroups() ) ) { $out->addWikiMsg( 'userrights-conflict' ); -- 2.20.1