From 6a6771e553aa06979dce4d5349e4f4dd54f6063a Mon Sep 17 00:00:00 2001 From: Aaron Schulz Date: Wed, 13 Jun 2018 17:14:23 -0700 Subject: [PATCH] rdbms: disable ChronologyProtector if EmptyBagOStuff is used Bug: T197206 Change-Id: Ic07634224fac1ae72d1ba20176c028fdda5ba415 --- includes/libs/rdbms/lbfactory/LBFactory.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/includes/libs/rdbms/lbfactory/LBFactory.php b/includes/libs/rdbms/lbfactory/LBFactory.php index 130a097c78..ff296c443e 100644 --- a/includes/libs/rdbms/lbfactory/LBFactory.php +++ b/includes/libs/rdbms/lbfactory/LBFactory.php @@ -505,6 +505,10 @@ abstract class LBFactory implements ILBFactory { // Request opted out of using position wait logic. This is useful for requests // done by the job queue or background ETL that do not have a meaningful session. $this->chronProt->setWaitEnabled( false ); + } elseif ( $this->memStash instanceof EmptyBagOStuff ) { + // No where to store any DB positions and wait for them to appear + $this->chronProt->setEnabled( false ); + $this->replLogger->info( 'Cannot use ChronologyProtector with EmptyBagOStuff.' ); } $this->replLogger->debug( __METHOD__ . ': using request info ' . -- 2.20.1