From 68015d3b91863d6a1e86c306a6d78806622c6d03 Mon Sep 17 00:00:00 2001 From: Kunal Mehta Date: Thu, 27 Sep 2018 22:01:28 -0700 Subject: [PATCH] BitmapMetadataHandlerTest: Don't reinvent $this->checkPHPExtension() Change-Id: I4957ca1be698844bafbf8de64af450cb884ec71a --- tests/phpunit/includes/media/BitmapMetadataHandlerTest.php | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/tests/phpunit/includes/media/BitmapMetadataHandlerTest.php b/tests/phpunit/includes/media/BitmapMetadataHandlerTest.php index a70c005497..83554d28e1 100644 --- a/tests/phpunit/includes/media/BitmapMetadataHandlerTest.php +++ b/tests/phpunit/includes/media/BitmapMetadataHandlerTest.php @@ -127,9 +127,8 @@ class BitmapMetadataHandlerTest extends MediaWikiTestCase { * @covers BitmapMetadataHandler::png */ public function testPNGXMP() { - if ( !extension_loaded( 'xml' ) ) { - $this->markTestSkipped( "This test needs the xml extension." ); - } + $this->checkPHPExtension( 'xml' ); + $handler = new BitmapMetadataHandler(); $result = $handler->PNG( $this->filePath . 'xmp.png' ); $expected = [ -- 2.20.1