From 57c33820a97397ce90932febab26ced25ef2420e Mon Sep 17 00:00:00 2001 From: Daniel Friesen Date: Fri, 12 Aug 2011 10:20:17 +0000 Subject: [PATCH] Use a regex when checking for external urls. It's concise and DRY, less prone to bugs like "Whoops I got that hardcoded length int wrong and created a condition that'll never be true",... and it's 4 time faster ;) --- resources/mediawiki/mediawiki.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/mediawiki/mediawiki.js b/resources/mediawiki/mediawiki.js index 6f9e789719..48b024b745 100644 --- a/resources/mediawiki/mediawiki.js +++ b/resources/mediawiki/mediawiki.js @@ -1071,7 +1071,7 @@ window.mw = window.mediaWiki = new ( function( $ ) { // Allow calling with an external script or single dependency as a string if ( typeof modules === 'string' ) { // Support adding arbitrary external scripts - if ( modules.substr( 0, 7 ) === 'http://' || modules.substr( 0, 8 ) === 'https://' || modules.substr( 0, 2 ) === '//' ) { + if ( /^(https?:)?\/\//.test( modules ) ) { if ( type === 'text/css' ) { $( 'head' ).append( $( '', { rel: 'stylesheet', -- 2.20.1