From 45a194ddf08622373934735b2da961095307004c Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Thu, 7 Aug 2008 17:02:45 +0000 Subject: [PATCH] * (bug 14921) Special:Contributions/: add user name to Patch by Emufarmers This sticks the username in a more descriptive <title> for window/tab/bookmark title without duplicating the target unnecessarily in the body (where we have a link in the subtitle) https://bugzilla.wikimedia.org/attachment.cgi?id=5131 --- RELEASE-NOTES | 2 ++ includes/specials/SpecialContributions.php | 2 ++ languages/messages/MessagesEn.php | 36 ++++++++++++---------- maintenance/language/messages.inc | 2 ++ 4 files changed, 25 insertions(+), 17 deletions(-) diff --git a/RELEASE-NOTES b/RELEASE-NOTES index 9c2f313ec2..83acfaafce 100644 --- a/RELEASE-NOTES +++ b/RELEASE-NOTES @@ -52,6 +52,8 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN * Added 'noconvertlink' toogle that can be set per user preferences, also added 'convertlink=no|yes' on GET requests whether have the link titles being converted or not +* (bug 14921) Special:Contributions/: add user name to <title> + Patch by Emufarmers === Bug fixes in 1.14 === diff --git a/includes/specials/SpecialContributions.php b/includes/specials/SpecialContributions.php index e457d24747..8eea390ef9 100644 --- a/includes/specials/SpecialContributions.php +++ b/includes/specials/SpecialContributions.php @@ -223,8 +223,10 @@ function wfSpecialContributions( $par = null ) { if ( $target != 'newbies' ) { $target = $nt->getText(); $wgOut->setSubtitle( contributionsSub( $nt, $id ) ); + $wgOut->setHTMLTitle( wfMsg( 'pagetitle', wfMsg( 'contributions-title', $target ) ) ); } else { $wgOut->setSubtitle( wfMsgHtml( 'sp-contributions-newbies-sub') ); + $wgOut->setHTMLTitle( wfMsg( 'pagetitle', wfMsg( 'sp-contributions-newbies-title' ) ) ); } if ( ( $ns = $wgRequest->getVal( 'namespace', null ) ) !== null && $ns !== '' ) { diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php index 0f747eace7..c7cbd1db03 100644 --- a/languages/messages/MessagesEn.php +++ b/languages/messages/MessagesEn.php @@ -2289,23 +2289,25 @@ $1', 'blanknamespace' => '(Main)', # Contributions -'contributions' => 'User contributions', -'mycontris' => 'My contributions', -'contribsub2' => 'For $1 ($2)', -'nocontribs' => 'No changes were found matching these criteria.', -'uctop' => '(top)', -'month' => 'From month (and earlier):', -'year' => 'From year (and earlier):', - -'sp-contributions-newbies' => 'Show contributions of new accounts only', -'sp-contributions-newbies-sub' => 'For new accounts', -'sp-contributions-blocklog' => 'Block log', -'sp-contributions-search' => 'Search for contributions', -'sp-contributions-username' => 'IP Address or username:', -'sp-contributions-submit' => 'Search', -'sp-contributions-explain' => '', # only translate this message to other languages if you have to change it -'sp-contributions-footer' => '-', # do not translate or duplicate this message to other languages -'sp-contributions-footer-anon' => '-', # do not translate or duplicate this message to other languages +'contributions' => 'User contributions', +'contributions-title' => 'User contributions for $1', +'mycontris' => 'My contributions', +'contribsub2' => 'For $1 ($2)', +'nocontribs' => 'No changes were found matching these criteria.', +'uctop' => '(top)', +'month' => 'From month (and earlier):', +'year' => 'From year (and earlier):', + +'sp-contributions-newbies' => 'Show contributions of new accounts only', +'sp-contributions-newbies-sub' => 'For new accounts', +'sp-contributions-newbies-title' => 'User contributions for new accounts', +'sp-contributions-blocklog' => 'Block log', +'sp-contributions-search' => 'Search for contributions', +'sp-contributions-username' => 'IP Address or username:', +'sp-contributions-submit' => 'Search', +'sp-contributions-explain' => '', # only translate this message to other languages if you have to change it +'sp-contributions-footer' => '-', # do not translate or duplicate this message to other languages +'sp-contributions-footer-anon' => '-', # do not translate or duplicate this message to other languages # What links here 'whatlinkshere' => 'What links here', diff --git a/maintenance/language/messages.inc b/maintenance/language/messages.inc index b281569fbc..09683527a1 100644 --- a/maintenance/language/messages.inc +++ b/maintenance/language/messages.inc @@ -1514,6 +1514,7 @@ $wgMessageStructure = array( ), 'contributions' => array( 'contributions', + 'contributions-title', 'mycontris', 'contribsub2', 'nocontribs', @@ -1524,6 +1525,7 @@ $wgMessageStructure = array( 'sp-contributions' => array( 'sp-contributions-newbies', 'sp-contributions-newbies-sub', + 'sp-contributions-newbies-title', 'sp-contributions-blocklog', 'sp-contributions-search', 'sp-contributions-username', -- 2.20.1