From 3245da07a7015c9f49e880c815e799851488c53b Mon Sep 17 00:00:00 2001 From: Timo Tijhof Date: Fri, 23 Nov 2018 21:13:51 +0000 Subject: [PATCH] parser: Remove aliases for __EXPECTUNUSEDCATEGORY__ Follows-up 4985ce513469fa82a132139a41c2854504475e4a. This is a brand new magic word, with no history or concerns for backward-compatibility. Introducing it with four possible ways to to use it, I think leads to less ideal experience for end-users. I recognise that this is an attempt to make it easier for users to get this magic word correctly working, even when a user guesses the name incorrectly. This is a valid problem but, I do not think adding more syntax is the right answer to that problem. Introducing four ways to do the same thing I believe would make it more difficult to learn the syntax, because they also have to remember the other variations when encountering it from other users. I also believe that the value we gain from a user getting it right via an alias of this keyword is, shadowed by the loss in value from a user when they get it wrong for all the other keywords. This is because they'd likely expect the same four varations (MULTIWORD, MULTI_WORD, MULTIPLE_WORD, MULTIPLEWORD) to apply there as well. It creates expectations that we are not matching. I think it is worth investigating this problem, and having four extra aliases in the syntax could be one of the proposals to solve that problem. However, we should discuss that on Phabricator and, if we agree to it, apply it universally, not just to one keyword. Bug: T96041 Change-Id: I5621cee70e6f791a161f21ebda8c5a7243e5947e --- RELEASE-NOTES-1.33 | 2 +- languages/messages/MessagesEn.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/RELEASE-NOTES-1.33 b/RELEASE-NOTES-1.33 index bd968d2170..90a8c7f56d 100644 --- a/RELEASE-NOTES-1.33 +++ b/RELEASE-NOTES-1.33 @@ -30,7 +30,7 @@ production. === New features in 1.33 === * The 'GetPreferences' hook now receives an additional $context parameter. -* (T96041) __EXPECT_UNUSED_CATEGORY__ on a category page causes the category +* (T96041) __EXPECTUNUSEDCATEGORY__ on a category page causes the category to be hidden on Special:UnusedCategories. * … diff --git a/languages/messages/MessagesEn.php b/languages/messages/MessagesEn.php index b5e2c5eaa7..f32564170a 100644 --- a/languages/messages/MessagesEn.php +++ b/languages/messages/MessagesEn.php @@ -359,7 +359,7 @@ $magicWords = [ 'filepath' => [ 0, 'FILEPATH:' ], 'tag' => [ 0, 'tag' ], 'hiddencat' => [ 1, '__HIDDENCAT__' ], - 'expectunusedcategory' => [ 1, '__EXPECT_UNUSED_CATEGORY__', '__EXPECT_UNUSED_CAT__', '__EXPECTUNUSEDCATEGORY__', '__EXPECTUNUSEDCAT__' ], + 'expectunusedcategory' => [ 1, '__EXPECTUNUSEDCATEGORY__', ], 'pagesincategory' => [ 1, 'PAGESINCATEGORY', 'PAGESINCAT' ], 'pagesize' => [ 1, 'PAGESIZE' ], 'index' => [ 1, '__INDEX__' ], -- 2.20.1