From: Chad Horohoe <chadh@wikimedia.org>
Date: Thu, 12 Feb 2015 19:31:47 +0000 (-0800)
Subject: SpecialMediaStatistics: Protect against invalid indexes
X-Git-Tag: 1.31.0-rc.0~12422
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=e2379561fab58f9eedd63d73ccc93fe1c0b772e6;p=lhc%2Fweb%2Fwiklou.git

SpecialMediaStatistics: Protect against invalid indexes

Sometimes the full string isn't represented, leading to invalid
index access on list()

Just default to 0 since it makes sense here

Change-Id: Icd06d2b22b1fcb57a8849ef6dc8659b424f27fdc
---

diff --git a/includes/specials/SpecialMediaStatistics.php b/includes/specials/SpecialMediaStatistics.php
index e3c7e3a183..1056cdaea7 100644
--- a/includes/specials/SpecialMediaStatistics.php
+++ b/includes/specials/SpecialMediaStatistics.php
@@ -322,9 +322,9 @@ class MediaStatisticsPage extends QueryPage {
 	public function preprocessResults( $dbr, $res ) {
 		$this->totalCount = $this->totalBytes = 0;
 		foreach ( $res as $row ) {
-			list( , , $count, $bytes ) = $this->splitFakeTitle( $row->title );
-			$this->totalCount += $count;
-			$this->totalBytes += $bytes;
+			$mediaStats = $this->splitFakeTitle( $row->title );
+			$this->totalCount += isset( $mediaStats[2] ) ? $mediaStats[2] : 0;
+			$this->totalBytes += isset( $mediaStats[3] ) ? $mediaStats[3] : 0;
 		}
 		$res->seek( 0 );
 	}