From: Aaron Schulz <aschulz@wikimedia.org>
Date: Mon, 8 Apr 2019 03:44:46 +0000 (-0700)
Subject: Use IMaintainableDatabase type hint for DatabaseUpdater::newForDB()
X-Git-Tag: 1.34.0-rc.0~2101^2
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=cad1b31a2a12cddb65ec11a531e94a87976939aa;p=lhc%2Fweb%2Fwiklou.git

Use IMaintainableDatabase type hint for DatabaseUpdater::newForDB()

Change-Id: I56dd9f8d195ad60cf3ec9b81af2b4f25d1ca0a3a
---

diff --git a/includes/installer/DatabaseUpdater.php b/includes/installer/DatabaseUpdater.php
index 750f10870a..5add0a837e 100644
--- a/includes/installer/DatabaseUpdater.php
+++ b/includes/installer/DatabaseUpdater.php
@@ -22,6 +22,7 @@
  */
 use Wikimedia\Rdbms\Database;
 use Wikimedia\Rdbms\IDatabase;
+use Wikimedia\Rdbms\IMaintainableDatabase;
 use MediaWiki\MediaWikiServices;
 
 require_once __DIR__ . '/../../maintenance/Maintenance.php';
@@ -177,14 +178,18 @@ abstract class DatabaseUpdater {
 	}
 
 	/**
-	 * @param Database $db
+	 * @param IMaintainableDatabase $db
 	 * @param bool $shared
 	 * @param Maintenance|null $maintenance
 	 *
 	 * @throws MWException
 	 * @return DatabaseUpdater
 	 */
-	public static function newForDB( Database $db, $shared = false, Maintenance $maintenance = null ) {
+	public static function newForDB(
+		IMaintainableDatabase $db,
+		$shared = false,
+		Maintenance $maintenance = null
+	) {
 		$type = $db->getType();
 		if ( in_array( $type, Installer::getDBTypes() ) ) {
 			$class = ucfirst( $type ) . 'Updater';