From: Aryeh Gregor <simetrical@users.mediawiki.org>
Date: Thu, 31 Jul 2008 16:34:33 +0000 (+0000)
Subject: Fix r38302:
X-Git-Tag: 1.31.0-rc.0~46247
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=8a416bdc652567ded9a456c065b8bfb9e688786c;p=lhc%2Fweb%2Fwiklou.git

Fix r38302:
* PHP syntax error: mixing double and single quotes
* Probably an SQL syntax error too, due to lack of a space, unless "wl_user = 123ORDER BY wl_title" works in non-MySQL databases.  It doesn't in MySQL, and if it does in other engines, it probably shouldn't.  :)
---

diff --git a/includes/WatchlistEditor.php b/includes/WatchlistEditor.php
index 54f9d81159..d13523003d 100644
--- a/includes/WatchlistEditor.php
+++ b/includes/WatchlistEditor.php
@@ -208,8 +208,8 @@ class WatchlistEditor {
 		$sql = "SELECT wl_namespace, wl_title, page_id, page_len, page_is_redirect
 			FROM {$watchlist} LEFT JOIN {$page} ON ( wl_namespace = page_namespace
 			AND wl_title = page_title ) WHERE wl_user = {$uid}";
-		if ( ! $dbr->implicitOrderby() ) {
-			$sql .= "ORDER BY wl_title';
+		if ( !$dbr->implicitOrderby() ) {
+			$sql .= ' ORDER BY wl_title';
 		}
 		$res = $dbr->query( $sql, __METHOD__ );
 		if( $res && $dbr->numRows( $res ) > 0 ) {