From: Chad Horohoe <demon@users.mediawiki.org>
Date: Sun, 8 Aug 2010 15:29:32 +0000 (+0000)
Subject: Tweak output from install. Make non-fatals still say OK, but output their possible... 
X-Git-Tag: 1.31.0-rc.0~35606
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=88b8dd8610ad0b31ecf440089c6f6f456bf01e80;p=lhc%2Fweb%2Fwiklou.git

Tweak output from install. Make non-fatals still say OK, but output their possible warnings.
---

diff --git a/includes/installer/WebInstallerPage.php b/includes/installer/WebInstallerPage.php
index be358ff6bd..52258ce5ac 100644
--- a/includes/installer/WebInstallerPage.php
+++ b/includes/installer/WebInstallerPage.php
@@ -832,14 +832,13 @@ class WebInstaller_Install extends WebInstallerPage {
 	}
 
 	public function endStage( $step, $status ) {
-		$success = $status->isGood();
-		$msg = $success ? 'config-install-step-done' : 'config-install-step-failed';
+		$msg = $status->isOk() ? 'config-install-step-done' : 'config-install-step-failed';
 		$html = wfMsgHtml( 'word-separator' ) . wfMsgHtml( $msg );
-		if ( !$success ) {
+		if ( !$status->isOk() ) {
 			$html = "<span class=\"error\">$html</span>";
 		}
 		$this->addHTML( $html . "</li>\n" );
-		if( !$success ) {
+		if( !$status->isGood() ) {
 			$this->parent->showStatusBox( $status );
 		}
 	}