From: Antoine Musso <hashar@users.mediawiki.org>
Date: Tue, 17 Jan 2012 09:58:00 +0000 (+0000)
Subject: dbg toolbar query list
X-Git-Tag: 1.31.0-rc.0~25227
X-Git-Url: http://git.cyclocoop.org/%28?a=commitdiff_plain;h=62c2d743228a12b5d6921831a49a3c8789f3f34f;p=lhc%2Fweb%2Fwiklou.git

dbg toolbar query list

* add headers (using <th> instead of <colgroup>
* hardcoded width that looks fine to me. 4em is enoug for query count
* split function name / execution time in their own column
---

diff --git a/resources/mediawiki/mediawiki.debug.js b/resources/mediawiki/mediawiki.debug.js
index 641ee12236..f25d249414 100644
--- a/resources/mediawiki/mediawiki.debug.js
+++ b/resources/mediawiki/mediawiki.debug.js
@@ -243,11 +243,12 @@
 
 			$table = $( '<table id="mw-debug-querylist"></table>' );
 
-			// Widths on table cells and columns behave weird in some browsers like Chrome,
-			// in that, contrary to the W3 box model, padding does not increase cells having a fixed width
-			$('<colgroup>').css( 'width', /*padding=*/20 + ( String( this.data.queries.length ).length*/*fontSize*/11 ) ).appendTo( $table );
-			$('<colgroup>').appendTo( $table );
-			$('<colgroup>').css( 'width', 350 ).appendTo( $table );
+			$( '<tr>' )
+				.append( $('<th>#</th>').css( 'width', '4em' )    )
+				.append( $('<th>SQL</th>') )
+				.append( $('<th>Time</th>').css( 'width', '8em'  ) )
+				.append( $('<th>Call</th>').css( 'width', '12em' ) )
+			.appendTo( $table );
 
 			for ( i = 0, length = this.data.queries.length; i < length; i += 1 ) {
 				query = this.data.queries[i];
@@ -255,11 +256,9 @@
 				$( '<tr>' )
 					.append( $( '<td>' ).text( i + 1 ) )
 					.append( $( '<td>' ).text( query.sql ) )
-					.append( $( '<td>' )
-						.append( $( '<span class="stats"></span>' ).text( '(' + query.time.toFixed( 4 ) + 'ms) ' ) )
-						.append( query['function'] )
-					)
-					.appendTo( $table );
+					.append( $( '<td class="stats">' ).text( query.time.toFixed( 4 )+ 'ms' ) )
+					.append( $( '<td>' ).text( query['function'] ) )
+				.appendTo( $table );
 			}