* (bug 3506) Avoid MySQL error when Listusers returns no results

Bug introduced in SpecialListusers.php rev 1.36:
http://cvs.sourceforge.net/viewcvs.py/wikipedia/phase3/includes/SpecialListusers.php?r1=1.35&r2=1.36

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index a8664b1..72bc19d 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -117,6 +117,7 @@ fully support the editing toolbar, but was found to be too confusing.
 * (bug 2570) Add 'watch this page' checkbox on uploads, watch uploads
   by default when 'watchdefault' option is on
 * Skip update of disused 'rc_cur_time' field (todo: discard the field)
+* (bug 3506) Avoid MySQL error when Listusers returns no results
 
 
 === Caveats ===

diff --git a/includes/SpecialListusers.php b/includes/SpecialListusers.php
index dabe6fb..fc664e0 100644 (file)
--- a/includes/SpecialListusers.php
+++ b/includes/SpecialListusers.php
@@ -66,7 +66,10 @@ class ListUsersPage extends QueryPage {
                $batch->execute( $wgLinkCache );
 
                // Back to start for display
-               $db->dataSeek( $res, 0 );
+               if( $db->numRows( $res ) > 0 ) {
+                       // If there are no rows we get an error seeking.
+                       $db->dataSeek( $res, 0 );
+               }
        }
 
        /**