Avoid extra query by reusing $wgUser if possible
authorNiklas Laxström <nikerabbit@users.mediawiki.org>
Tue, 14 Sep 2010 07:49:24 +0000 (07:49 +0000)
committerNiklas Laxström <nikerabbit@users.mediawiki.org>
Tue, 14 Sep 2010 07:49:24 +0000 (07:49 +0000)
includes/ResourceLoaderModule.php

index 3551d2e..990a814 100644 (file)
@@ -828,7 +828,13 @@ class ResourceLoaderUserPreferencesModule extends ResourceLoaderModule {
                if ( isset( $this->modifiedTime[$hash] ) ) {
                        return $this->modifiedTime[$hash];
                }
-               if ( $context->getUser() && $user = User::newFromName( $context->getUser() ) ) {
+
+               global $wgUser;
+               $username = $context->getUser();
+               // Avoid extra db query by using $wgUser if possible
+               $user = $wgUser->getName() === $username ? $wgUser : User::newFromName( $username );
+
+               if ( $user ) {
                        return $this->modifiedTime[$hash] = $user->getTouched();
                } else {
                        return 0;