API: (bug 21817) list=usercontribs chokes on empty ucuser. Patch by Paul Copperman...

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index a360a3d..2ca7e94 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -743,6 +743,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * (bug 20967) action=edit allows creation of invalid titles
 * (bug 19523) Add inprop=watched to prop=info
 * (bug 21589) API: Separate summary and initial page text for uploads
+* (bug 21817) list=usercontribs returns empty result for empty ucuser
 
 === Languages updated in 1.16 ===
 

diff --git a/includes/api/ApiQueryUserContributions.php b/includes/api/ApiQueryUserContributions.php
index d230564..b76b31e 100644 (file)
--- a/includes/api/ApiQueryUserContributions.php
+++ b/includes/api/ApiQueryUserContributions.php
@@ -45,7 +45,6 @@ class ApiQueryContributions extends ApiQueryBase {
                        $fld_patrolled = false, $fld_tags = false;
 
        public function execute() {
-
                // Parse some parameters
                $this->params = $this->extractRequestParams();
 
@@ -74,6 +73,8 @@ class ApiQueryContributions extends ApiQueryBase {
                        $this->usernames = array();
                        if(!is_array($this->params['user']))
                                $this->params['user'] = array($this->params['user']);
+                       if(!count($this->params['user']))
+                               $this->dieUsage('User parameter may not be empty.', 'param_user');
                        foreach($this->params['user'] as $u)
                                $this->prepareUsername($u);
                        $this->prefixMode = false;