Pass the url to ChangesFeed::getFeedObject() instead of grabbing it from $wgTitle
authorAlexandre Emsenhuber <ialex@users.mediawiki.org>
Thu, 17 Feb 2011 19:26:38 +0000 (19:26 +0000)
committerAlexandre Emsenhuber <ialex@users.mediawiki.org>
Thu, 17 Feb 2011 19:26:38 +0000 (19:26 +0000)
(no use of that function in extensions)

includes/ChangesFeed.php
includes/specials/SpecialRecentchanges.php
includes/specials/SpecialRecentchangeslinked.php

index f07b650..8a17ef8 100644 (file)
@@ -24,15 +24,19 @@ class ChangesFeed {
         *
         * @param $title String: feed's title
         * @param $description String: feed's description
+        * @param $url String: url of origin page
         * @return ChannelFeed subclass or false on failure
         */
-       public function getFeedObject( $title, $description ) {
-               global $wgSitename, $wgLanguageCode, $wgFeedClasses, $wgTitle;
-               $feedTitle = "$wgSitename  - {$title} [$wgLanguageCode]";
-               if( !isset($wgFeedClasses[$this->format] ) )
+       public function getFeedObject( $title, $description, $url ) {
+               global $wgSitename, $wgLanguageCode, $wgFeedClasses;
+
+               if ( !isset( $wgFeedClasses[$this->format] ) ) {
                        return false;
+               }
+
+               $feedTitle = "$wgSitename  - {$title} [$wgLanguageCode]";
                return new $wgFeedClasses[$this->format](
-                       $feedTitle, htmlspecialchars( $description ), $wgTitle->getFullUrl() );
+                       $feedTitle, htmlspecialchars( $description ), $url );
        }
 
        /**
index 3ec4ae4..dea902b 100644 (file)
@@ -169,7 +169,8 @@ class SpecialRecentChanges extends IncludableSpecialPage {
                $changesFeed = new ChangesFeed( $feedFormat, 'rcfeed' );
                $formatter = $changesFeed->getFeedObject(
                        wfMsgForContent( 'recentchanges' ),
-                       wfMsgForContent( 'recentchanges-feed-description' )
+                       wfMsgForContent( 'recentchanges-feed-description' ),
+                       $this->getTitle()->getFullUrl()
                );
                return array( $changesFeed, $formatter );
        }
index db0f554..49cce03 100644 (file)
@@ -56,7 +56,8 @@ class SpecialRecentchangeslinked extends SpecialRecentChanges {
                $feed = new ChangesFeed( $feedFormat, false );
                $feedObj = $feed->getFeedObject(
                        wfMsgForContent( 'recentchangeslinked-title', $this->getTargetTitle()->getPrefixedText() ),
-                       wfMsgForContent( 'recentchangeslinked-feed' )
+                       wfMsgForContent( 'recentchangeslinked-feed' ),
+                       $this->getTitle()->getFullUrl()
                );
                return array( $feed, $feedObj );
        }