Merge "FilterTagMultiselectWidget: Use frameless buttons and fix height issues"

diff --combined resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
index 4bee31e,7b49147..dcada85
--- 1/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
--- 2/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
+++ b/resources/src/mediawiki.rcfilters/ui/mw.rcfilters.ui.FilterTagMultiselectWidget.js
@@@ -47,8 -47,6 +47,8 @@@
                                footers: [
                                        {
                                                name: 'viewSelect',
 +                                              disabled: !mw.config.get( 'wgStructuredChangeFiltersEnableExperimentalViews' ),
 +                                              sticky: false,
                                                // View select menu, appears on default view only
                                                $element: $( '<div>' )
                                                        .append( new mw.rcfilters.ui.ViewSwitchWidget( this.controller, this.model ).$element ),
@@@ -71,7 -69,7 +71,7 @@@
                                ]
                        },
                        input: {
 -                              icon: 'search',
 +                              icon: 'menu',
                                placeholder: mw.msg( 'rcfilters-search-placeholder' )
                        }
                }, config ) );
@@@ -147,14 -145,16 +147,16 @@@
                                classes: [ 'mw-rcfilters-ui-filterTagMultiselectWidget-views-select-widget' ],
                                items: [
                                        new OO.ui.ButtonOptionWidget( {
+                                               framed: false,
                                                data: 'namespaces',
                                                icon: 'article',
 -                                              title: mw.msg( 'namespaces' )
 +                                              title: mw.msg( 'rcfilters-view-namespaces-tooltip' )
                                        } ),
                                        new OO.ui.ButtonOptionWidget( {
+                                               framed: false,
                                                data: 'tags',
                                                icon: 'tag',
 -                                              title: mw.msg( 'rcfilters-view-tags' )
 +                                              title: mw.msg( 'rcfilters-view-tags-tooltip' )
                                        } )
                                ]
                        } );
@@@ -289,8 -289,6 +291,8 @@@
                                this.input.setValue( '' );
                        }
                }
 +
 +              this.input.setIcon( isVisible ? 'search' : 'menu' );
        };
  
        /**
@@@ -457,8 -455,6 +459,8 @@@
                        menuOption = this.menu.getItemFromModel( tagItem.getModel() ),
                        oldInputValue = this.input.getValue();
  
 +              this.menu.setUserSelecting( true );
 +
                // Reset input
                this.input.setValue( '' );
  
@@@ -479,16 -475,11 +481,16 @@@
                        // user filtered the results
                        this.getMenu().once(
                                'itemVisibilityChange',
 -                              function () { widget.scrollToTop( menuOption.$element ); }
 +                              function () {
 +                                      widget.scrollToTop( menuOption.$element );
 +                                      widget.menu.setUserSelecting( false );
 +                              }
                        );
                } else {
                        this.scrollToTop( menuOption.$element );
 +                      this.menu.setUserSelecting( false );
                }
 +
        };
  
        /**