missing closedir() and ... protected the readdir against opendir() failing
authorRuss Nelson <nelson@users.mediawiki.org>
Wed, 30 Mar 2011 01:49:38 +0000 (01:49 +0000)
committerRuss Nelson <nelson@users.mediawiki.org>
Wed, 30 Mar 2011 01:49:38 +0000 (01:49 +0000)
includes/filerepo/FSRepo.php

index b7b066e..d374117 100644 (file)
@@ -622,8 +622,11 @@ class FSRepo extends FileRepo {
                                continue;
                        }
                        $dir = opendir( $path );
-                       while ( false !== ( $name = readdir( $dir ) ) ) {
-                               call_user_func( $callback, $path . '/' . $name );
+                       if ($dir) {
+                               while ( false !== ( $name = readdir( $dir ) ) ) {
+                                       call_user_func( $callback, $path . '/' . $name );
+                               }
+                               closedir( $dir );
                        }
                }
        }