(bug 5791) Fix SQL syntax in Special:BrokenRedirects, was causing incorrect data...

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index aff29f4..d6b0306 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -216,6 +216,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
 * Clean up Special:Imagelist a bit
 * (bug 5838) Namespace names for Nds-NL
 * (bug 5749) Added Tyvan language files
+* (bug 5791) Fix SQL syntax in Special:BrokenRedirects, was causing incorrect data to show
 
 == Compatibility ==
 

diff --git a/includes/SpecialBrokenRedirects.php b/includes/SpecialBrokenRedirects.php
index 72b4211..8c16e50 100644 (file)
--- a/includes/SpecialBrokenRedirects.php
+++ b/includes/SpecialBrokenRedirects.php
@@ -41,8 +41,8 @@ class BrokenRedirectsPage extends PageQueryPage {
                                pl_title
                           FROM $pagelinks AS pl
                    JOIN $page p1 ON (p1.page_is_redirect=1 AND pl.pl_from=p1.page_id)
-                     LEFT JOIN $page AS p2 ON (pl_namespace=p2.page_namespace AND pl_title=p2.page_title
-                               AND p2.page_namespace IS NULL)";
+                     LEFT JOIN $page AS p2 ON (pl_namespace=p2.page_namespace AND pl_title=p2.page_title )
+                               WHERE p2.page_namespace IS NULL";
                return $sql;
        }