Add missing credits from r75975

Remove a few unused array keys in API foreach loops

Remove part of Html::Hidden comment

diff --git a/CREDITS b/CREDITS
index 03e9f82..935b656 100644 (file)
--- a/CREDITS
+++ b/CREDITS
@@ -91,6 +91,7 @@ following names for their contribution to the product.
 * Jidanni
 * Jimmy Xu
 * John Du Hart
+* Jonathan Wiltshire
 * Karun Dambietz
 * Kim Hyun-Joon
 * Lee Worden

diff --git a/includes/Html.php b/includes/Html.php
index a1768df..6c802ca 100644 (file)
--- a/includes/Html.php
+++ b/includes/Html.php
@@ -547,8 +547,7 @@ class Html {
        }
 
        /**
-        * Convenience function to produce an input element with type=hidden, like
-        * Xml::hidden.
+        * Convenience function to produce an input element with type=hidden
         *
         * @param $name    string name attribute
         * @param $value   string value attribute

diff --git a/includes/api/ApiMain.php b/includes/api/ApiMain.php
index 2f21201..4fcb0b2 100644 (file)
--- a/includes/api/ApiMain.php
+++ b/includes/api/ApiMain.php
@@ -833,7 +833,7 @@ class ApiMain extends ApiBase {
 
                $astriks = str_repeat( '*** ', 10 );
                $msg .= "\n\n$astriks Modules  $astriks\n\n";
-               foreach ( $this->mModules as $moduleName => $unused ) {
+               foreach ( $this->mModules as $moduleName ) {
                        $module = new $this->mModules[$moduleName] ( $this, $moduleName );
                        $msg .= self::makeHelpMsgHeader( $module, 'action' );
                        $msg2 = $module->makeHelpMsg();
@@ -852,7 +852,7 @@ class ApiMain extends ApiBase {
                }
 
                $msg .= "\n$astriks Formats  $astriks\n\n";
-               foreach ( $this->mFormats as $formatName => $unused ) {
+               foreach ( $this->mFormats as $formatName ) {
                        $module = $this->createPrinterByName( $formatName );
                        $msg .= self::makeHelpMsgHeader( $module, 'format' );
                        $msg2 = $module->makeHelpMsg();

diff --git a/includes/api/ApiPageSet.php b/includes/api/ApiPageSet.php
index f54f1f8..3b1fd59 100644 (file)
--- a/includes/api/ApiPageSet.php
+++ b/includes/api/ApiPageSet.php
@@ -501,7 +501,7 @@ class ApiPageSet extends ApiQueryBase {
                        if ( $processTitles ) {
                                // The remaining titles in $remaining are non-existent pages
                                foreach ( $remaining as $ns => $dbkeys ) {
-                                       foreach ( $dbkeys as $dbkey => $unused ) {
+                                       foreach ( $dbkeys as $dbkey ) {
                                                $title = Title::makeTitle( $ns, $dbkey );
                                                $this->mAllPages[$ns][$dbkey] = $this->mFakePageId;
                                                $this->mMissingTitles[$this->mFakePageId] = $title;

diff --git a/includes/api/ApiParse.php b/includes/api/ApiParse.php
index de3b371..f6edbb0 100644 (file)
--- a/includes/api/ApiParse.php
+++ b/includes/api/ApiParse.php
@@ -345,7 +345,7 @@ class ApiParse extends ApiBase {
        private function formatIWLinks( $iw ) {
                $result = array();
                foreach ( $iw as $prefix => $titles ) {
-                       foreach ( $titles as $title => $id ) {
+                       foreach ( $titles as $title ) {
                                $entry = array();
                                $entry['prefix'] = $prefix;