* (bug 21114) Special:Contributions no longer shows diff links for new revisions
authorAlexandre Emsenhuber <ialex@users.mediawiki.org>
Wed, 14 Oct 2009 21:19:24 +0000 (21:19 +0000)
committerAlexandre Emsenhuber <ialex@users.mediawiki.org>
Wed, 14 Oct 2009 21:19:24 +0000 (21:19 +0000)
* Removed some code that is newer used ($difftext is always overridden below)

RELEASE-NOTES
includes/specials/SpecialContributions.php

index 4759d17..ce8fd46 100644 (file)
@@ -557,6 +557,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   false on non-special pages
 * (bug 21113) "Other statistics" header on Special:Statistics is no more
   displayed when there isn't any entry in it
+* (bug 21114) Special:Contributions no longer shows diff links for new revisions
 
 == API changes in 1.16 ==
 
index 96b26a1..6674832 100644 (file)
@@ -563,24 +563,13 @@ class ContribsPager extends ReverseChronologicalPager {
                $difftext = $topmarktext = '';
                if( $row->rev_id == $row->page_latest ) {
                        $topmarktext .= '<span class="mw-uctop">' . $this->messages['uctop'] . '</span>';
-                       if( !$row->page_is_new ) {
-                               $difflink = $sk->linkKnown(
-                                       $page,
-                                       $this->messages['diff'],
-                                       array(),
-                                       array( 'diff' => 0 )
-                               );
-                               $difftext .= wfMsg( 'parentheses', $difflink );
-                               # Add rollback link
-                               if( $page->quickUserCan( 'rollback') && $page->quickUserCan( 'edit' ) ) {
-                                       $topmarktext .= ' '.$sk->generateRollback( $rev );
-                               }
-                       } else {
-                               $difftext .= $this->messages['newarticle'];
+                       # Add rollback link
+                       if( !$row->page_is_new && $page->quickUserCan( 'rollback' ) && $page->quickUserCan( 'edit' ) ) {
+                               $topmarktext .= ' '.$sk->generateRollback( $rev );
                        }
                }
                # Is there a visible previous revision?
-               if( !$rev->isDeleted(Revision::DELETED_TEXT) ) {
+               if( !$rev->isDeleted( Revision::DELETED_TEXT ) && $rev->getParentId() !== 0 ) {
                        $difftext = $this->messages['pipe-separator'] . $sk->linkKnown(
                                $page,
                                $this->messages['diff'],