Revert r45389 "Disallow broken Talk:File:x type titles (bug 5280)"

This is doing really weird things, like normalizing 'Talk:Wikipedia:Foo' to 'Wikipedia:Talk:Foo' which then redirects me to 'Talk:Foo' at Wikipedia.

Need to create some test cases for this if it's redone.

diff --git a/includes/Title.php b/includes/Title.php
index d41485c..179bc66 100644 (file)
--- a/includes/Title.php
+++ b/includes/Title.php
@@ -2076,12 +2076,7 @@ class Title {
                                if ( $ns = $wgContLang->getNsIndex( $p )) {
                                        # Ordinary namespace
                                        $dbkey = $m[2];
-                                       # Disallow Talk:File:x type titles...
-                                       if( $this->mNamespace == NS_TALK && $ns > 0 )
-                                               return false; // bug 5280 title issues
                                        $this->mNamespace = $ns;
-                                       if( $ns == NS_TALK && $firstPass )
-                                               continue; # Do another namespace split...
                                } elseif( Interwiki::isValidInterwiki( $p ) ) {
                                        if( !$firstPass ) {
                                                # Can't make a local interwiki link to an interwiki link.