Revert r28576 (by me). Violates the RfC spec on email (mailbox local-part is case...

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index c7ab11d..cfa52d9 100644 (file)
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -248,8 +248,6 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   user-customized ones (like Common.css, Common.js)
 * (bug 12283) Special:Newpages forgets parameters
 * (bug 12031) All namespaces doesn't work in Special:Newpages
-* Email addresses are now not considered case-sensitive in detecting if
-  a user has changed their email address.
 
 == Parser changes in 1.12 ==
 

diff --git a/includes/SpecialPreferences.php b/includes/SpecialPreferences.php
index c1cb374..9fecba1 100644 (file)
--- a/includes/SpecialPreferences.php
+++ b/includes/SpecialPreferences.php
@@ -306,7 +306,7 @@ class PreferencesForm {
                if( $wgEnableEmail ) {
                        $newadr = $this->mUserEmail;
                        $oldadr = $wgUser->getEmail();
-                       if( ($newadr != '') && (strtolower($newadr) != strtolower($oldadr)) ) {
+                       if( ($newadr != '') && ($newadr != $oldadr) ) {
                                # the user has supplied a new email address on the login page
                                if( $wgUser->isValidEmailAddr( $newadr ) ) {
                                        $wgUser->mEmail = $newadr; # new behaviour: set this new emailaddr from login-page into user database record