Remove ancient and deprecated newFromParams() constructor wrappers from various Datab...

diff --git a/includes/db/DatabaseIbm_db2.php b/includes/db/DatabaseIbm_db2.php
index a3a6829..da86f0b 100644 (file)
--- a/includes/db/DatabaseIbm_db2.php
+++ b/includes/db/DatabaseIbm_db2.php
@@ -428,23 +428,6 @@ ERROR;
                }
        }
 
-       /**
-        * Returns a fresh instance of this class
-        *
-        * @param $server String: hostname of database server
-        * @param $user String: username
-        * @param $password String
-        * @param $dbName String: database name on the server
-        * @param $flags Integer: database behaviour flags (optional, unused)
-        * @return DatabaseIbm_db2 object
-        */
-       static function newFromParams( $server, $user, $password, $dbName,
-               $flags = 0 )
-       {
-               return new DatabaseIbm_db2( $server, $user, $password, $dbName,
-                       $flags );
-       }
-
        /**
         * Retrieves the most current database error
         * Forces a database rollback

diff --git a/includes/db/DatabaseMssql.php b/includes/db/DatabaseMssql.php
index c03ffbb..5b3b335 100644 (file)
--- a/includes/db/DatabaseMssql.php
+++ b/includes/db/DatabaseMssql.php
@@ -49,10 +49,6 @@ class DatabaseMssql extends DatabaseBase {
                return false;
        }
 
-       static function newFromParams( $server, $user, $password, $dbName, $flags = 0 ) {
-               return new DatabaseMssql( $server, $user, $password, $dbName, $flags );
-       }
-
        /**
         * Usually aborts on failure
         */

diff --git a/includes/db/DatabaseOracle.php b/includes/db/DatabaseOracle.php
index e15a8f0..28af807 100644 (file)
--- a/includes/db/DatabaseOracle.php
+++ b/includes/db/DatabaseOracle.php
@@ -226,11 +226,6 @@ class DatabaseOracle extends DatabaseBase {
                return true;
        }
 
-       static function newFromParams( $server, $user, $password, $dbName, $flags = 0 )
-       {
-               return new DatabaseOracle( $server, $user, $password, $dbName, $flags );
-       }
-
        /**
         * Usually aborts on failure
         */

diff --git a/includes/db/DatabasePostgres.php b/includes/db/DatabasePostgres.php
index 86492b0..b36240f 100644 (file)
--- a/includes/db/DatabasePostgres.php
+++ b/includes/db/DatabasePostgres.php
@@ -144,10 +144,6 @@ class DatabasePostgres extends DatabaseBase {
                return $this->numRows( $res );
        }
 
-       static function newFromParams( $server, $user, $password, $dbName, $flags = 0 ) {
-               return new DatabasePostgres( $server, $user, $password, $dbName, $flags );
-       }
-
        /**
         * Usually aborts on failure
         */

diff --git a/includes/db/DatabaseSqlite.php b/includes/db/DatabaseSqlite.php
index 1842035..80bf092 100644 (file)
--- a/includes/db/DatabaseSqlite.php
+++ b/includes/db/DatabaseSqlite.php
@@ -42,10 +42,6 @@ class DatabaseSqlite extends DatabaseBase {
         */
        function implicitGroupby()   { return false; }
 
-       static function newFromParams( $server, $user, $password, $dbName, $flags = 0 ) {
-               return new DatabaseSqlite( $server, $user, $password, $dbName, $flags );
-       }
-
        /** Open an SQLite database and return a resource handle to it
         *  NOTE: only $dbName is used, the other parameters are irrelevant for SQLite databases
         */