Merge "Add "mVersion" sanity check to User::loadFromCache()"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Mon, 16 May 2016 19:12:15 +0000 (19:12 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Mon, 16 May 2016 19:12:15 +0000 (19:12 +0000)
includes/user/User.php

index 85bc733..71023c0 100644 (file)
@@ -502,7 +502,10 @@ class User implements IDBAccessObject {
                $data = $processCache->get( $key );
                if ( !is_array( $data ) ) {
                        $data = $cache->get( $key );
-                       if ( !is_array( $data ) || $data['mVersion'] < self::VERSION ) {
+                       if ( !is_array( $data )
+                               || !isset( $data['mVersion'] )
+                               || $data['mVersion'] < self::VERSION
+                       ) {
                                // Object is expired
                                return false;
                        }