Merge "MediaSearchWidget: Listen to "change" event to reposition"
authorjenkins-bot <jenkins-bot@gerrit.wikimedia.org>
Mon, 10 Apr 2017 18:59:12 +0000 (18:59 +0000)
committerGerrit Code Review <gerrit@wikimedia.org>
Mon, 10 Apr 2017 18:59:12 +0000 (18:59 +0000)
resources/src/mediawiki.widgets/MediaSearch/mw.widgets.MediaSearchWidget.js

index c6938e8..5cbd2ec 100644 (file)
@@ -65,7 +65,7 @@
                this.$results.on( 'scroll', this.onResultsScroll.bind( this ) );
                this.$query.append( this.noItemsMessage.$element );
                this.results.connect( this, {
-                       add: 'onResultsAdd',
+                       change: 'onResultsChange',
                        remove: 'onResultsRemove'
                } );
 
         *
         * @param {mw.widgets.MediaResultWidget[]} items An array of item elements
         */
-       mw.widgets.MediaSearchWidget.prototype.onResultsAdd = function ( items ) {
+       mw.widgets.MediaSearchWidget.prototype.onResultsChange = function ( items ) {
                var search = this;
 
+               if ( !items.length ) {
+                       return;
+               }
+
                // Add method to a queue; this queue will only run when the widget
                // is visible
                this.layoutQueue.push( function () {