Follow up r76708

1) IPTest::testValidBlocks
Undefined variable: invalid in phase3/maintenance/tests/phpunit/includes/IPTest.php:174

2) IPTest::testInvalidBlocks
Undefined variable: invalid in phase3/maintenance/tests/phpunit/includes/IPTest.php:197

Note that the 30.242.52.14/0 test does not pass (it is deemed a valid block)

diff --git a/maintenance/tests/phpunit/includes/IPTest.php b/maintenance/tests/phpunit/includes/IPTest.php
index 3e751ad..7d895b9 100644 (file)
--- a/maintenance/tests/phpunit/includes/IPTest.php
+++ b/maintenance/tests/phpunit/includes/IPTest.php
@@ -171,14 +171,14 @@ class IPTest extends PHPUnit_Framework_TestCase {
                        '::fe:f:2001/1',
                        '::6d:f:2001/8',
                );
-               foreach ( $invalid as $i ) {
+               foreach ( $valid as $i ) {
                        $this->assertTrue( IP::isValidBlock( $i ), "$i is a valid IP block" );
                }
        }
 
        // tests isValidBlock()
        public function testInvalidBlocks() {
-               $valid = array(
+               $invalid = array(
                        '116.17.184.5/33',
                        '0.17.184.5/130',
                        '16.17.184.1/-1',