Reedy [Wed, 26 Apr 2017 16:08:51 +0000 (17:08 +0100)]
Making numerous fields unsigned to match their target referenced column
Bug: T157227
Change-Id: Ic11822d6c893103adcc99a3e188a592f13c968b8
jenkins-bot [Wed, 6 Sep 2017 13:12:13 +0000 (13:12 +0000)]
Merge "Move around "ا" to after "آ" and not before"
Mark A. Hershberger [Tue, 5 Sep 2017 18:18:02 +0000 (14:18 -0400)]
Note whether a category was added in a machine readable way
CategoryMembershipChange is great, but it doesn't have a
machine-readable way to see if the category has been added or removed
from the page. We could parse the comments, but that would rely on
reading the comments and matching the message against the translated
strings.
This patch adds a couple of parameters and notes whether the change
was an addition or removal in rc_params.
Also, puts the evaluation of the AbortEmailNotification hook before
the check of rc_type in the hopes that the extension CatWatch can send
out emails at the right time.
Bug: T175052
Change-Id: I3e2ac0cc148b9d618e2f8b7853b14bff827ee443
jenkins-bot [Wed, 6 Sep 2017 00:22:51 +0000 (00:22 +0000)]
Merge "WLFilters: hide watchlist-details during loading of the app"
jenkins-bot [Wed, 6 Sep 2017 00:21:57 +0000 (00:21 +0000)]
Merge "RCLFilters: Bring back Saved Queries"
Matthew Flaschen [Tue, 5 Sep 2017 23:43:39 +0000 (19:43 -0400)]
More thorough documentation for ChangesListSpecialPageStructuredFilters
Change-Id: Iacb3f36c0c2eaf109c39005b4cbd5ff434eb1d84
jenkins-bot [Tue, 5 Sep 2017 23:10:29 +0000 (23:10 +0000)]
Merge "Update OOjs UI to v0.23.0"
jenkins-bot [Tue, 5 Sep 2017 22:20:42 +0000 (22:20 +0000)]
Merge "RCFilters: make isStructuredFilterUiEnabled public"
Volker E [Tue, 5 Sep 2017 22:07:32 +0000 (15:07 -0700)]
Update OOjs UI to v0.23.0
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.23.0
Depends-on: I26318472e5e0f5d1863525cf997d08973e2b931c
Change-Id: Icf1ad51da9d588226591366f822cabdd732f9018
MusikAnimal [Tue, 5 Sep 2017 21:21:55 +0000 (17:21 -0400)]
Fix maintenance script that populates the ip_changes table
Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b914e065
MusikAnimal [Fri, 21 Apr 2017 16:17:59 +0000 (12:17 -0400)]
Add basic IP range support to Special:Contributions
This works by using the new table introduced with T156318.
The only thing that differs from normal Special:Contribs is we are
showing the IP address next to each entry. This is it how it is
displayed if you request to see newbie contributions:
https://en.wikipedia.org/wiki/Special:Contributions?contribs=newbie
For the time being, Special:DeletedContributions does not support
IP ranges. Various other irrelevant links such as Uploads and Logs
are also hidden.
Refer to P4725 for a way to automate creation of edits by random
IPs in your dev environment.
IP::isValidBlock() has been deprecated with this dependent change:
https://gerrit.wikimedia.org/r/#/c/373165/
Bug: T163562
Change-Id: Ice1bdae3d16cf365da14c6df0e8d91d2b914e064
jenkins-bot [Tue, 5 Sep 2017 19:56:16 +0000 (19:56 +0000)]
Merge "CommentStore: Try to improve description of insert()"
Translation updater bot [Tue, 5 Sep 2017 19:55:32 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id6736ce3f2ba9f37ec4886fd1c96956f1e7a6289
Kunal Mehta [Tue, 5 Sep 2017 19:02:33 +0000 (12:02 -0700)]
CommentStore: Try to improve description of insert()
And the similar insertWithTempTable() too.
Change-Id: Ibf0f96d3b9b0f7fe53eb9e11b94fabadc4580632
Stephane Bisson [Tue, 5 Sep 2017 18:49:19 +0000 (14:49 -0400)]
RCLFilters: Bring back Saved Queries
Saved Queries used to be shown on Special:RecentChangesLinked
but it got lost when refactoring the top section to accomodate
Watchlist.
Change-Id: I2411dd068415a40cceef76833e94e184f57554af
jenkins-bot [Tue, 5 Sep 2017 18:39:21 +0000 (18:39 +0000)]
Merge "Handle comment truncation in CommentStore"
tjlsangria [Fri, 28 Oct 2016 14:33:32 +0000 (15:33 +0100)]
Convert INDEX into PRIMARY KEY in l10n_cache
Bug: T146591
Change-Id: I85ab18bfa30e562e76253e3ef71653dbf46db041
jenkins-bot [Tue, 5 Sep 2017 17:35:23 +0000 (17:35 +0000)]
Merge "EditPage: Hard deprecate submit()"
jenkins-bot [Tue, 5 Sep 2017 17:34:20 +0000 (17:34 +0000)]
Merge "EditPage: Don't use RequestContext::getMain()"
jenkins-bot [Tue, 5 Sep 2017 17:34:10 +0000 (17:34 +0000)]
Merge "EditPage: Don't use $wgOut"
jenkins-bot [Tue, 5 Sep 2017 16:00:51 +0000 (16:00 +0000)]
Merge "Enable save button when removing item from UsersMultiselectWidget list"
Timo Tijhof [Tue, 5 Sep 2017 15:29:34 +0000 (17:29 +0200)]
resourceloader: Reduce severity for non-fatal JS errors to warn()
Follows-up
37df74151 and
12cca1c6, which made the internal exceptions
from sortDependencies() for unknown modules, or circular dependencies,
get logged to the console instead of silently caught.
There were logged using mw.track('resourceloader.exception') which
get logged to the console using console.error() by default.
Change this to using console.warn() instead.
Until
37df74151 and
12cca1c6, messages from `resourceloader.exception` where
quite rare. However both the rare cases, as well as the cases we added in
these commits, are non-fatal. Given various false reports in recent weeks
on Phabricator from users thinking they are witnessing fatal errors, let's
change the severity level of these in the browser console to "warn" instead
of "error", which makes them easier to distinguish from fatal errors.
Change-Id: I8d7aff6c72e74836c034b18a5ff58428d27628ff
jenkins-bot [Tue, 5 Sep 2017 10:50:55 +0000 (10:50 +0000)]
Merge "Check for Wikidiff2 version 0.3 NOT for 0.3.0"
jenkins-bot [Tue, 5 Sep 2017 08:56:06 +0000 (08:56 +0000)]
Merge "Fix RestbaseVirtualRESTService URL standardization"
Kunal Mehta [Tue, 5 Sep 2017 06:09:55 +0000 (23:09 -0700)]
EditPage: Hard deprecate submit()
Change-Id: I456139a8bd968dd3199225d6526624e778ed3381
Kunal Mehta [Tue, 5 Sep 2017 05:55:43 +0000 (22:55 -0700)]
EditPage: Don't use RequestContext::getMain()
We already have a context object.
Change-Id: I09816dd485413d858e5ee422ae07a843cb543da5
Kunal Mehta [Tue, 5 Sep 2017 05:52:46 +0000 (22:52 -0700)]
EditPage: Don't use $wgOut
Use $this->context->getOutput() instead everywhere, except in one static
function, that will be dealt with later.
For the most part OutputPage is a singleton, so this should affect very
little.
Bug: T144366
Change-Id: I59699a47e55f281284c5e96676cfe7bc0c499e28
jenkins-bot [Tue, 5 Sep 2017 06:23:55 +0000 (06:23 +0000)]
Merge "EditPage: Deprecate getCheckboxes() and getCheckboxesOOUI()"
David Barratt [Mon, 4 Sep 2017 23:19:42 +0000 (19:19 -0400)]
Enable save button when removing item from UsersMultiselectWidget list
UsersMultiselectWidget uses a hidden input to store values. Hidden inputs do not trigger onChange events. The onChange event must be trigger manually.
Bug: T173973
Change-Id: Ib9ec31791f1fe7bdde8d91ae16a2111f4320c615
Translation updater bot [Mon, 4 Sep 2017 19:55:23 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I896047415adbedd7d474845a1dac4531d9c8d196
Kunal Mehta [Mon, 4 Sep 2017 18:05:26 +0000 (11:05 -0700)]
Always put type information before variable name for @var tags
Like other tags, @var should have the type information before the
variable name.
<https://docs.phpdoc.org/references/phpdoc/tags/var.html>
Change-Id: I9eca6957b1990fa8cc687103dc02ee38af5f9086
jenkins-bot [Mon, 4 Sep 2017 17:29:28 +0000 (17:29 +0000)]
Merge "SpecialUpload: Stop loading 'mediawiki.action.edit'"
Reedy [Mon, 4 Sep 2017 16:25:34 +0000 (17:25 +0100)]
Fix you -> your in 'pagedata-text' message
Bug: T174961
Change-Id: I7cfcfca4decac3e2afc09e58959a001ac13d3d49
jenkins-bot [Mon, 4 Sep 2017 16:23:30 +0000 (16:23 +0000)]
Merge "Turn Special:NewFiles list of media types into list of checkboxes"
Bartosz Dziewoński [Mon, 4 Sep 2017 16:04:28 +0000 (18:04 +0200)]
SpecialUpload: Stop loading 'mediawiki.action.edit'
The comment says it's for <charinsert> support, but that's not true
anymore, as the CharInsert extension itself takes care of loading its
script on Special:Upload (see CharInsert::onBeforePageDisplay()).
Back in the day, this module included a lot more stuff related to the
edit toolbar and such, so this might have been warranted, but there is
nothing useful for uploading left in it anymore.
It's very unintuitive that it would be loaded there; folks did not
realize that it is the case and recent changes to the module started
causing issues on Special:Upload.
Bug: T174935
Change-Id: I11e886801a27f796e5a5935ec9c93b1329cc5b87
jenkins-bot [Mon, 4 Sep 2017 14:34:50 +0000 (14:34 +0000)]
Merge "Drop compatibility with PHP 5.3"
jenkins-bot [Mon, 4 Sep 2017 14:10:06 +0000 (14:10 +0000)]
Merge "Fix typo in ILBFactory::waitForReplication phpdoc"
jenkins-bot [Mon, 4 Sep 2017 12:36:37 +0000 (12:36 +0000)]
Merge "resourceloader: Preload base modules request from startup module"
Tobias Gritschacher [Mon, 4 Sep 2017 11:58:49 +0000 (13:58 +0200)]
Check for Wikidiff2 version 0.3 NOT for 0.3.0
version_compare( '0.3', '0.3.0', '>=' ) gives false, so we need to check
for 0.3 since the Wikidiff2 version is defined as 0.3 in
https://gerrit.wikimedia.org/r/#/c/319866/60/Wikidiff2.h
Bug: T166571
Change-Id: Id6e9f402af2fab784a3db2444f201022e2d0de3e
Translation updater bot [Sun, 3 Sep 2017 19:54:41 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I7b033dfc8380deaed29661b51cacc29f08c5b7f6
Translation updater bot [Sun, 3 Sep 2017 06:21:33 +0000 (08:21 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I5ae624cf1b2ed597abb2ffb96dc6f13267e93967
jenkins-bot [Sun, 3 Sep 2017 01:34:05 +0000 (01:34 +0000)]
Merge "EditPage: Remove unused variable in getCheckboxesOOUI()"
Bartosz Dziewoński [Mon, 28 Aug 2017 17:47:01 +0000 (19:47 +0200)]
EditPage: Deprecate getCheckboxes() and getCheckboxesOOUI()
Follow-up to
478caa076f75fde935c66eb9334410d868c30818, which asked
for someone else to disentangle that. After this patch, we're left
with separate blocks of code that can just be deleted when we remove
the EditPageBeforeEditChecks hook or the getCheckboxes() function.
Change-Id: I88d2dda3a6e030f73e209e0d389d4c0aa6c45139
Matěj Suchánek [Sat, 2 Sep 2017 18:01:44 +0000 (20:01 +0200)]
Drop compatibility with PHP 5.3
Since 5.4, $this works inside closures.
Change-Id: I6987f76a1e33d6d7ab020a57186e5477186bbf2e
Derk-Jan Hartman [Sat, 2 Sep 2017 08:51:48 +0000 (10:51 +0200)]
TableSorter: Sort unrecognized dates as -Infinity
Follow-up to: I664b4cc
Bug: T174814
Change-Id: I028681172be7a30e51cab42847c4fc35e9358aca
Translation updater bot [Sat, 2 Sep 2017 07:16:49 +0000 (09:16 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibf8a472053f8dafc581fbe3bd8d9be188048995d
jenkins-bot [Fri, 1 Sep 2017 22:14:18 +0000 (22:14 +0000)]
Merge "WLFilters: reword watchlist-details slightly"
jenkins-bot [Fri, 1 Sep 2017 22:08:10 +0000 (22:08 +0000)]
Merge "mediawiki.special.changeslist.legend.js: Remove wait for document ready"
Fomafix [Fri, 1 Sep 2017 21:39:30 +0000 (23:39 +0200)]
mediawiki.special.changeslist.legend.js: Remove wait for document ready
mw.hook( 'wikipage.content' ) gets fired after document ready.
Change-Id: Ia1536e734f8ae08cc7cc07c3b1854bdaafb54866
jenkins-bot [Fri, 1 Sep 2017 20:20:40 +0000 (20:20 +0000)]
Merge "Remove reference to deprecated IDatabase->nextSequenceValue()"
Stephane Bisson [Fri, 1 Sep 2017 19:52:49 +0000 (15:52 -0400)]
WLFilters: reword watchlist-details slightly
It won't show up like this on en.wp due to
site customization but other wikis will see it.
Bug: T172030
Change-Id: I2dbaad3c5f8200d95431fda6f246decdb1633c62
jenkins-bot [Fri, 1 Sep 2017 20:17:01 +0000 (20:17 +0000)]
Merge "EditPage: Restore getSummaryInput(); deprecate it and getSummaryInputOOUI()"
Bartosz Dziewoński [Wed, 30 Aug 2017 18:33:23 +0000 (20:33 +0200)]
EditPage: Restore getSummaryInput(); deprecate it and getSummaryInputOOUI()
Follow-up to
478caa076f75fde935c66eb9334410d868c30818.
We can't just remove it without a deprecation.
Change-Id: I3286e8de12bacb50a6d080477adbecf09b3be71c
Stephane Bisson [Fri, 1 Sep 2017 19:55:02 +0000 (15:55 -0400)]
WLFilters: hide watchlist-details during loading of the app
Bug: T172030
Change-Id: Ia9e9006b3c4023b346b5c2cfb1c295c25f375764
Brad Jorsch [Fri, 1 Sep 2017 18:30:53 +0000 (14:30 -0400)]
Handle comment truncation in CommentStore
Since the caller doesn't (and shouldn't) know whether CommentStore is
using the old or the new schema, it should leave truncation of comments
to CommentStore.
Change-Id: I92954c922514271d774518d6a6c28a01f33c88c2
jenkins-bot [Fri, 1 Sep 2017 18:54:57 +0000 (18:54 +0000)]
Merge "WLFilters: fix msg keys to comply with standard"
Stephane Bisson [Fri, 1 Sep 2017 14:47:40 +0000 (10:47 -0400)]
RCFilters: make isStructuredFilterUiEnabled public
... so it can be used by ORES to know if it's
enabled on a specific page without duplicating
the checks of global variables, user preferences,
and request parameters.
Bug: T174725
Change-Id: I1cb402559edb242b40a77f509480560f0636264d
jenkins-bot [Fri, 1 Sep 2017 18:21:15 +0000 (18:21 +0000)]
Merge "RCFilters: Minimize vertical spacing; get rid of legend and <br>s"
Stephane Bisson [Fri, 1 Sep 2017 18:07:45 +0000 (14:07 -0400)]
WLFilters: fix msg keys to comply with standard
Change-Id: Iea19ddb38b362fb01535cde595d82cc7fd1ad479
Moriel Schottlender [Thu, 24 Aug 2017 23:52:29 +0000 (16:52 -0700)]
RCFilters: Minimize vertical spacing; get rid of legend and <br>s
Bug: T174121
Change-Id: I2249bf3d313232fe2f0dff6e34c5140885a13735
Reedy [Fri, 1 Sep 2017 16:39:50 +0000 (17:39 +0100)]
Remove patch-log_search-rename-index.sql from MW 1.16 updaters
Otherwise, the PK on log_search keeps getting dropped, ls_field_val readded and
this is then repeated on every run of update.php
Change-Id: I6b00933c29b5e24ec2833001fcf45053292d190c
Follows-up: Id635297838938c7c5dfe65d45285a4d16d65152d
Brad Jorsch [Fri, 1 Sep 2017 13:46:43 +0000 (09:46 -0400)]
Remove reference to deprecated IDatabase->nextSequenceValue()
The method was deprecated and made unnecessary in Ib308190c.
Change-Id: I1729ac0b3a88270a4c2f064187a2472112aaeb1e
jenkins-bot [Fri, 1 Sep 2017 11:18:11 +0000 (11:18 +0000)]
Merge "Re add wpScrolltop id in EditPage"
jenkins-bot [Fri, 1 Sep 2017 09:39:07 +0000 (09:39 +0000)]
Merge "Deprecate IDatabase::nextSequenceValue()"
addshore [Fri, 1 Sep 2017 09:35:23 +0000 (12:35 +0300)]
Re add wpScrolltop id in EditPage
Regression from:
I9bd66b8444c069b4055fc5c3396256b688b78561
Bug: T174723
Change-Id: I2c174eaab822b5990663503ca9258a5811425054
Translation updater bot [Fri, 1 Sep 2017 07:03:09 +0000 (09:03 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ib2b10d3b2e691568eafcdf2342cd703487013dca
jenkins-bot [Fri, 1 Sep 2017 03:58:21 +0000 (03:58 +0000)]
Merge "EtcdConfig: allow slashes in config key names"
Tim Starling [Fri, 1 Sep 2017 01:53:18 +0000 (11:53 +1000)]
EtcdConfig: allow slashes in config key names
Allowing slashes in config key names allows us to trivially support the
proposed hierarchical structure with a single EtcdConfig object, by
fetching values with the relevant prefixes on startup.
Bug: T156924
Change-Id: Ica0914e61baba9c0462481925be15d79b66dc342
Timo Tijhof [Tue, 18 Jul 2017 02:36:25 +0000 (21:36 -0500)]
resourceloader: Preload base modules request from startup module
This allows browsers that support W3C Preload <https://www.w3.org/TR/preload/>,
to start downloading and parsing the second load.php JavaScript request
as soon as the headers of the startup module arrive.
Before:
- HTML request, response start.
|\- Discover <script src async> for startup.js, request, response start.
| \ - Startup response end, JS parsing.
| |
|__|- HTML parsing and rendering yields for async JS execution.
\- JavaScript inserts <script>, Base-modules request starts. <<<
After:
- HTML request, response start.
|\- Discover <script src async> for startup.js, request, response start
\ - Base-modules request starts. <<<
| |- Startup response end, JS parsing.
| |
|__|- HTML parsing and rendering yields for async JS execution.
\- JavaScript inserts <script>. (Base-modules req on-going, or done)
On local testing with "Slow 3G" network throttling in Chrome,
this reduced page load time (window.onload, time to interaction for JS)
by about 1 second (from 14s to 13s).
See also https://phabricator.wikimedia.org/T164299#
3572231
Bug: T164299
Change-Id: I7047f4ab881947cf3392256087cc5a0cb177dd3a
jenkins-bot [Fri, 1 Sep 2017 00:57:54 +0000 (00:57 +0000)]
Merge "Revert "Fix link prefix/suffixes around Category and Language links.""
Tim Starling [Fri, 1 Sep 2017 00:36:41 +0000 (00:36 +0000)]
Revert "Fix link prefix/suffixes around Category and Language links."
This reverts commit
c66c9aa5352743b2f87bc4627a1be529c5d18535.
Bug: T174639
Change-Id: Ibf6d3780f384ba8edc80bf28c893f1aee8ce28a8
jenkins-bot [Thu, 31 Aug 2017 21:02:12 +0000 (21:02 +0000)]
Merge "Move section ID fallbacks into headers themselves"
jenkins-bot [Thu, 31 Aug 2017 18:27:57 +0000 (18:27 +0000)]
Merge "WLFilters: fix server-side tag filtering"
jenkins-bot [Thu, 31 Aug 2017 17:47:05 +0000 (17:47 +0000)]
Merge "WLFilters: wrap Watchlist-details in a div instead of a p"
jenkins-bot [Thu, 31 Aug 2017 17:37:39 +0000 (17:37 +0000)]
Merge "WLFilters: adapt to customized watchlist-details"
jenkins-bot [Thu, 31 Aug 2017 17:37:35 +0000 (17:37 +0000)]
Merge "EditPage: Make getCheckboxesDefinition() public"
Stephane Bisson [Thu, 31 Aug 2017 16:17:36 +0000 (12:17 -0400)]
WLFilters: wrap Watchlist-details in a div instead of a p
Bug: T172030
Change-Id: I65c50d75b21b3e5d7b69fdecb79c032f5d1d8853
Bartosz Dziewoński [Thu, 31 Aug 2017 15:24:08 +0000 (17:24 +0200)]
EditPage: Make getCheckboxesDefinition() public
Bug: T174613
Change-Id: I2dc4104580ac36551ec1ca0deed38ce50e5473ac
Brad Jorsch [Thu, 31 Aug 2017 00:27:51 +0000 (20:27 -0400)]
Deprecate IDatabase::nextSequenceValue()
It's often forgotten because MySQL and Sqlite don't use it, the only
users are PostgreSQL and Oracle. And when used, if inserts to multiple
tables are being done it's easy to get the ordering wrong.
This patch reimplements DatabasePostgres::insertId() in terms of PG's
lastval() function, and adds triggers to the Oracle schema to make it
work the same as the other databases.
Bug: T164900
Change-Id: Ib308190c52673a9266c8495a589ae644f9fbefce
Bartosz Dziewoński [Thu, 31 Aug 2017 14:37:40 +0000 (16:37 +0200)]
EditPage: Remove unused variable in getCheckboxesOOUI()
This was unnecessarily copypasted from getCheckboxes().
The label's 'id' attribute is correctly being set below.
Change-Id: I1557461bfd16c22bb949e26d419e154f80c963d7
jenkins-bot [Thu, 31 Aug 2017 12:46:17 +0000 (12:46 +0000)]
Merge "RCFilters: Make top links in RecentChanges expand to full-width"
Stephane Bisson [Thu, 31 Aug 2017 12:24:24 +0000 (08:24 -0400)]
WLFilters: adapt to customized watchlist-details
The watchlist-details message is sometimes customized
to add community notices, which makes it much taller.
This fixes the position of the 'edit watchlist' button
so it's always right and bottom aligned regardless of
the size of the watchlist-details section.
Bug: T172030
Change-Id: I8b6b9d799f7929a1d78c8f0e30020a4222fc3bb6
Prateek Saxena [Thu, 31 Aug 2017 11:11:06 +0000 (21:11 +1000)]
UploadFromUrl: Fix typo
Change-Id: I4df0db5b4a0df0191e1eaa305fc49f1959c4a354
Stephane Bisson [Wed, 30 Aug 2017 15:31:41 +0000 (11:31 -0400)]
WLFilters: fix server-side tag filtering
Tag filtering was enabled in the UI but the
backend was not properly wired for it.
Change-Id: I1c50b67b0a4aaddb561e79fdacd9849ffe0ded8c
addshore [Thu, 31 Aug 2017 09:54:23 +0000 (12:54 +0300)]
Fix typo in ILBFactory::waitForReplication phpdoc
Change-Id: Ifd79c80af49b03744190e4c5af56c904550fffcd
Amir Sarabadani [Fri, 18 Aug 2017 20:59:56 +0000 (00:59 +0400)]
Move around "ا" to after "آ" and not before
Bug: T173601
Change-Id: I0f6b3ecc2800180a2c6a8217803411862a299e04
Moriel Schottlender [Wed, 30 Aug 2017 23:27:48 +0000 (16:27 -0700)]
RCFilters: Make top links in RecentChanges expand to full-width
Bug: T174617
Change-Id: Iff4c563b894eaaf713d3818a97928d0342b1ca23
Chad Horohoe [Wed, 30 Aug 2017 23:44:35 +0000 (16:44 -0700)]
DB excepions: consistently declare constructors as public
Also DBTransactionSizeError::getKey() while we're here
Change-Id: Ic76abf3ca0bf74dd96018d67da466365957bf3b1
Brad Jorsch [Wed, 30 Aug 2017 19:51:50 +0000 (15:51 -0400)]
Fix various PostgreSQL failures
* Fix schema for image_comment_temp.
* Provide values in CommentStoreTest::provideInsertRoundTrip() for
columns where the PG schema doesn't have a default value but the MySQL
schema does.
* Call nextSequenceValue() from CommentStoreTest::testInsertRoundTrip().
* Correctly handle $options being the string 'FOR UPDATE' in
DatabasePostgres::selectSQLText()
* Correctly handle the initial table in DatabasePostgres::selectSQLText() FOR
UPDATE mangling.
* Correctly handle aliases in DatabasePostgres::selectSQLText() FOR
UPDATE mangling.
Tests in PG are still going to be broken thanks to the fact that
nextSequenceValue() and insertId() can't be separated by another
nextSequenceValue()/insertId() pair. That should be taken care of by
T164898/T164900.
Change-Id: Ia770a003ca9170ab8bcc1436d8afe30700e00ada
Stephane Bisson [Wed, 30 Aug 2017 20:05:42 +0000 (16:05 -0400)]
WLFilters: describe how unseen changes should look
Makes the unseen changes description customizable
based on whether or not the beta feature is enabled.
Bug: T172030
Change-Id: I0cef7e5fb261e12f3ca069e7409f3aea3fc874cf
jenkins-bot [Wed, 30 Aug 2017 19:42:27 +0000 (19:42 +0000)]
Merge "Only do one query for page ids in PageProps::getGoodIDs"
jenkins-bot [Wed, 30 Aug 2017 19:05:16 +0000 (19:05 +0000)]
Merge "Fix highlight display for enhanced mode"
jenkins-bot [Wed, 30 Aug 2017 18:39:20 +0000 (18:39 +0000)]
Merge "WLFilters: convert 'edit watchlist' button to new UX"
jenkins-bot [Wed, 30 Aug 2017 18:38:11 +0000 (18:38 +0000)]
Merge "Batch request titles for cdn purge from db"
Marius Hoch [Wed, 30 Aug 2017 18:32:19 +0000 (20:32 +0200)]
Only do one query for page ids in PageProps::getGoodIDs
Change-Id: I0d1cff3173d54de0b8fadb5bf9766789ffe030a4
Moriel Schottlender [Thu, 3 Aug 2017 01:29:25 +0000 (18:29 -0700)]
Fix highlight display for enhanced mode
Bug: T170875
Change-Id: Ibd7d447aba1ae5576ea637a2d5ef06cb3f622b26
Erik Bernhardson [Tue, 29 Aug 2017 16:30:14 +0000 (09:30 -0700)]
Batch request titles for cdn purge from db
Xenon shows a significant amount of time is spent individually fetching
the content model for titles being purged. It's probably not a huge
improvement but lets fetch them all in one go instead of lazily as
needed.
Change-Id: I71af6f13c84e740c1367617d7a51210501363b33
Stephane Bisson [Mon, 28 Aug 2017 20:45:21 +0000 (16:45 -0400)]
WLFilters: convert 'edit watchlist' button to new UX
Bug: T172030
Change-Id: Ifcde40c66fbb6543d4f2aebfc8499c03533b8b91
jenkins-bot [Wed, 30 Aug 2017 18:00:38 +0000 (18:00 +0000)]
Merge "RCFilters: rephrase the feedback link text"
jenkins-bot [Wed, 30 Aug 2017 16:54:15 +0000 (16:54 +0000)]
Merge "Fix index in PostgreSQL schema"