Kunal Mehta [Thu, 29 Jan 2015 04:46:13 +0000 (20:46 -0800)]
replacers: Set explicit visiblity on functions
Change-Id: I4f35ea9b4bd2503bc612dc25dc8d34fc5ca040a0
Kunal Mehta [Thu, 29 Jan 2015 04:42:25 +0000 (20:42 -0800)]
Move "Replacers" into includes/libs/replacers/
Split into separate files while we're at it
Change-Id: I0bba4dcea686de088bd96964833fe6fb649a41e9
Kunal Mehta [Wed, 7 Jan 2015 19:12:09 +0000 (11:12 -0800)]
Turn Utf8Test into a PHPUnit test case
Change-Id: I7e709f475a37a592fb3052f367894ebce32310f3
Kunal Mehta [Wed, 7 Jan 2015 18:41:51 +0000 (10:41 -0800)]
Move includes/normal to includes/libs/normal
Change-Id: Ib530ad9dbe1d3a33dc53ef8b9620f61d4e1a2d62
jenkins-bot [Wed, 28 Jan 2015 23:37:59 +0000 (23:37 +0000)]
Merge "Output COPYING files as plain text in Special:Version/License/*"
jenkins-bot [Wed, 28 Jan 2015 23:33:50 +0000 (23:33 +0000)]
Merge "Add OutputPage::enableOOUI() to set up OOUI stuff when needed"
jenkins-bot [Wed, 28 Jan 2015 23:31:37 +0000 (23:31 +0000)]
Merge "Update and enrich API documentation"
Translation updater bot [Wed, 28 Jan 2015 21:17:46 +0000 (21:17 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Wed, 28 Jan 2015 21:12:34 +0000 (22:12 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I421056addc820a66a5912b9d4c23255302768cba
Ricordisamoa [Wed, 28 Jan 2015 21:04:31 +0000 (22:04 +0100)]
Output COPYING files as plain text in Special:Version/License/*
The vast majority of them consist of the GNU GPL, which is in
plain text format and not supposed to be converted into wikitext.
Change-Id: Iaa30b8994b8e4034ace61df8202a8b5002093ff2
umherirrender [Tue, 27 Jan 2015 20:35:42 +0000 (21:35 +0100)]
Escape return value from Skin::getUndeleteLink
Bug: T85864
Change-Id: I7a5dfc8ecd2f84da0dce3e1357af462a3c0da23f
jenkins-bot [Wed, 28 Jan 2015 20:52:05 +0000 (20:52 +0000)]
Merge "Special:AllMessages: Ignore case of first letter when sorting"
jenkins-bot [Wed, 28 Jan 2015 20:45:22 +0000 (20:45 +0000)]
Merge "Only try to load UtfNormalDefines.php once"
jenkins-bot [Wed, 28 Jan 2015 20:43:32 +0000 (20:43 +0000)]
Merge "Fix doc for ManualLogEntry::setParameters()"
Kunal Mehta [Wed, 7 Jan 2015 18:27:01 +0000 (10:27 -0800)]
Only try to load UtfNormalDefines.php once
It's already loaded in Defines.php, so no need to do it again
Change-Id: Ie6f3bf3fbbcbaadd85cfc8e54527b93e98f7b898
Siebrand Mazeland [Tue, 28 Oct 2014 17:37:47 +0000 (18:37 +0100)]
Update and enrich API documentation
As discussed previously with Brad. I've done the first 10% or so of the
documentation. Once this has been merged, I'll continue with the rest.
Change-Id: Iaef77a14b2bc184ca28bac02087e67744d4573d4
Brad Jorsch [Wed, 28 Jan 2015 19:15:13 +0000 (11:15 -0800)]
Fix doc for ManualLogEntry::setParameters()
Numbered-and-named parameters are "number:type:name" (where "type" is
often empty), not "number:name".
Change-Id: I417a3d6caf929a94ffed5e315692950295b3be0d
umherirrender [Wed, 28 Jan 2015 18:16:44 +0000 (19:16 +0100)]
Pass user to Title::userCan in InfoAction
Change-Id: Id4dac8ca3b36839abdb184d0ad538b2400aa80ff
Sam Reed [Tue, 27 Jan 2015 06:02:56 +0000 (06:02 +0000)]
Don't split regex string unnecessarily
Change-Id: Id5912e64916ce5c7be2991478c32531596917540
JuneHyeon Bae [Wed, 28 Jan 2015 11:18:08 +0000 (20:18 +0900)]
Add plainlinks class to <h2> in Special:Version
Make "Parser extension tags" and "Parser function hooks" <h2> external
links to plainlink by adding plainlinks class to <h2>.
Bug: T70426
Change-Id: Ibbef62ff5bb0457eb25b9964c190c3e8283b2610
Siebrand Mazeland [Wed, 14 Jan 2015 18:25:21 +0000 (19:25 +0100)]
Make Sanitizer::removeHTMLtags() and ::removeHTMLComments public
The functions are used in at least 5 extensions in Gerrit, so not private
at all.
Change-Id: Id6d7b82d7333184ff2b1dcd592a80af30a50a889
jenkins-bot [Wed, 28 Jan 2015 13:42:26 +0000 (13:42 +0000)]
Merge "SpecialMovepage: Correctly apply target namespace to subpages"
jenkins-bot [Wed, 28 Jan 2015 13:37:59 +0000 (13:37 +0000)]
Merge "Import: Fix error reporting"
Rohan [Fri, 1 Aug 2014 14:21:12 +0000 (19:51 +0530)]
SpecialMovepage: Correctly apply target namespace to subpages
Previously, moving a page from a subject namespace to a talk namespace
(or vice-versa), resulted in the subpages being moved to the new page
name, but still in the old namespace.
Bug: T44024
Change-Id: Iefc5b495e777840dc6a2fe1226b8869d807f2d94
jenkins-bot [Tue, 27 Jan 2015 21:48:39 +0000 (21:48 +0000)]
Merge "Run clearSearchIndex when mysql in rebuildTextIndex"
Translation updater bot [Tue, 27 Jan 2015 20:46:43 +0000 (21:46 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibce6a86870950a0ba414f52078cbe4f98dee7032
addshore [Tue, 27 Jan 2015 18:22:07 +0000 (10:22 -0800)]
Run clearSearchIndex when mysql in rebuildTextIndex
Bug: T64276
Change-Id: If86fe65dbbc04e4d83882155ec50375f9e179581
Kunal Mehta [Tue, 27 Jan 2015 07:00:07 +0000 (23:00 -0800)]
registration: Ignore keys prefixed with @ in "config"
This will allow for documentation of individual configuration
options.
Change-Id: I180bc742c96985c2a8358aef814d993fca9aba84
Sam Reed [Tue, 27 Jan 2015 05:34:40 +0000 (05:34 +0000)]
Remove copious amounts of commented out preg_replace calls
Change-Id: I9b9afea3dc6729598b240845c3d34357548cdd4a
Sam Reed [Tue, 27 Jan 2015 05:31:43 +0000 (05:31 +0000)]
Remove unused $fname temporary variables
Change-Id: Ia7a32ecdfc293e870e42cd7398fc017de0d59f11
jenkins-bot [Tue, 27 Jan 2015 00:19:39 +0000 (00:19 +0000)]
Merge "Avoid double escaped message 'nbytes' on Special:NewPages"
Kunal Mehta [Mon, 26 Jan 2015 23:02:03 +0000 (15:02 -0800)]
convertExtensionToRegistration: Document parameters
Bug: T87620
Change-Id: I0326632c24bf429cd09f4e51f6e6990536d6c76f
jenkins-bot [Mon, 26 Jan 2015 22:08:23 +0000 (22:08 +0000)]
Merge "tests: Remove resources/ from phpunit coverage"
Timo Tijhof [Mon, 26 Jan 2015 21:46:46 +0000 (13:46 -0800)]
tests: Remove resources/ from phpunit coverage
It only has one meaningful PHP file, which is a config file.
Change-Id: I7f7d06bb1970b2105173232df7679f259497ae4c
Kunal Mehta [Mon, 26 Jan 2015 21:23:30 +0000 (13:23 -0800)]
convertExtensionToRegistration: Move 'namemsg' to top as well
Change-Id: Ib2bac10980fee3bb2704219a80ec55a4b8c55607
Translation updater bot [Mon, 26 Jan 2015 21:14:18 +0000 (22:14 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I4d09b80fa0edeb2c127d2a572e0b168e82c7cba1
umherirrender [Mon, 26 Jan 2015 18:46:40 +0000 (19:46 +0100)]
Avoid double escaped message 'nbytes' on Special:NewPages
Bug: T85864
Change-Id: I69c2daaa119a9697a2a2cedf4ff498df85458401
m4tx [Fri, 2 Jan 2015 21:46:37 +0000 (22:46 +0100)]
Add missing documentation in DateFormatter.php
Change-Id: Ic5c04bdb88bc57a7c44159d7858ef791c24354c4
jenkins-bot [Mon, 26 Jan 2015 00:03:46 +0000 (00:03 +0000)]
Merge "Add links to Special:EditWatchlist in Preferences' Watchlist tab"
Translation updater bot [Sun, 25 Jan 2015 20:23:32 +0000 (21:23 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I23c7e0cfe9200b772a0845c3904b537ee6ab7545
jenkins-bot [Sun, 25 Jan 2015 07:37:01 +0000 (07:37 +0000)]
Merge "Usercreate: Move label of extraInput to right place"
jenkins-bot [Sun, 25 Jan 2015 00:15:21 +0000 (00:15 +0000)]
Merge "SpecialMovepage: Improve sanity of form-generating code"
jenkins-bot [Sat, 24 Jan 2015 22:48:47 +0000 (22:48 +0000)]
Merge "Make data provider in MediaHandlerTest static"
Translation updater bot [Sat, 24 Jan 2015 21:48:37 +0000 (22:48 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I3bfbe8a79a988dd00d0945c26097e45be2434d51
jenkins-bot [Sat, 24 Jan 2015 20:43:41 +0000 (20:43 +0000)]
Merge "resourceloader: Make 'script' argument to mw.loader.implement optional"
glaisher [Tue, 20 Jan 2015 17:00:21 +0000 (22:00 +0500)]
Add links to Special:EditWatchlist in Preferences' Watchlist tab
This adds a new "Edit watchlist" section to Watchlist tab with links
to Special:EditWatchlist, EditWatchlist/raw and EditWatchlist/clear.
Bug: T26632
Change-Id: Id31fba4f7aadaa3e427becece3837a8d00b7718f
umherirrender [Sat, 24 Jan 2015 10:03:59 +0000 (11:03 +0100)]
Special:AllMessages: Ignore case of first letter when sorting
When a message key is defined with a upper case letter the sorting in
Special:AllMessages gets confused, because the upper case letter is
sorted before the lower case letters. Doing the upper case first, than
sorting avoids this when having such a key.
Bug: T86139
Change-Id: I8e9f7ca276a2fa999d8bd41c948cc083964ec66d
umherirrender [Sat, 24 Jan 2015 09:54:41 +0000 (10:54 +0100)]
Usercreate: Move label of extraInput to right place
With change Ib585e32463765d7eb7d0be5dae54dc828ddd4ca9 the position of
the label for extraInput (from TitleBlacklist or AntiSpoof) was
misplaced outside of the label. This breaks clicking on the label to
check the box. It is also possible to have line break between check box
and label, which is unneeded there.
Bug: T87385
Follow-Up: Ib585e32463765d7eb7d0be5dae54dc828ddd4ca9
Change-Id: I8384621075c6a73cff7575af0380f90bc75e234d
jenkins-bot [Sat, 24 Jan 2015 07:07:05 +0000 (07:07 +0000)]
Merge "mediawiki.ui: Remove color and background-color 'inherit' from inputs"
jenkins-bot [Sat, 24 Jan 2015 01:41:32 +0000 (01:41 +0000)]
Merge "LSG: Fix Makefile"
Legoktm [Sat, 24 Jan 2015 01:34:13 +0000 (01:34 +0000)]
Merge "Output number of conflicts"
jenkins-bot [Sat, 24 Jan 2015 01:32:48 +0000 (01:32 +0000)]
Merge "mediawiki.cookie: Re-add documentation about non-zero default expiration"
Timo Tijhof [Sat, 24 Jan 2015 01:13:13 +0000 (17:13 -0800)]
mediawiki.cookie: Re-add documentation about non-zero default expiration
Follows-up
81319eb28d7538d12ff6b. The statement was accurate, but
somewhat confusingly phrased.
Change-Id: I718831ff23309187e30ba7e304fbd0e0ed0182fd
Sam Reed [Sat, 24 Jan 2015 00:43:26 +0000 (00:43 +0000)]
Output number of conflicts
Change-Id: I1e52db4c3bc60ab41cff3f86aa565a99ffc564ef
Sam Reed [Sat, 24 Jan 2015 00:37:53 +0000 (00:37 +0000)]
Fix stdClass typo in namespaceDupes.php
Change-Id: I129c0d0ad5770d3d9bcdbc1881757f3c13f37c35
Erik Bernhardson [Wed, 14 Jan 2015 18:50:18 +0000 (10:50 -0800)]
ApiPageSet lazy loads content models
A preceding patch, I7eff0bff, adjusts multiple Title methods to load the
content model from the database if it is not known. This patch
adjusts ApiPageSet to query for the content model with the initial data
load rather than allowing the lazy loading to pull in the content
model one at a time as requested.
`
Bug: T86612
Change-Id: I9a9272da729d9323efde76a3c0a09f55127db537
jenkins-bot [Fri, 23 Jan 2015 21:46:51 +0000 (21:46 +0000)]
Merge "Add HiDPI PNG variants for 'Powered by MediaWiki' footer icon"
Brion Vibber [Mon, 13 Oct 2014 14:15:12 +0000 (07:15 -0700)]
Add HiDPI PNG variants for 'Powered by MediaWiki' footer icon
Added 1.5x and 2x-density variants of the 'Powered by MediaWiki' footer
icon, built from this SVG version on Commons:
https://commons.wikimedia.org/wiki/File:Powered_by_MediaWiki.svg
Note the SVG version is too large to use directly right now as it
contains a huge amount of detail; the PNGs are only a few KiB.
Renderings from Commons taken and run through pngcrush.
Note that adding 'srcset' attributes to footer icons appears to work
just fine here, so can be done for others.
Bug: T65872
Change-Id: I785d21add456eeddb6ed1ee36a1906d178323e63
Translation updater bot [Fri, 23 Jan 2015 21:04:35 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I3fb43b5a3d4bdeedccff412fcba88b7f2fb73e4a
jenkins-bot [Fri, 23 Jan 2015 20:34:16 +0000 (20:34 +0000)]
Merge "Update OOjs to v1.1.4"
jenkins-bot [Fri, 23 Jan 2015 20:28:13 +0000 (20:28 +0000)]
Merge "Title: Always add title to LinkCache when necessary (in 3 methods)"
Kevin Israel [Thu, 15 Jan 2015 22:24:03 +0000 (17:24 -0500)]
Title: Always add title to LinkCache when necessary (in 3 methods)
Unless Title::GAID_FOR_UPDATE is specified, Title::getArticleID() will not
use the link cache if the Title already has the ID of the page. Account for
this by directly calling LinkCache::addLinkObj() in three other methods of
Title: getContentModel(), isRedirect(), and getLength().
Follows-up r33008 (
aed9d4b91218) and
dd5c1b7fb7ff, and reapplies part of
388b14a15de6.
Bug: T86974
Change-Id: I7eff0bffd4f632ceb8d2124af317d684dbcaf2cb
James D. Forrester [Fri, 23 Jan 2015 20:18:10 +0000 (12:18 -0800)]
Update OOjs to v1.1.4
Release notes:
https://git.wikimedia.org/blob/oojs%2Fcore.git/v1.1.4/History.md
Change-Id: Ib8736816e4e93306766c56cefee4b7d380944a99
Kunal Mehta [Sat, 17 Jan 2015 01:49:49 +0000 (17:49 -0800)]
update.php: Run checkComposerLockUpToDate.php
As suggested on wikitech-l
Change-Id: If9cde3aafb136c7194e74e6f7f0bae0b49e36465
jenkins-bot [Fri, 23 Jan 2015 19:59:03 +0000 (19:59 +0000)]
Merge "Introduce ApiFeedContributions::feedItem hook"
jenkins-bot [Fri, 23 Jan 2015 19:58:09 +0000 (19:58 +0000)]
Merge "Always use the newly-saved revision with vary-revision"
Prateek Saxena [Fri, 23 Jan 2015 19:22:36 +0000 (11:22 -0800)]
LSG: Fix Makefile
- Updated the list to actually be in alphabetical order
- It wasn't working on MacOS, removed the '<' and it works now
This is a follow up patch to I3d66bcacf99da7eecc91a421c521dc650ed9cf82
Change-Id: Ief0cd90ebaf36b3df6279f4ca39456bbd1bda6b8
Kunal Mehta [Fri, 23 Jan 2015 19:09:21 +0000 (19:09 +0000)]
Merge "SpecialTrackingCategories: Read from the extension registry"
jenkins-bot [Fri, 23 Jan 2015 18:35:09 +0000 (18:35 +0000)]
Merge "registration: Ignore attributes that start with @"
jenkins-bot [Fri, 23 Jan 2015 18:35:05 +0000 (18:35 +0000)]
Merge "registration: Sync extension.schema.json with reality"
Kunal Mehta [Wed, 17 Dec 2014 19:18:49 +0000 (11:18 -0800)]
SpecialTrackingCategories: Read from the extension registry
This demonstrates how we can transition from extensions putting
things into the global scope ($wgTrackingCategories) to instead
storing them in the extension registry. This will increase the
overall performance of the extension registry since it no
longer needs to do an array_merge with $wgTrackingCategories.
For extensions already converted to using the registry
no change is needed as the schema is still the same.
Change-Id: Ie0df4c20b123dac784a1c02eb991edc609a911b6
jenkins-bot [Fri, 23 Jan 2015 18:32:07 +0000 (18:32 +0000)]
Merge "convertExtensionToRegistration: Put some keys (name, version, etc.) on top"
Jackmcbarn [Fri, 12 Dec 2014 03:32:48 +0000 (22:32 -0500)]
Always use the newly-saved revision with vary-revision
When vary-revision is set, use a currentRevisionCallback to ensure that
the newly-saved revision will always be used by the parser. This keeps
slave lag from making vary-revision not do its job.
Bug: T78237
Change-Id: I92ec928203a67f1236c3ecf6dd5002f66a75c38c
Erik Bernhardson [Wed, 14 Jan 2015 21:52:50 +0000 (13:52 -0800)]
Introduce ApiFeedContributions::feedItem hook
ContribsPager, which is used by ApiFeedContributions, can return more
than just revision rows. This is handled in the html side within the
ContributionsLineEnding hook. ApiFeedContributions had no special
handling so here I have added a simple hook the provides the data
from ContribsPager and allows subscribers to provide the appropriate
FeedItem instance.
Bug: T85229
Change-Id: I27c77cc682ba801c40361c76b67398108ca1a592
jenkins-bot [Fri, 23 Jan 2015 02:24:45 +0000 (02:24 +0000)]
Merge "mediawiki.cookie: Remove false documentation for options.expiry as number"
Timo Tijhof [Fri, 23 Jan 2015 00:35:26 +0000 (16:35 -0800)]
mediawiki.cookie: Remove false documentation for options.expiry as number
Follows-up
7c585b5. There was never an implementation for
supporting an offset from now in seconds. The code and tests
account for no such thing.
When passed a number, it will actually end up being passed to
$.cookie, which interprets it as an offset in days (!).
Change-Id: I5d8ed8cb432ca550c62cf415077ffffd91fe2bbd
Alexia E. Smith [Tue, 16 Dec 2014 22:34:12 +0000 (16:34 -0600)]
Use: addGroup() and removeGroup() should return boolean
Have User::addGroup() and User::removeGroup() methoids return a
boolean when their respective hooks return the respective boolean.
Fix SpecialUserrights to respect this return vale and update the
add/remove arrays accordingly.
This resolves an issue where a hook that prevents a group from
being added or removed still shows that group being changed in
the Userrights log.
Change-Id: I7621cc22b04ff41cf67bd434a1f89d31bdc2cffd
Fomafix [Fri, 12 Dec 2014 13:54:59 +0000 (13:54 +0000)]
mediawiki.inspect: Use fixed numbers for sizes in bytes
Change-Id: Ieb39322ccfbbc80213ecd1d2a3b4f66bbe346b85
jenkins-bot [Thu, 22 Jan 2015 23:48:18 +0000 (23:48 +0000)]
Merge "mediawiki.inspect: Guard against Object.prototype keys as module names"
jenkins-bot [Thu, 22 Jan 2015 22:22:56 +0000 (22:22 +0000)]
Merge "Use Context on ProtectionForm for messages"
Bryan Davis [Wed, 14 Jan 2015 01:34:36 +0000 (18:34 -0700)]
Provide a backwards compatibility shim for MWLogger
MWLogger was renamed MWLoggerFactory and reduced to a static utility
class in Ie474676. Reintroduce an MWLogger that proxies the public
static methods of MWLoggerFactory to ease the transition of users who
have implemented $wgMWLoggerDefaultSpi configurations that reference
MWLogger.
As noted in the class, this is a temporary bandaid that should be ripped
off before 1.25 becomes an official release.
Change-Id: Iaccb78a510c60aab2ff20a9aa7c0869699657388
Bryan Davis [Tue, 13 Jan 2015 23:54:18 +0000 (16:54 -0700)]
Replace MWLogger with MWLoggerFactory
Time wounds all heels. During the code review for the PSR-3 logging
introduction, several people asked me why we needed a wrapper
for Psr\Log\LoggerInterface if the point was to use the standard. At the
time I was convinced that it would be better to introduce the dependency
via a wrapper class so that we could use the wrapper to patch over any
deficiencies that we might find in the PSR-3 API. After going on to work
on a project to disentangle other MediaWiki components from internal
project dependencies I have suddenly and clearly seen the error of my
ways.
We still need a logger factory as PSR-3 does not specify
a standard mechanism for creating Psr\Log\LoggerInterface instances. My
solution is to convert MWLogger into MWLoggerFactory to retain a static
factory interface for creating PSR-3 loggers but remove the MWLogger
wrapper class itself in favor of direct exposure of
Psr\Log\LoggerInterface to the MediaWiki consumer classes.
Change-Id: Ie47467657dcf341991ada00827dca5e8eff95438
Translation updater bot [Thu, 22 Jan 2015 21:54:15 +0000 (22:54 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I4929a44b21dadb98e226ffccba61059a0b39c389
jenkins-bot [Thu, 22 Jan 2015 19:34:51 +0000 (19:34 +0000)]
Merge "Always set group_concat_max_len to avoid awful truncation gotcha"
jenkins-bot [Thu, 22 Jan 2015 19:31:10 +0000 (19:31 +0000)]
Merge "Changed FileBackend exceptions to subclass Exception"
Kevin Israel [Thu, 11 Sep 2014 19:14:06 +0000 (15:14 -0400)]
Use DatabaseBase::selectRowCount() in two more places
Change-Id: Ic6e03a96c03499f7d62539f12e677b4407def673
Translation updater bot [Wed, 21 Jan 2015 21:01:02 +0000 (22:01 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I87f18cc6e49a9e0ba2910ea99cd3806f1a108046
Prtksxna [Wed, 21 Jan 2015 17:35:51 +0000 (17:35 +0000)]
Merge "mediawiki.ui: checkbox: Correct alignment of long labels"
jenkins-bot [Wed, 21 Jan 2015 01:56:19 +0000 (01:56 +0000)]
Merge "Adding PHP mustache parser (lightncandy)"
jenkins-bot [Wed, 21 Jan 2015 01:34:50 +0000 (01:34 +0000)]
Merge "Add option to output referrer policy meta tag"
YuviPanda [Tue, 20 Jan 2015 23:41:41 +0000 (15:41 -0800)]
Add option to output referrer policy meta tag
Bug: T87276
Change-Id: I9ea4797c4d292cd4565f47b88e605b4e7afdb1d1
jeroendedauw [Wed, 21 Jan 2015 00:30:14 +0000 (01:30 +0100)]
Document alternative to deprecated function
Change-Id: I89ae5f5062f8e3eb8dac38d7efcca7723d6b62b1
Timo Tijhof [Wed, 21 Jan 2015 00:03:33 +0000 (16:03 -0800)]
resourceloader: Make 'script' argument to mw.loader.implement optional
Follows-up
1f393b6.
The others were already made optional (
1f393b6), but 'script' was
still required. This caused
4ce0c0da42 to fail since it did sometimes
trim the 'script' argument as well.
Change-Id: I5cf533c2c19a064c4d8686c54838cc7743a09ba5
Krinkle [Tue, 20 Jan 2015 23:56:17 +0000 (23:56 +0000)]
Revert "resourceloader: Omit empty parameters from mw.loader.implement calls"
Works as intended, but didn't account for the first implement() parameter
being omitted client-side. Revert until that is accounted for, then re-try after
that fix is rolled out for > 1 week.
This reverts commit
4ce0c0da42acfbcc5c68527834f85436efd0ebc1.
Change-Id: I36c1619991663c0303636d1d3f037b0021ac79bf
Timo Tijhof [Tue, 9 Dec 2014 01:17:53 +0000 (01:17 +0000)]
resourceloader: Omit empty parameters from mw.loader.implement calls
Follows-up
ebeb297236.
Also:
* Add tests for ResourceLoader::makeLoaderImplementScript().
* Apply ResourceLoader::trimArray to makeLoaderImplementScript (new in
c0c221bf).
As always, the client (updated in Ie32e7d6a3c) is backward-compatible with old
(cached) load.php module responses. However, the old client is not compatible
new load.php responses after this commit.
That's generally not an issue, as we don't cache the client very long (~ 5 min).
However people with their browser open and mw.loader clients initialised can
still make new module requests (e.g. modules loaded on-demand, such as when
previewing edits, clicking buttons etc.). That can easily be several hours after
initial page load. As such, client/server bound changes should always be
back-compat and deployed a reasonable time apart to reduce chances of active
sessions making subsequent requests. Ideally we'd find some solution to this in
the long-term, but handling this at all is better than what we usually do...
For deployment: Ensure this is deployed several days after Ie32e7d6a3c09f.
Change-Id: Ic8d7efe49b5d45e3f95a2f04e3a26a014b10af16
Bartosz Dziewoński [Tue, 20 Jan 2015 22:41:18 +0000 (14:41 -0800)]
mediawiki.ui: Remove color and background-color 'inherit' from inputs
Bug: T78736
Change-Id: I01f5a8d5867cdf7ef244e1441afaa29d7adb4846
Timo Tijhof [Tue, 20 Jan 2015 22:24:33 +0000 (14:24 -0800)]
UserLogin: Don't rely on jQuery prop('tabindex') to map to tabIndex
Follows-up I9b03d519af43d.
There is a hardcoded set of exceptions in jQuery core right now
that map these common mistakes for back-compat. But this is
undocumented/unsupported legacy behaviour for a very small subset
of properties.
Change-Id: I9cfef0bc6a088e4c0a632b3673df460d26477c37
m4tx [Tue, 20 Jan 2015 21:11:33 +0000 (22:11 +0100)]
Make data provider in MediaHandlerTest static
Also, improve function names.
Follows-up Ie1cf501a6a0c8e688aca1a5577a293f526398dd3
Change-Id: I5eef5f193192041d7b0514eaa8b779c03e6647c7
Brad Jorsch [Tue, 20 Jan 2015 21:15:36 +0000 (13:15 -0800)]
API: Fix setting of wpIgnoreBlankSummary in action=edit
EditPage checks this using getBool(), not getCheck(), so empty string is
interpreted as false.
Also clean up a long-obsolete comment.
Bug: T87188
Change-Id: I18f376cefad44295874d7b1cd760ba6fc966be29
Translation updater bot [Tue, 20 Jan 2015 20:34:27 +0000 (21:34 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I845680e24225a0e9491e61efd1455675eb397b20