jenkins-bot [Tue, 10 Apr 2018 12:04:39 +0000 (12:04 +0000)]
Merge "Add varianttitles parameter to API query prop=info"
jenkins-bot [Tue, 10 Apr 2018 09:16:32 +0000 (09:16 +0000)]
Merge "build: Bump postcss-less up to 1.1.5 from 1.1.3"
jenkins-bot [Tue, 10 Apr 2018 07:59:18 +0000 (07:59 +0000)]
Merge "Revert "Convert SpecialPrefixIndex to class HTMLForm""
Fomafix [Tue, 10 Apr 2018 07:24:38 +0000 (09:24 +0200)]
Revert "Convert SpecialPrefixIndex to class HTMLForm"
This reverts commit
ebf4bb56b7b430ce9580332722176996c343e223.
ebf4bb56b7b430ce9580332722176996c343e223 changed the URL parameters
from
prefix=Foo&namespace=0&stripprefix=1
to
wpprefix=Foo&namespace=0&wpstripprefix=1
and breaks Special:PrefixIndex.
Change-Id: I99f75b5cb12913236a43b17970ea1752261ace9b
jenkins-bot [Tue, 10 Apr 2018 07:17:24 +0000 (07:17 +0000)]
Merge "Fix i18n message tog-watchlistunwatchlinks"
jenkins-bot [Tue, 10 Apr 2018 05:32:04 +0000 (05:32 +0000)]
Merge "Convert SpecialPrefixIndex to class HTMLForm"
gopavasanth [Sun, 25 Mar 2018 10:21:18 +0000 (15:51 +0530)]
Convert SpecialPrefixIndex to class HTMLForm
The XML part of namespacePrefixForm() is changed to use class HTMLForm.
Bug: T117726
Change-Id: I98cdfb69d11dee0dd1ac2d0d862235f2e53d85d9
jenkins-bot [Tue, 10 Apr 2018 02:59:07 +0000 (02:59 +0000)]
Merge "installer: Add support for PlatformSettings.php"
Kunal Mehta [Mon, 2 Apr 2018 22:27:18 +0000 (15:27 -0700)]
installer: Add support for PlatformSettings.php
PlatformSettings.php is a standardized and recommended way for
re-distributors and packagers of MediaWiki to be able to tune
DefaultSettings.php as appropriate.
If includes/PlatformSettings.php exists, the installer will
automatically include it as part of the generated LocalSettings.php.
The main advantage of this system is that if the distributor wants to
change the default settings, all users will benefit immediately. And if
people want a vanilla MediaWiki experience, they can just remove the
inclusion from their LocalSettings.php.
This RfC
(<https://www.mediawiki.org/wiki/Requests_for_comment/PlatformSettings.php>)
was approved by TechCom.
Bug: T182020
Change-Id: I34f9a4acbe86b9c5c80ac16451b317ce5f6640f9
Brad Jorsch [Thu, 5 Apr 2018 18:17:09 +0000 (14:17 -0400)]
rdbms: Issue a deprecation warning if errors are ignored
I532bc5201 added code to put the Database into an error state on error,
to prevent callers from catching and ignoring exceptions without rolling
back. But to avoid breaking everything relying on the ability to do so,
it didn't set the error state for certain types of errors.
To allow those broken callers to be cleaned up, log a deprecation
warning when we detect that someone has indeed ignored one of these
errors.
Bug: T189999
Change-Id: Ib7aca59639f30959e106fd4f1a1209e28bad2857
jenkins-bot [Tue, 10 Apr 2018 00:51:33 +0000 (00:51 +0000)]
Merge "Log DefaultPreferencesFactory usage"
jenkins-bot [Mon, 9 Apr 2018 23:50:47 +0000 (23:50 +0000)]
Merge "PostgreSQL: Set owners for sequences"
Jayprakash12345 [Sat, 24 Mar 2018 13:19:10 +0000 (18:49 +0530)]
Fix i18n message tog-watchlistunwatchlinks
Bug: T190617
Change-Id: I822d664cf3ef4b204ac7a70f9ab617985c1faaa9
Michael Holloway [Wed, 18 Oct 2017 19:42:42 +0000 (15:42 -0400)]
Add varianttitles parameter to API query prop=info
Returns the displaytitle (if present) or title->getPrefixedText for a
page, converted for each language variant configured on the wiki.
Bug: T178446
Change-Id: I35100af3824ca65c4fe5c106d4a6fbe4e5f75046
Max Semenik [Mon, 9 Apr 2018 21:35:29 +0000 (14:35 -0700)]
Log DefaultPreferencesFactory usage
Bug: T190425
Change-Id: I17e4792501811787ce90195c07915876d6c233e8
Translation updater bot [Mon, 9 Apr 2018 20:55:04 +0000 (22:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I669e466d8593af3eff87d92e824d51ecd14d7afc
jenkins-bot [Mon, 9 Apr 2018 20:43:16 +0000 (20:43 +0000)]
Merge "tests: Enable PHPUnit 4/6 compat layer in some tests that need it"
jenkins-bot [Mon, 9 Apr 2018 18:58:53 +0000 (18:58 +0000)]
Merge "build: Bump devDependencies to latest"
jenkins-bot [Mon, 9 Apr 2018 16:11:58 +0000 (16:11 +0000)]
Merge "[BREAKING CHANGE] Remove mw.widgets.CategorySelector"
Brad Jorsch [Mon, 9 Apr 2018 15:57:27 +0000 (11:57 -0400)]
PostgreSQL: Set owners for sequences
PostgreSQL allows setting an "owner" column for a sequence, so if that
column is dropped then the sequence will be dropped too. We should
certainly take advantage of that when creating duplicate tables for unit
testing (particularly when $temporary is false), and we may as well do
it for our permanent tables too.
Change-Id: I4822ac33298e3f3ef59f4372a24aa0866a6e66ae
jenkins-bot [Mon, 9 Apr 2018 15:56:49 +0000 (15:56 +0000)]
Merge "PHPVersionCheck: Remove bogus @return tags"
jenkins-bot [Mon, 9 Apr 2018 15:56:09 +0000 (15:56 +0000)]
Merge "Don't use `phpcs:ignoreFile` to selectively ignore sniffs"
Prateek Saxena [Mon, 9 Apr 2018 04:07:02 +0000 (09:37 +0530)]
[BREAKING CHANGE] Remove mw.widgets.CategorySelector
Follows-up on I7c9e0089ba6b77f4bc73e14b989630487f6f3174.
Bug: T161285
Change-Id: I1fb150914cefddd12b5ecb8f2d69f6828781cb20
Kunal Mehta [Mon, 9 Apr 2018 00:11:36 +0000 (17:11 -0700)]
PHPVersionCheck: Remove bogus @return tags
Change-Id: Ic4bcf03bc84c2208186e47015a27fb93a63887d8
Kunal Mehta [Sun, 8 Apr 2018 19:39:46 +0000 (12:39 -0700)]
Don't use `phpcs:ignoreFile` to selectively ignore sniffs
Because it doesn't work. `phpcs:ignoreFile` is intended as a performance
shortcut, and gives up on the file as soon as that token is found.
Instead, use `phpcs:disable` which does support selectively disabling
some sniffs. And since disabling is local to the file, there's no need
to re-enable it at the bottom of the file.
<https://github.com/squizlabs/PHP_CodeSniffer/issues/1903> has some
relevant discussion and clarification from upstream on this.
And make the files that are now being re-enabled pass PHPCS.
Change-Id: Ia4d8c45045f61cf9f24eb1d8631ff98d99c82d69
jenkins-bot [Sun, 8 Apr 2018 19:58:37 +0000 (19:58 +0000)]
Merge "mediawiki.jqueryMsg: Rename .parser class to .Parser"
Translation updater bot [Sun, 8 Apr 2018 19:56:31 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I14f3428671569fc7572a1aabf476c4a758cd7aa4
jenkins-bot [Sun, 8 Apr 2018 19:50:05 +0000 (19:50 +0000)]
Merge "phpunit: Alias PHPUnit_Framework_Error for PHPUnit 6 compat"
jenkins-bot [Sun, 8 Apr 2018 19:50:02 +0000 (19:50 +0000)]
Merge "RevisionTest: Fix getMockTitle()"
jenkins-bot [Sun, 8 Apr 2018 19:49:59 +0000 (19:49 +0000)]
Merge "phpunit: Create class aliases for interfaces in PHPUnit 4/6 compat layer"
Thiemo Kreuz [Sun, 8 Apr 2018 09:32:20 +0000 (11:32 +0200)]
Fix (MediaWiki)Site::normalizePageName return type
I checked all callers of these methods and almost all of them expect the
method to return false. It looks like this return type was known at some
point, but got lost. Let's add it back.
Bug: T191634
Change-Id: I43484835b8f26e07ada6a2b1452a99ccc6d9b438
Kunal Mehta [Sun, 8 Apr 2018 00:36:33 +0000 (17:36 -0700)]
tests: Enable PHPUnit 4/6 compat layer in some tests that need it
Change-Id: I27a21fa9e97414fae02acbefb28011f0275cba63
Kunal Mehta [Sun, 8 Apr 2018 02:30:43 +0000 (19:30 -0700)]
phpunit: Alias PHPUnit_Framework_Error for PHPUnit 6 compat
In PHPUnit 6, it's now PHPUnit\Framework\Error\Error.
Change-Id: Iaf0ef0a10a6a2cb7d7fc280d5ca873e77dbacb1d
Kunal Mehta [Sun, 8 Apr 2018 00:36:54 +0000 (17:36 -0700)]
RevisionTest: Fix getMockTitle()
There's no such function "getModel", it's probably supposed to be
"getContentModel". PHPUnit 6 emits warnings for trying to mock functions
that don't exist.
Change-Id: I0e5434e48958a8b75238b2ebffb5c1dc4e60c864
Kunal Mehta [Sat, 7 Apr 2018 23:06:25 +0000 (16:06 -0700)]
phpunit: Create class aliases for interfaces in PHPUnit 4/6 compat layer
Change-Id: If36bb3403f226b0399e37d2fd63b4338b1de10ae
Translation updater bot [Sat, 7 Apr 2018 19:53:30 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I09ba70916875abf16faef899deb543689fbcfb42
jenkins-bot [Sat, 7 Apr 2018 16:03:32 +0000 (16:03 +0000)]
Merge "Selenium: use default value for waitforTimeout"
jenkins-bot [Sat, 7 Apr 2018 10:45:06 +0000 (10:45 +0000)]
Merge "Change registred users to autoconfirmed users in "MediaWiki:Semiprotectedpagewarning" and "MediaWiki:Semiprotectedpagemovewarning" messages"
jenkins-bot [Sat, 7 Apr 2018 08:49:43 +0000 (08:49 +0000)]
Merge "installer: Fix setting a custom $wgMetaNamespace"
Jayprakash12345 [Fri, 9 Mar 2018 20:53:26 +0000 (20:53 +0000)]
Remove deprecated function ApiBase::getProfileTime
Bug: T189330
Change-Id: I404766b53ad33d615557faa693a513914d959a63
Jayprakash12345 [Fri, 9 Mar 2018 20:35:57 +0000 (20:35 +0000)]
Remove deprecated function ApiBase::getModuleProfileName
Bug: T189330
Change-Id: Ifa30d115b97e8109d11cb932a924d63afc6f81d9
Jayprakash12345 [Fri, 9 Mar 2018 20:41:47 +0000 (20:41 +0000)]
Remove deprecated function ApiBase::getProfileDBTime
Bug: T189330
Change-Id: I7584024dff54608b138a7fbaced216ff9133ac2c
Zoranzoki21 [Wed, 28 Mar 2018 21:06:09 +0000 (21:06 +0000)]
Change registred users to autoconfirmed users in "MediaWiki:Semiprotectedpagewarning" and "MediaWiki:Semiprotectedpagemovewarning" messages
Bug: T190882
Change-Id: Id56f5d8670b0e1363603a05e612be91a986f9698
jenkins-bot [Sat, 7 Apr 2018 00:06:16 +0000 (00:06 +0000)]
Merge "Change ResultWrapper to IResultWrapper in pagers and special pages"
jenkins-bot [Sat, 7 Apr 2018 00:03:05 +0000 (00:03 +0000)]
Merge "Use IResultWrapper in UserArray and TitleArray"
jenkins-bot [Fri, 6 Apr 2018 23:56:18 +0000 (23:56 +0000)]
Merge "Fix return type for html strings"
jenkins-bot [Fri, 6 Apr 2018 23:53:13 +0000 (23:53 +0000)]
Merge "Fix param doc of Skin::makeSpecialUrlSubpage"
jenkins-bot [Fri, 6 Apr 2018 23:07:29 +0000 (23:07 +0000)]
Merge "Remove "probably you" from password reset email information"
jenkins-bot [Fri, 6 Apr 2018 23:04:48 +0000 (23:04 +0000)]
Merge "Provide PHPUnit 4 and 6 compatibility layer"
Kunal Mehta [Fri, 6 Apr 2018 23:02:49 +0000 (16:02 -0700)]
installer: Fix setting a custom $wgMetaNamespace
`$textbox.removeProp('readonly')` has no effect and leaves the input
still as readonly, so instead use `$textbox.prop( 'readonly', false )`,
which does work.
Bug: T188415
Change-Id: I898c5605caf383cc992a948f14294193460f761b
jenkins-bot [Fri, 6 Apr 2018 23:00:51 +0000 (23:00 +0000)]
Merge "Don't rely on magic __call in MWNamespaceTest"
jenkins-bot [Fri, 6 Apr 2018 22:12:03 +0000 (22:12 +0000)]
Merge "Fix --memory-limit option to maintenance scripts"
Kunal Mehta [Fri, 2 Mar 2018 10:42:16 +0000 (02:42 -0800)]
Provide PHPUnit 4 and 6 compatibility layer
PHPUnit 6 removed some functions that were heavily used in version 4. To
be able to support both versions for a short time, we'll use a trait to
fill in the missing methods until we drop PHPUnit 4 support.
This trait is included in MediaWikiTestCase so most tests will be able
to benefit from it by default. Otherwise, anything that calls
setExpectedException() or getMock() will need to use it.
Change-Id: I707129e471e960e034e2aa994a467b9dc0239b69
Kunal Mehta [Fri, 6 Apr 2018 21:17:22 +0000 (14:17 -0700)]
Don't rely on magic __call in MWNamespaceTest
Change-Id: I32a7e7a55bc733f19d7c5ed1fbc6cfde748d4812
Translation updater bot [Fri, 6 Apr 2018 19:53:35 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If0f967280101e28c85fbd85f290cc0ad219b94f7
Umherirrender [Fri, 6 Apr 2018 18:55:34 +0000 (20:55 +0200)]
Fix param doc of Skin::makeSpecialUrlSubpage
The $urlaction is passed to Title::getLocalURL which allows also
string[]
Change-Id: I9594f37b704403ffa96f490b079c4008153e9fb8
jenkins-bot [Fri, 6 Apr 2018 18:25:38 +0000 (18:25 +0000)]
Merge "maintenance: Fix autopatrols typo in deleteAutoPatrolLogs"
Timo Tijhof [Fri, 6 Apr 2018 17:38:14 +0000 (18:38 +0100)]
maintenance: Fix autopatrols typo in deleteAutoPatrolLogs
Follows-up
e1a23c9aad.
Change-Id: I43c00b2ac884a80f779be9eead50ad3de6d13fc6
jenkins-bot [Fri, 6 Apr 2018 16:46:28 +0000 (16:46 +0000)]
Merge "rdbms: move assertOpen() call near the top of Database::query"
jenkins-bot [Fri, 6 Apr 2018 16:41:47 +0000 (16:41 +0000)]
Merge "Add missing "use" clause to DumpTestCase"
Timo Tijhof [Fri, 6 Apr 2018 15:16:43 +0000 (16:16 +0100)]
mediawiki.jqueryMsg: Rename .parser class to .Parser
This class is marked @private, but nonetheless, there is at least
one use in MobileFrontend, so keeping a back-compat alias for now.
Also rename the HtmlEmitter utility class (also private, not used
anywhere outside this file), and fix its broken documentation by
repeating the @class and @private tags on its own constructor.
It previously had all its methods indexed by JSDuck as part of the
previous class in that file (Parser), which created doc pages
with examples that don't work.
Change-Id: I02d851d9b6eac89f1a2b85b438b982bd055bedee
jenkins-bot [Fri, 6 Apr 2018 14:02:11 +0000 (14:02 +0000)]
Merge "Revert "Default installations to using RemexHtml for tidying""
Addshore [Fri, 6 Apr 2018 10:47:47 +0000 (10:47 +0000)]
Revert "Default installations to using RemexHtml for tidying"
This reverts commit
efcef34d3da74613b01a320873bc59e134748183.
This is causing failures in CI for extensions
Depends-On: If9789a61d52f60882fc2f0226757c9d93e1c6362
Change-Id: I17cf305a951b2bf1f03285b12c3e131abcffd31d
Željko Filipin [Fri, 6 Apr 2018 11:08:06 +0000 (13:08 +0200)]
Selenium: use default value for waitforTimeout
The default is 10000 (10 seconds). It was increased by mistake. 20000 is the value needed for mochaOpts timeout. There is no reason to have the double value for waitforTimeout.
Bug: T179190
Change-Id: I14f72367a36815d155cedc57757481f6294fdc51
Umherirrender [Fri, 6 Apr 2018 11:07:01 +0000 (13:07 +0200)]
Fix return type for html strings
Change-Id: Ifc1ae7740ad1b130186b4b970d3d84651b016177
jenkins-bot [Fri, 6 Apr 2018 04:50:18 +0000 (04:50 +0000)]
Merge "Default installations to using RemexHtml for tidying"
jenkins-bot [Fri, 6 Apr 2018 00:35:43 +0000 (00:35 +0000)]
Merge "tests: Reset Postgres sequences when cloning and truncating"
jenkins-bot [Fri, 6 Apr 2018 00:05:57 +0000 (00:05 +0000)]
Merge "rdbms: Allow PostgreSQL schema-check functions to find temporary tables"
Brad Jorsch [Sun, 18 Mar 2018 17:23:58 +0000 (13:23 -0400)]
tests: Reset Postgres sequences when cloning and truncating
This improves the repeatability of the unit tests by making the ID
values generated depend less on what previous tests might have done.
It also prevents tests from using up sequence numbers for the live DB's
tables.
Change-Id: Iaa8ae1e5cef4b9099bd1b4b8fc806f5af372a7ff
jenkins-bot [Thu, 5 Apr 2018 22:55:30 +0000 (22:55 +0000)]
Merge "Add DeleteUnknownPreferences hook"
Brad Jorsch [Sun, 18 Mar 2018 03:13:43 +0000 (23:13 -0400)]
rdbms: Allow PostgreSQL schema-check functions to find temporary tables
PostgreSQL puts temporary tables and such in a hidden, per-connection
"schema" that's checked for unqualified table accesses before the normal
search_path. We should check that in all the schema-checking functions.
Change-Id: I1194ac31f31133b177f624138afee19d00e454b9
Brad Jorsch [Thu, 5 Apr 2018 16:13:08 +0000 (12:13 -0400)]
rdbms: Add a deprecationLogger callback
Much like the existing errorLogger, but for logging deprecation
warnings.
The default in the RDBMS layer is to call trigger_error() with
E_USER_DEPRECATED. The default in MediaWiki (via MWLBFactory) is to log
to the 'deprecated' log group, much like wfDeprecated() does, although
unfortunately we can't effectively use that directly since we have no
idea of a proper $callerOffset to pass.
Change-Id: Id13625e249516e84d72b6310953bb338a90976da
Umherirrender [Thu, 5 Apr 2018 22:06:35 +0000 (00:06 +0200)]
Use IResultWrapper in UserArray and TitleArray
The result of IDatabase::select is directly passed around and that type
is IResultWrapper
Change-Id: I7668fcac960bb83e834d849aaef5fe90e5bc115b
jenkins-bot [Thu, 5 Apr 2018 21:33:26 +0000 (21:33 +0000)]
Merge "rdbms: Remove support for PostgreSQL < 9.2, and improve INSERT IGNORE for 9.5"
jenkins-bot [Thu, 5 Apr 2018 20:59:10 +0000 (20:59 +0000)]
Merge "rdbms: Roll back empty implicit transaction on error"
Brad Jorsch [Sun, 18 Mar 2018 00:29:31 +0000 (20:29 -0400)]
rdbms: Remove support for PostgreSQL < 9.2, and improve INSERT IGNORE for 9.5
MediaWiki doesn't support PostgreSQL < 9.2, so drop the support for
older versions.
At the same time, since we're messing with the DatabasePostgres::insert()
code anyway, let's start using ON CONFLICT DO NOTHING for PG >= 9.5.
And since we're doing that, let's do the same for
DatabasePostgres::nativeInsertSelect().
Change-Id: I7bf13c3272917ebafeaff11eb116714a099afdf3
Aaron Schulz [Thu, 5 Apr 2018 20:49:55 +0000 (13:49 -0700)]
rdbms: move assertOpen() call near the top of Database::query
This should be done before bothering with begin() calls or setting
the value of fields like "trxDoneWrites" or "lastWriteTime".
Change-Id: Ieace2870f5496fcf230c5c8381baca4b8038db1d
Translation updater bot [Thu, 5 Apr 2018 20:02:00 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id32906c9e0becbdec14faf77335f79ab4cd06b84
Brad Jorsch [Thu, 5 Apr 2018 18:16:03 +0000 (14:16 -0400)]
rdbms: Roll back empty implicit transaction on error
If we're not going to set trxStatus to an error state in this case, we
need to issue a rollback to be sure the database (i.e. PostgreSQL) isn't
still in an error state too.
Bug: T189999
Change-Id: Id6e203b216fff937b6a97d779b36c278e3366409
jenkins-bot [Thu, 5 Apr 2018 18:10:06 +0000 (18:10 +0000)]
Merge "Fix SamplingStatsdClient for PHP 7.1+"
James D. Forrester [Wed, 4 Apr 2018 17:18:56 +0000 (10:18 -0700)]
Default installations to using RemexHtml for tidying
This combines two changes – defaulting tidying to on, previously off, and
defaulting the tidying library to RemexHtml, previously the tidy binary.
Config options are going to be a bit of a mess until we drop support for
the old tidy binary config route.
Bug: T185753
Depends-On: I0a8973f508fbf65160177b003260831639828eea
Change-Id: I6879a77a78d780c7c056d807dde20682c6097d1a
jenkins-bot [Thu, 5 Apr 2018 15:51:49 +0000 (15:51 +0000)]
Merge "mw.special.apisandbox: Use a real button to insert values in multi fields"
jenkins-bot [Thu, 5 Apr 2018 15:29:20 +0000 (15:29 +0000)]
Merge "rdbms: make Database query error handling more strict"
Bartosz Dziewoński [Thu, 9 Mar 2017 16:06:08 +0000 (17:06 +0100)]
mw.special.apisandbox: Use a real button to insert values in multi fields
Stuffing an indicator inside a normal widget is weird.
Also, always add it, even when we also handle Enter presses on the input.
Change-Id: I7191b4f31bfe4b42a524c786994150f318fd8cd9
jenkins-bot [Thu, 5 Apr 2018 14:06:28 +0000 (14:06 +0000)]
Merge "Swap isset by null check in ApiSetNotificationTimestamp/ApiPurge"
jenkins-bot [Thu, 5 Apr 2018 13:45:48 +0000 (13:45 +0000)]
Merge "Change default of $wgLogAutopatrol from true to false"
jenkins-bot [Thu, 5 Apr 2018 12:09:43 +0000 (12:09 +0000)]
Merge "SizeFilterWidget: Reduce width"
kaldari [Tue, 9 Jan 2018 08:15:14 +0000 (00:15 -0800)]
Change default of $wgLogAutopatrol from true to false
"$wgLogAutopatrol = true" basically just spams the logging table
and isn't useful in most cases (or ever?)
Bug: T184485
Change-Id: I418cc2fcc7017e5d2cbc0c6159b4c459b9c77ac7
Umherirrender [Thu, 5 Apr 2018 10:39:24 +0000 (12:39 +0200)]
Swap isset by null check in ApiSetNotificationTimestamp/ApiPurge
Change-Id: I1ebcbacf476a716d23b183dcbf379555ee1519dd
Gergő Tisza [Thu, 5 Apr 2018 09:48:07 +0000 (11:48 +0200)]
Fix SamplingStatsdClient for PHP 7.1+
Bug: T182380
Change-Id: I74a8aef1230c56d0c6a7856f8397e657fc6d1c40
addshore [Fri, 23 Mar 2018 11:33:10 +0000 (11:33 +0000)]
Api requests can throw a ApiUsageException, and that should be expected
Change-Id: I4aa6e7511747c0d811e2e617b88e681a6eda875d
Aaron Schulz [Thu, 5 Apr 2018 04:46:55 +0000 (21:46 -0700)]
Add missing "use" clause to DumpTestCase
Change-Id: I0420e95003509634a87b98df279242cdc05843b2
Aaron Schulz [Fri, 23 Mar 2018 09:57:21 +0000 (02:57 -0700)]
rdbms: make Database query error handling more strict
Handle all errors in query() that might have caused rollback by
putting the Database handle into an error state that can only be
resolved by cancelAtomic() or rollback(). Other queries will be
rejected until then.
This results in more immediate exceptions in some cases where
atomic section mismatch errors would have been thrown, such as a
an error bubbling up from a child atomic section. Most cases were
a try/catch block assumes that only the statement was rolled back
now result in an error and rollback.
Callers using try/catch to handle key conflicts should instead use
SELECT FOR UPDATE to find conflicts beforehand, or use IGNORE, or
the upsert()/replace() methods. The try/catch pattern is unsafe and
no longer allowed, except for some common errors known to just
rollback the statement. Even then, such statements can come from
child atomic sections, so committing would be unsafe. Luckily, in
such cases, there will be a mismatch detected on endAtomic() or a
dangling section detected in close(), resulting in rollback.
Remove caching from DatabaseMyslBase::getServerVariableSettings
in case some SET query changes the values.
Bug: T189999
Change-Id: I532bc5201681a915d0c8aa7a3b1c143b040b142e
James D. Forrester [Thu, 5 Apr 2018 00:43:15 +0000 (17:43 -0700)]
build: Bump postcss-less up to 1.1.5 from 1.1.3
Problem over, we think.
Bug: T190269
Change-Id: I0a94c99fb75613b03f15954512744dec63fd779e
James D. Forrester [Thu, 5 Apr 2018 00:37:11 +0000 (17:37 -0700)]
build: Bump devDependencies to latest
grunt-stylelint 0.9.0 → 0.10.0
stylelint 8.2.0 → 9.2.0
stylelint-config-wikimedia 0.4.2 → 0.4.3
Change-Id: I612cf96d99e2af67b3f7ef3284657f66f3e18d2e
jenkins-bot [Wed, 4 Apr 2018 23:10:03 +0000 (23:10 +0000)]
Merge "User: Remove deprecated, unused auth functions"
Florian Schmidt [Fri, 30 Mar 2018 21:17:48 +0000 (23:17 +0200)]
User: Remove deprecated, unused auth functions
According to a github search they're not used anywhere anymore and
already deprecated since 1.27:
::getEditTokenTimestamp
::getPasswordFactory
::passwordChangeInputAttribs
Change-Id: I904e46e7343baee28dc960f8fd5437ae9d17fc4b
jenkins-bot [Wed, 4 Apr 2018 22:53:59 +0000 (22:53 +0000)]
Merge "CSSMin: Don't match empty string as remappable url"
jenkins-bot [Wed, 4 Apr 2018 22:53:15 +0000 (22:53 +0000)]
Merge "Convert HTTP links to MediaWiki.org to HTTPS"
jenkins-bot [Wed, 4 Apr 2018 21:36:36 +0000 (21:36 +0000)]
Merge "rdbms: rename and clarify getTransactionLagStatus method regarding begin()"