From ca751872aac2be673d88fe9067472808c6500bb5 Mon Sep 17 00:00:00 2001 From: Ed Sanders Date: Mon, 28 Sep 2015 16:28:09 +0100 Subject: [PATCH] mediawiki.widgets: Add temporary workaround for upstream oojs-ui bug 'choose' sometimes emits with null. Fixed upstream in I03f0b6d88f. Change-Id: I4f5ab119555f9e3c439e3d91054b8b99d0dd89a5 --- .../src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js b/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js index 0e2546f8b7..c37c723b4d 100644 --- a/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js +++ b/resources/src/mediawiki.widgets/mw.widgets.TitleSearchWidget.js @@ -63,7 +63,11 @@ * @param {OO.ui.OptionWidget} item Chosen item */ mw.widgets.TitleSearchWidget.prototype.onTitleSearchResultsChoose = function ( item ) { - this.getQuery().setValue( item.getData() ); + // TOOD: Pressing enter can incorrectly trigger 'choose' with null. + // Remove this check when oojs-ui 0.12.10 lands. + if ( item ) { + this.getQuery().setValue( item.getData() ); + } }; /** -- 2.20.1