From bff8e18ffd7968a85090114d4845b89d7c5227e6 Mon Sep 17 00:00:00 2001 From: Brion Vibber Date: Sun, 26 Oct 2008 01:55:17 +0000 Subject: [PATCH] Update to r42587 -- use insert() DB wrapper instead of constructing raw SQL with unescaped strings (even if we assume they'll be safe... probably) --- maintenance/updaters.inc | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/maintenance/updaters.inc b/maintenance/updaters.inc index afa59be676..a49c875797 100644 --- a/maintenance/updaters.inc +++ b/maintenance/updaters.inc @@ -1757,10 +1757,14 @@ function do_postgres_updates() { dbsource(archive('patch-tsearch2funcs.sql')); ## Put a new row in the mediawiki_version table - $wgDatabase->query("INSERT INTO mediawiki_version" - ."(type,ctype,mw_version,pg_version,sql_version,sql_date) " - ."VALUES ('Update','U','$wgVersion','$version','" - .'$LastChangedRevision$'."','" - .'$LastChangedDate$'."')"); + $wgDatabase->insert( 'mediawiki_version', + array( + 'type' => 'Update', + 'ctype' => 'U', + 'mw_version' => $wgVersion, + 'pg_version' => $version, + 'sql_version' => '$LastChangedRevision$', + 'sql_date' => '$LastChangedDate$', + ) ); return; } -- 2.20.1