From bceb7558ad6adcc931b9d2b61585357626e6d3b4 Mon Sep 17 00:00:00 2001
From: Brion Vibber <brion@users.mediawiki.org>
Date: Wed, 7 Jun 2006 09:18:34 +0000
Subject: [PATCH] * (bug 6230) Regression fix: <nowiki> in [URL link text]

---
 RELEASE-NOTES               |  1 +
 includes/Parser.php         |  7 ++++---
 maintenance/parserTests.txt | 21 +++++++++++++++++++++
 3 files changed, 26 insertions(+), 3 deletions(-)

diff --git a/RELEASE-NOTES b/RELEASE-NOTES
index 9ad6b40cd4..6d529601cc 100644
--- a/RELEASE-NOTES
+++ b/RELEASE-NOTES
@@ -456,6 +456,7 @@ it from source control: http://www.mediawiki.org/wiki/Download_from_SVN
   doesn't forbid access.
 * Regression fix: suppress warning about session failure when clicking to
   edit with 'preview on first edit' enabled.
+* (bug 6230) Regression fix: <nowiki> in [URL link text]
 
 
 == Compatibility ==
diff --git a/includes/Parser.php b/includes/Parser.php
index d1f48cf082..fdaeebd901 100644
--- a/includes/Parser.php
+++ b/includes/Parser.php
@@ -47,11 +47,12 @@ define( 'STRIP_COMMENTS', 'HTMLCommentStrip' );
 define( 'HTTP_PROTOCOLS', 'http:\/\/|https:\/\/' );
 # Everything except bracket, space, or control characters
 define( 'EXT_LINK_URL_CLASS', '[^][<>"\\x00-\\x20\\x7F]' );
-# Including space
-define( 'EXT_LINK_TEXT_CLASS', '[^\]\\x00-\\x1F\\x7F]' );
+# Including space, but excluding newlines
+define( 'EXT_LINK_TEXT_CLASS', '[^\]\\x0a\\x0d]' );
 define( 'EXT_IMAGE_FNAME_CLASS', '[A-Za-z0-9_.,~%\\-+&;#*?!=()@\\x80-\\xFF]' );
 define( 'EXT_IMAGE_EXTENSIONS', 'gif|png|jpg|jpeg' );
-define( 'EXT_LINK_BRACKETED',  '/\[(\b(' . wfUrlProtocols() . ')'.EXT_LINK_URL_CLASS.'+) *('.EXT_LINK_TEXT_CLASS.'*?)\]/S' );
+define( 'EXT_LINK_BRACKETED',  '/\[(\b(' . wfUrlProtocols() . ')'.
+	EXT_LINK_URL_CLASS.'+) *('.EXT_LINK_TEXT_CLASS.'*?)\]/S' );
 define( 'EXT_IMAGE_REGEX',
 	'/^('.HTTP_PROTOCOLS.')'.  # Protocol
 	'('.EXT_LINK_URL_CLASS.'+)\\/'.  # Hostname and path
diff --git a/maintenance/parserTests.txt b/maintenance/parserTests.txt
index ceaf0f5ee3..904156147c 100644
--- a/maintenance/parserTests.txt
+++ b/maintenance/parserTests.txt
@@ -157,6 +157,7 @@ nowiki 3
 
 !! end
 
+
 ###
 ### Comments
 ###
@@ -543,6 +544,26 @@ External links: open square bracket forbidden in URL (named) (bug 4377)
 </p>
 !!end
 
+!! test
+External links: nowiki in URL link text (bug 6230)
+!!input
+[http://example.com/ <nowiki>''example site''</nowiki>]
+!! result
+<p><a href="http://example.com/" class='external text' title="http://example.com/" rel="nofollow">''example site''</a>
+</p>
+!! end
+
+!! test
+External links: newline forbidden in text (bug 6230 regression check)
+!! input
+[http://example.com/ first
+second]
+!! result
+<p>[<a href="http://example.com/" class='external free' title="http://example.com/" rel="nofollow">http://example.com/</a> first
+second]
+</p>
+!!end
+
 !! test
 External image
 !! input
-- 
2.20.1