From 284a94804133d18e9c23d837fc8362eade7f08ea Mon Sep 17 00:00:00 2001 From: Mukunda Modell Date: Thu, 27 Aug 2015 14:28:51 -0500 Subject: [PATCH] Don't free the parser in the catch() block of parse() This is the solution proposed by @bd808 to address T89532, also, it's completely untested. Bug: T89532 Change-Id: I9b5b47eb9d64a3d80f9c49618a362415d15071b4 (cherry picked from commit d34ed1acbe2ea58e5de59d3a18e278be0e384f8f) --- includes/media/XMP.php | 4 ---- 1 file changed, 4 deletions(-) diff --git a/includes/media/XMP.php b/includes/media/XMP.php index 12550a59ef..5ded976e4f 100644 --- a/includes/media/XMP.php +++ b/includes/media/XMP.php @@ -380,10 +380,6 @@ class XMPReader implements LoggerAwareInterface { } catch ( Exception $e ) { $this->logger->info( 'XMP parse error: ' . $e ); $this->results = array(); - - if ( $allOfIt ) { - $this->destroyXMLParser(); - } return false; } if ( $allOfIt ) { -- 2.20.1