Alexandre Emsenhuber [Fri, 9 Mar 2012 20:37:44 +0000 (20:37 +0000)]
Let's be consistent and use the same check to show an the deleted version and cascade the parameter
Alexandre Emsenhuber [Fri, 9 Mar 2012 20:26:08 +0000 (20:26 +0000)]
No need to create a new Revision object if we already have one available
Aaron Schulz [Fri, 9 Mar 2012 19:36:19 +0000 (19:36 +0000)]
Made FileOp::allowStaleReads take a boolean argument (more versatile) and killed a few lines of code.
Sam Reed [Fri, 9 Mar 2012 19:05:29 +0000 (19:05 +0000)]
Fix syntax error and indenting from r113487
Sam Reed [Fri, 9 Mar 2012 19:01:30 +0000 (19:01 +0000)]
PHP Fatal error: Call to undefined method DatabasePostgres::getCoreSchea() in /var/lib/jenkins/jobs/MediaWiki-postgres-phpunit/workspace/mw-core/includes/installer/PostgresUpdater.php on line 309
Ping r113487
Sam Reed [Fri, 9 Mar 2012 18:55:12 +0000 (18:55 +0000)]
Fix up some documentation weirdness from r113487
Sam Reed [Fri, 9 Mar 2012 18:52:31 +0000 (18:52 +0000)]
Fix broken unit tests post r113487
[exec] PHP Fatal error: Call to a member function getCoreSchema() on a non-object in /var/lib/jenkins/jobs/MediaWiki-postgres-phpunit/workspace/mw-core/includes/db/DatabasePostgres.php on line 216
Max Semenik [Fri, 9 Mar 2012 18:32:03 +0000 (18:32 +0000)]
(bug 23795) Add parser itself to ParserMakeImageParams hook.
Marcin Cieślak [Fri, 9 Mar 2012 17:24:57 +0000 (17:24 +0000)]
Handle PostgreSQL transaction errors and improve schema detection
* Introduce $wgDebugDBTransactions facility to help
figure out what's going on with transactions.
Currently PostgreSQL only.
PostgresTransactionState can be easily be made more general
to trace all sorts of state machinery.
* Improve r113408: we don't need to full reconnect on error,
rollback is enough.
Rolling back breaks search_path, as PostgreSQL
can manage sessions settings under transaction therefore
we need to improve schema sniffing introduced in r82674
* Introduce few schema handling functions. This could
probably be generalized for other databases like DB2 and Oracle.
* Fix bug 15816 - Add a switch for SETting the search_path
We try to avoid touching search_path at all unless
really necessary. Even in this case we append MediaWiki
core schema to the front of the list.
* No longer add $wgDBmwschema to PostgreSQL role search_path
in the installer. This is no longer necessary as
setting schema on connect should ReallyWorkNow(tm).
* Get rid as much as possible of $wgDBmwschema and
bring us one step closer to fix bug 16794 (wgSharedDB
support).
All references to core MediaWiki schema in PostgreSQL
specific code should now use Database::getCoreSchema()
unless we know what we are doing.
Followup-To: r113408 r82674
Aaron Schulz [Fri, 9 Mar 2012 16:01:11 +0000 (16:01 +0000)]
r113416: added missing parameter to message
Alexandre Emsenhuber [Fri, 9 Mar 2012 14:50:39 +0000 (14:50 +0000)]
Use WikiPage::getRevision() instead of another Revision object if the oldid parameter corresponds to the page's latest revision
Krinkle [Fri, 9 Mar 2012 05:40:36 +0000 (05:40 +0000)]
release-notes (rr113415)
Aaron Schulz [Fri, 9 Mar 2012 01:18:32 +0000 (01:18 +0000)]
Disable file locking for thumbnail purging just as it already is with creation/updates (for performance).
Aaron Schulz [Thu, 8 Mar 2012 22:51:43 +0000 (22:51 +0000)]
Added backend-fail-maxsize failure message and use it instead of the vague "could not store" type message.
Max Semenik [Thu, 8 Mar 2012 22:51:39 +0000 (22:51 +0000)]
(bug 25095) Special:Categories doesn't show first relevant item when "from" is filled
Aaron Schulz [Thu, 8 Mar 2012 22:31:04 +0000 (22:31 +0000)]
[FileBackend] Made doOperations() Status handling align with documentation as well as what FileRepo is essentially expecting when using the 'force' option (it assumes fatals are for total batch failures, not just partial ones). The relevant documentation was also improved.
Marcin Cieślak [Thu, 8 Mar 2012 21:44:03 +0000 (21:44 +0000)]
PostgreSQL: Improve SQL error handling
After a query error, PostgreSQL transaction is aborted
until it's terminated or the query is closed.
All further queries result in:
ERROR: current transaction is aborted, commands ignored
until end of transaction block
Those subsequent errors are ignored by double fault handling in
DatabaseBase::reportQueryError but they cause all localization
of error messages to fail (unable to issue queries to message
tables) and errors lke
This resulted in a broken MediaWiki screen with
<databaseerror>
<dberrortext>
instead of localized error message.
We need to fully reset database connection because after
pg_connection_reset() various session parameters need to
be set again (like "search_path"), otherwise tables will not be
found.
ERROR: relation "msg_resource" does not exist
ERROR: relation "l10n_cache" does not exist
Alexandre Emsenhuber [Thu, 8 Mar 2012 21:39:13 +0000 (21:39 +0000)]
* (bug 35019) Fix for rr99942: edit summaries are no longer transformed in notification e-mails
Robin Pepermans [Thu, 8 Mar 2012 20:56:26 +0000 (20:56 +0000)]
Update core usage of getLanguageName[s].
Raimond Spekking [Thu, 8 Mar 2012 20:35:25 +0000 (20:35 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Thu, 8 Mar 2012 20:06:49 +0000 (20:06 +0000)]
* (bug 35014) Fix for r100529: including a special page no longer sets the page's title to the included page
Robin Pepermans [Thu, 8 Mar 2012 19:30:30 +0000 (19:30 +0000)]
Follow-up r112479
* Add @since, fix indentation.
* Change default from 'all' to 'mw' as it's the most used (so default fetchLanguageNames() is equivalent to default getLanguageNames()).
* Add the include parameter also to fetchLanguageName() as it's needed in Parser: interlanguage links should only take into account mediawiki names. (Doesn't make a difference with how the functions are now, but could have been later.)
Krinkle [Thu, 8 Mar 2012 03:19:51 +0000 (03:19 +0000)]
[ObjectCache.php] typo from r112985
Tim Starling [Thu, 8 Mar 2012 00:49:50 +0000 (00:49 +0000)]
(bug 34929) Show the correct diff when a section edit is rejected by the spam filter. Use EditPage::showDiff() so that the same kind of diff is shown as when you click the "show changes" button. I considered changing the source text to be the original section text, but if you do that, the line numbers are wrong and section=new doesn't show you the headline which may have matched the spam filter.
Ryan Kaldari [Thu, 8 Mar 2012 00:34:42 +0000 (00:34 +0000)]
better error message and comment
Ryan Kaldari [Wed, 7 Mar 2012 23:51:05 +0000 (23:51 +0000)]
typo fix
Ryan Kaldari [Wed, 7 Mar 2012 23:48:45 +0000 (23:48 +0000)]
adding note for new API functionality
Tim Starling [Wed, 7 Mar 2012 23:00:42 +0000 (23:00 +0000)]
Fix for r113312: explain the bug without the use of commented-out code
Aaron Schulz [Wed, 7 Mar 2012 22:46:47 +0000 (22:46 +0000)]
[FileRepo]
* Made upload() explicitly check $status->successCount rather than isOk() as FileRepo::publish() gives fatal statuses where it used to only give warnings. This way, failed uploads still displace the current image DB row to oldimage rather than do nothing and have the same image row point to a new file (which can cause mismatched metadata).
* Disabled exception about invalid oi_archive_name. This makes things more broken in that when people get this an error on upload (which happens when the FS has no current file but the DB does), the new file is added as the current version in the FS but the DB is unchanged. Thus, the metadata can be mismatched.
Benny Situ [Wed, 7 Mar 2012 21:45:38 +0000 (21:45 +0000)]
followup to -r112918 - display old title in SpecialNews page when namespace or title text has been changed
Raimond Spekking [Wed, 7 Mar 2012 21:06:01 +0000 (21:06 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Krinkle [Wed, 7 Mar 2012 20:45:31 +0000 (20:45 +0000)]
Follow-up r113277: release-notes
Roan Kattouw [Wed, 7 Mar 2012 19:33:37 +0000 (19:33 +0000)]
(bug 35036) Wikipage-based ResourceLoader modules were not automatically purged as they should be when one of their messages changed. In practice, this only affected WikiLove.
Also adding a documentation comment in ResourceLoaderModule to clarify that it is the subclass's responsibility to make sure message blob timestamps are taken into account
Krinkle [Wed, 7 Mar 2012 19:14:20 +0000 (19:14 +0000)]
[Html::namespaceSelector] Remove default id/name attributes
* Remove default id/name attributes
* Remove now redundant tests introduced in r110274
* Add tests to make sure label has no 'for' attribute when label isn't null but name/id are unset
* Update tests to not include id="" and name="" when calling with no arguments
* Updating calls to add name/id if needed, and while at it remove useless 'null' params
* Context:
-- Introduced in r109990, r111376, r111315
-- No callers exist that assume these defaults. Forcing an ID that should be unique is annoying and redundant. The name used in the query when submitting a form should be mentioned in the same file where it is used from the submission, never assume what name="" is from unrelated code
-- Same for ID, this is often used in CSS or JavaScript, shouldn't be assumed. (It should be simple to but two simple namespace selectors on a page without getting DOM conflicts)
Jeroen De Dauw [Wed, 7 Mar 2012 19:07:40 +0000 (19:07 +0000)]
Follow up to r113142; fix incorrect conversion to array (value can be array already)
Krinkle [Wed, 7 Mar 2012 19:00:38 +0000 (19:00 +0000)]
Follows-up r113214: span ternary operator over multiple lines for readability
Niklas Laxström [Wed, 7 Mar 2012 10:13:58 +0000 (10:13 +0000)]
My proposed fix to bug 34987: gender not working in many special pages.
I haven't checked if there are other places whereh context is set to Message class, but if there are they might need a fix too.
Antoine Musso [Wed, 7 Mar 2012 10:07:32 +0000 (10:07 +0000)]
warn that dumpBackup does not actually backup the wiki!
The user table is not dumped by that tool. The warning notice makes it clear
and will avoid someone having some trouble recovering his precious private
data.
Antoine Musso [Wed, 7 Mar 2012 09:56:24 +0000 (09:56 +0000)]
(bug 34302) Add CSS classes to email fields in user preferences
Patch by Nischay Nahata whom I have mentored earlier this week.
Krinkle [Wed, 7 Mar 2012 02:58:11 +0000 (02:58 +0000)]
[mw.util.tooltipAccessKeyPrefix] alt-shift for Chrome on Windows
* Fixes:
-- (bug 29753) mw.util.tooltipAccessKeyPrefix should be alt-shift for Chrome on Windows
Krinkle [Wed, 7 Mar 2012 02:43:46 +0000 (02:43 +0000)]
[jquery.textSelection.test] disable caretTest per bug 34820
* Right now it's causing testswarm clients to have to this test 3 times, and if until bug 34820 is fixed there is no point in clogging up testswarm with it, making all IE columns uselessly red and making it harder to detect an actual regression
Roan Kattouw [Wed, 7 Mar 2012 02:09:22 +0000 (02:09 +0000)]
It seems that parseMsg() sometimes receives strings, probably from bad dieUsageMsg() callers or badly formatter error arrays. I don't want to have to track this down, so I'm making it fail gracefully and just cast any strings to arrays
Aaron Schulz [Wed, 7 Mar 2012 02:00:55 +0000 (02:00 +0000)]
r109469: ported r113208 by bumping max file size from 1GB to 4GiB.
Sam Reed [Wed, 7 Mar 2012 01:09:35 +0000 (01:09 +0000)]
Fix mixed/messed up whitespace
Krinkle [Tue, 6 Mar 2012 23:03:42 +0000 (23:03 +0000)]
MTT: r113196
Aaron Schulz [Tue, 6 Mar 2012 22:59:59 +0000 (22:59 +0000)]
Fixed FileOp::attemptBatch() behavior when unexpected failures occur with the 'force' option. It can't continue on since the ops assumed that $predicates was correct, which it won't be. It now simply halts operations.
Raimond Spekking [Tue, 6 Mar 2012 21:18:30 +0000 (21:18 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Tue, 6 Mar 2012 20:55:19 +0000 (20:55 +0000)]
Use local context to get messages
Alexandre Emsenhuber [Tue, 6 Mar 2012 20:52:42 +0000 (20:52 +0000)]
No need to do a database query when passing an IP address to User::idFromName()
Aaron Schulz [Tue, 6 Mar 2012 19:38:17 +0000 (19:38 +0000)]
r110955: also truncate rc_comment for log entries. This adds the code in save() to proof RecentChange a bit against such problems.
Sam Reed [Tue, 6 Mar 2012 19:21:07 +0000 (19:21 +0000)]
Minor followup to r111795, make doSha1LegacyUpdates return it's count value so it can be added to the count of archive rows
Don't return true in doSha1Updates(), return 0 if table is empty
Jeroen De Dauw [Tue, 6 Mar 2012 15:54:23 +0000 (15:54 +0000)]
get rid of deperacted method usage
Jeroen De Dauw [Tue, 6 Mar 2012 15:36:08 +0000 (15:36 +0000)]
follow up to r113113, get rid of code ducpliation and fix docs to reflect actual behaviour
Tim Starling [Tue, 6 Mar 2012 11:11:01 +0000 (11:11 +0000)]
Partial revert of r97849: the wgUserVariant variable is useful and used even on special pages, removing it breaks b/c
Antoine Musso [Tue, 6 Mar 2012 10:19:27 +0000 (10:19 +0000)]
revert r113117 per CR
Antoine Musso [Tue, 6 Mar 2012 10:17:46 +0000 (10:17 +0000)]
rv table sorting of IP and fraction
I am reverting, for now, two recent additions made to the table sorting:
- r111884 fractions
- r111829 IP addresses
Both need to be polished a bit more before landing in trunk. Please reapply
in a branch then once reviewed we can merge it in trunk, that will avoid
us a lot of "spam".
Niklas Laxström [Tue, 6 Mar 2012 07:20:14 +0000 (07:20 +0000)]
No point doing it the hard way, ping r112591
Jeroen De Dauw [Tue, 6 Mar 2012 01:16:56 +0000 (01:16 +0000)]
follow up to r113115, rem not needed args
Jeroen De Dauw [Tue, 6 Mar 2012 00:53:48 +0000 (00:53 +0000)]
get rid of deprecated method usage making people on education program test wiki go mad
Jeroen De Dauw [Tue, 6 Mar 2012 00:32:48 +0000 (00:32 +0000)]
fix support for passing args to help-message(s), which was documented to be there but actually missing
Sam Reed [Tue, 6 Mar 2012 00:26:48 +0000 (00:26 +0000)]
Can someone standardi[sz]e SQL already!?
Might aswell change mysql to same format as the sqlite one is becoming
Ping r113110
Sam Reed [Tue, 6 Mar 2012 00:10:36 +0000 (00:10 +0000)]
And fix the . from r113110
Sam Reed [Tue, 6 Mar 2012 00:09:18 +0000 (00:09 +0000)]
Followup r113109, forward port the rest of r25267 for Bug 10788 - Filter page histories by user, or contributions by title
Sam Reed [Tue, 6 Mar 2012 00:05:48 +0000 (00:05 +0000)]
Pull patch-revision-user-page-index.sql from r25267
Trevor Parscal [Mon, 5 Mar 2012 23:39:25 +0000 (23:39 +0000)]
Added unit test for changes in r113105 related to bug #34924 (adding Rekonq to known browsers list)
Trevor Parscal [Mon, 5 Mar 2012 23:14:58 +0000 (23:14 +0000)]
Added "Rekonq" to list of known browsers, which prevents it from being considered to be Safari. Whoever chose to make the user agent of this browser look like Safari 2.0 is an idiot. This should sort out bug #34924
Sam Reed [Mon, 5 Mar 2012 23:05:52 +0000 (23:05 +0000)]
Normalise method returns, and returned value usage
Documentation fixes
Thomas Gries [Mon, 5 Mar 2012 23:04:24 +0000 (23:04 +0000)]
updating the outdated Amazon book link, which is invalid since many years or so
Sam Reed [Mon, 5 Mar 2012 22:43:10 +0000 (22:43 +0000)]
Special pages aren't a contextsource. Ping r100114, pass $this->getContext()
Trevor Parscal [Mon, 5 Mar 2012 22:40:29 +0000 (22:40 +0000)]
Lightened the background color of diff context lines as per Erwin Dokter's suggestion. Now using the standard Vector gray background color (#f3f3f3) which is as light as you can go without most monitors rendering it as white.
Alexandre Emsenhuber [Mon, 5 Mar 2012 21:33:48 +0000 (21:33 +0000)]
* Use local context to get messages
* Use Language::userTime() and Language::userDate() instead of Language::time() and Language::date() to display dates with user's preferences
Alexandre Emsenhuber [Mon, 5 Mar 2012 21:21:34 +0000 (21:21 +0000)]
Make RecentChangeTest work by using the same context for expected and actual results. They were failing on my installation because $wgLang->getCode() != $wgContLang->getCode() when the test was called.
Raimond Spekking [Mon, 5 Mar 2012 21:20:53 +0000 (21:20 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Mon, 5 Mar 2012 21:14:10 +0000 (21:14 +0000)]
Appending a newline at the end of the message results in a much nicer console display
Alexandre Emsenhuber [Mon, 5 Mar 2012 21:06:56 +0000 (21:06 +0000)]
Removed incorrect svn:executable properties
Trevor Parscal [Mon, 5 Mar 2012 19:46:21 +0000 (19:46 +0000)]
Further refinements for r112836 and r112853.
* Used thiner borders on the top, right and bottom of diff lines (looks nicer with many short lines of diff)
* Dropped outlines on changed words altogether and use a slightly darker blue background for added words (couldn't make this look nice in all scenarios)
* Added borders to context lines similar to those used on added/removed lines to make them look more consistent (improves their function as context if they look more similar)
Sam Reed [Mon, 5 Mar 2012 19:17:55 +0000 (19:17 +0000)]
Add to documentation
Add a couple of braces
Update code calling Language related deprecated code
Sam Reed [Mon, 5 Mar 2012 16:38:55 +0000 (16:38 +0000)]
Fix minor issue from r112988
Sam Reed [Mon, 5 Mar 2012 15:23:04 +0000 (15:23 +0000)]
Documentation updates
Normalise method returns
Sam Reed [Mon, 5 Mar 2012 15:21:15 +0000 (15:21 +0000)]
Synchronise RELEASE-NOTES-1.19
Niklas Laxström [Mon, 5 Mar 2012 15:13:26 +0000 (15:13 +0000)]
Why is tis empty? Bug 34938
Tim Starling [Mon, 5 Mar 2012 12:14:53 +0000 (12:14 +0000)]
Transitional patch for bug 34832: introduce a CI-style option to allow deployment of 1.19 to converter wikis without disruption. The bug fix can be rolled out later by setting $wgBug34832TransitionalRollback = false. This is meant as a temporary measure, while we figure out a way to properly support Chinese wikis for inclusion in the 1.19 tarball.
Introduce a global variable which causes language conversion to not be disabled in interface messages (as before r94279). Use $wgContLang for conversion (as before r97849) since $wgContLang is set to the base language (e.g. zh) on converter wikis, whereas a typical user language (e.g. zh-tw) only has a FakeConverter.
Antoine Musso [Mon, 5 Mar 2012 12:05:13 +0000 (12:05 +0000)]
TODO about 'class' throwing a fatal error
Antoine Musso [Mon, 5 Mar 2012 11:50:30 +0000 (11:50 +0000)]
amend r113016 , that was for bug 34302
Antoine Musso [Mon, 5 Mar 2012 11:48:35 +0000 (11:48 +0000)]
place holder to test bug 34919 when it is fixed
Tim Starling [Mon, 5 Mar 2012 05:53:12 +0000 (05:53 +0000)]
* Fix for r41340, r96405, r97849: introduce a function which gets the current content language, called Parser::getTargetLanguage() following the ParserOptions terminology, and added doc comments, to improve the chances of a human being able to work out what is going on. Just because a function happens to do the thing you want doesn't mean you should call it.
* The language object used for lc() in Parser::braceSubstitution() must match the one used in setFunctionHook() during firstCallInit(). It can't change depending on what message you are parsing. Use $wgContLang like before r97849.
Krinkle [Mon, 5 Mar 2012 01:47:30 +0000 (01:47 +0000)]
[mediawiki.test] follow-up r112368: Append to fixture instead of body. Otherwise it stays in the dom even after the test is done
Brian Wolff [Mon, 5 Mar 2012 00:51:47 +0000 (00:51 +0000)]
(bug 34922) If rev_parent_id is null, then the character delta displayed on Special:Contributions is wrong. In that case instead just display "x bytes". Kind of sticks out, but better than a wrong number (possible alternative is just display no number at all)
No release notes since issue introduced in 1.19 and I'm going to tag this commit for merging.
Sam Reed [Mon, 5 Mar 2012 00:05:31 +0000 (00:05 +0000)]
Fix missing * from start of comment block
Also minor documentation update
Antoine Musso [Sun, 4 Mar 2012 23:05:44 +0000 (23:05 +0000)]
make file an argument, --title is script specific
--file did not make that many sense, it is easier to just pass the filename
as an argument
Call to parent constructor was misplaced, that made the script specific
options pretends they were generic maintenance parameters.
Krinkle [Sun, 4 Mar 2012 22:56:43 +0000 (22:56 +0000)]
[ResourceLoader] Minor clean up
* Re-order special modules and add a few comments
* Single quote in QUnitTestResources.php
* Space in ResourceLoader.php
(Separated from another commit while skimming code)
Krinkle [Sun, 4 Mar 2012 22:54:09 +0000 (22:54 +0000)]
[JSTesting] message fix
Krinkle [Sun, 4 Mar 2012 22:53:05 +0000 (22:53 +0000)]
[ObjectCache.php] Add comment describing that CACHE_ANYTHING will use whatever is configured on the wiki for $wgMainCacheType etc., and that if those are set to CACHE_NONE (which it is by default) then CACHE_ANYTHING is CACHE_DB.
Aaron Schulz [Sun, 4 Mar 2012 21:08:55 +0000 (21:08 +0000)]
Added some super calls to constructors to be safe
Raimond Spekking [Sun, 4 Mar 2012 20:23:13 +0000 (20:23 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Ryan Kaldari [Sun, 4 Mar 2012 19:14:20 +0000 (19:14 +0000)]
grammar fix
Brian Wolff [Sun, 4 Mar 2012 05:15:50 +0000 (05:15 +0000)]
(bug 28019) Make Special:MyPage and Special:MyTalk carry preloadtitle
url parameter to target page. Useful for inputbox extension.
Patch by Bagariavivek.
Perhaps should go through [[Manual:Parameters_to_index.php]] and add anything that's sane to the allowed list, at some point.
Raimond Spekking [Sat, 3 Mar 2012 21:32:20 +0000 (21:32 +0000)]
Localisation update for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Sat, 3 Mar 2012 20:22:18 +0000 (20:22 +0000)]
DatabaseBase::selectRow() return a simple object, not a ResultWrapper instance
Aaron Schulz [Sat, 3 Mar 2012 19:14:50 +0000 (19:14 +0000)]
[FileBackend]
* Various documentation improvements.
* Moved a few protected FileBackendStoreShardListIterator functions down. Same with normalizeContainerPath().