James D. Forrester [Fri, 5 Sep 2014 21:30:35 +0000 (14:30 -0700)]
Update OOjs UI to v0.1.0-pre (
8ad150e4e7)
New changes:
94b6415 Use grunt-svg2png to convert SVG icons to PNG for distribution
319052d window.svg: Fix XML validity
eab00f2 build: Remove documentation lies from 'copy' task
67f83f1 Make CSS transplantation work in IE10
8ad150e Make the background reset for dialogs in Apex work in IE10
Change-Id: I01efa40a98c4e2d23dea1060cd8116dd30a1ddcd
jenkins-bot [Fri, 5 Sep 2014 21:28:00 +0000 (21:28 +0000)]
Merge "Added a BloomCacheRedisTest class"
Translation updater bot [Fri, 5 Sep 2014 20:18:49 +0000 (22:18 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia7c9948f92b74f6a3c0d8dfa789e666640420bd5
jenkins-bot [Fri, 5 Sep 2014 19:36:40 +0000 (19:36 +0000)]
Merge "Add parser tests about building table with {{!}}"
jenkins-bot [Fri, 5 Sep 2014 19:33:17 +0000 (19:33 +0000)]
Merge "Remove unneeded spaces inside html in NoLocalSettings.php"
jenkins-bot [Fri, 5 Sep 2014 19:32:47 +0000 (19:32 +0000)]
Merge "Sanitizer::escapeId: Decode entity before replacing spaces"
jenkins-bot [Fri, 5 Sep 2014 19:30:35 +0000 (19:30 +0000)]
Merge "Refactor: Use local variables for editsections in Parser"
jenkins-bot [Fri, 5 Sep 2014 19:29:57 +0000 (19:29 +0000)]
Merge "Add tests for User::getCanonicalName()"
jenkins-bot [Fri, 5 Sep 2014 19:25:26 +0000 (19:25 +0000)]
Merge "Improve tests for OutputPage::makeResourceLoaderLink"
jenkins-bot [Fri, 5 Sep 2014 19:00:54 +0000 (19:00 +0000)]
Merge "mediawiki.notification: Also hide #mw-notification-area upon creation"
Roan Kattouw [Fri, 5 Sep 2014 18:40:27 +0000 (11:40 -0700)]
mediawiki.notification: Also hide #mw-notification-area upon creation
6c5b246 made it so #mw-notification-area was hidden when the last
notification was dismissed, but it still left it visible when
initially creating it. This meant that if you used mw.notify(),
you had no problems, but if you loaded the mediawiki.notification
module manually and called it manually, you would still get
a 12px-tall click-stealing invisible div until the first notification
was displayed.
Bug: 52659
Change-Id: Ibec399ac9ef083036aa2b31a38bcc1bc36b87d96
jenkins-bot [Fri, 5 Sep 2014 18:35:46 +0000 (18:35 +0000)]
Merge "Remove Parsoid-specific padding and background"
jenkins-bot [Fri, 5 Sep 2014 18:07:34 +0000 (18:07 +0000)]
Merge "Typo fix: HMTL → HTML"
Gabriel Wicke [Fri, 5 Sep 2014 18:04:30 +0000 (11:04 -0700)]
Remove Parsoid-specific padding and background
Those shouldn't be necessary any more, and are getting in the way for visual
diffing.
Change-Id: Ic7ea7d014d27bc7cf9a3d7c26808c96bf7f1d8fb
Aaron Schulz [Fri, 5 Sep 2014 00:06:09 +0000 (17:06 -0700)]
Added a BloomCacheRedisTest class
Change-Id: Id0b8f6dfa96f5f56dcb77eebdca506c82a36a1c2
Bartosz Dziewoński [Sat, 30 Aug 2014 15:26:31 +0000 (17:26 +0200)]
mediawiki.api: Actually don't log request error 'abort'
173930cb32, once more, with feeling. I'm not sure why the previous
version has ever worked, given that our own code (a few lines above
this, starting from '// Make the AJAX request') is written in such a
way that `code` can never be `'abort'`.
Bug: 65442
Change-Id: I34bcaa362806bf9e80fb40bc92723f85bea1fb64
James D. Forrester [Sun, 31 Aug 2014 22:19:15 +0000 (15:19 -0700)]
build: Bump grunt-banana-checker to 0.2.0 and fix flagged issue
Change-Id: I808384b28684799c89a7c33dd86c3bcf7764cc25
jenkins-bot [Fri, 5 Sep 2014 15:22:30 +0000 (15:22 +0000)]
Merge "Move log log_page entries are now that of the moved page"
jenkins-bot [Fri, 5 Sep 2014 14:15:57 +0000 (14:15 +0000)]
Merge "APIQueryInfo: Allow fetching the canonical url of a page"
Chad Horohoe [Fri, 5 Sep 2014 13:51:27 +0000 (06:51 -0700)]
Reset searchTerms[] before populating.
Otherwise, multiple calls to searchQuery() would accumulate search
terms. searchTerms[] is defined in SearchEngine so we can't just get
rid of it altogether.
Change-Id: Iddbb3920e3a9d5849c99fe90d2d725d16019b51d
umherirrender [Mon, 25 Aug 2014 18:24:10 +0000 (20:24 +0200)]
Add tests for User::getCanonicalName()
Change-Id: I00097a4706c4ada41a5697470b550c925ae6051d
Bartosz Dziewoński [Fri, 5 Sep 2014 13:40:12 +0000 (15:40 +0200)]
Typo fix: HMTL → HTML
Change-Id: Id2bb52b92b7cf47a7a22506a01663acfee606ac4
umherirrender [Fri, 4 Jul 2014 20:19:48 +0000 (22:19 +0200)]
Refactor: Use local variables for editsections in Parser
In Parser.php an array was built and then the elements of that array
were used, replaced this by local vars.
In ParserOutput.php also use local vars to make the code more readable.
Also inlined a private callback by using an anonymous function.
Change-Id: I1c31c9e4855f93a8fb65e1c21faba46fcdcb1f4b
Kunal Mehta [Fri, 5 Sep 2014 10:20:27 +0000 (03:20 -0700)]
APIQueryInfo: Allow fetching the canonical url of a page
Change-Id: If0f62481d059815390b74ccf8167957bc1dbce52
Alexandre Emsenhuber [Sun, 29 Jun 2014 13:17:43 +0000 (15:17 +0200)]
Update Special:ChangeEmail to use HTMLForm
Makes the code shorter and easier to read.
Change-Id: I629cee4264fad6cde98495c0e8daffe5ea245b48
jenkins-bot [Thu, 4 Sep 2014 22:44:22 +0000 (22:44 +0000)]
Merge "mediawiki.skinning: Remove obsolete #firstHeading selector"
jenkins-bot [Thu, 4 Sep 2014 22:41:27 +0000 (22:41 +0000)]
Merge "Allow extensions to indicate a username doesn't exist"
csteipp [Thu, 28 Aug 2014 19:46:09 +0000 (12:46 -0700)]
Allow extensions to indicate a username doesn't exist
Provide a way for extensions to nicely handle when a username doesn't
exist, during the login process. This only is obviously only for the
case when we know why it doesn't exist (it was renamed, deleted, etc.)
See I06b9b6322e408868f516aeabd61c6580f304e009 for CentralAuth use case.
Bug: 67995
Change-Id: If48d59afa63ace68c147eca952f1d4f43acc105f
Chad Horohoe [Thu, 4 Sep 2014 02:30:15 +0000 (19:30 -0700)]
EditPageTest: Rewrite testCreatePage() to use a data provider
Change-Id: I415f9fdbca6a625d8d1e9ff4c05c861a96dfa290
Chad Horohoe [Thu, 4 Sep 2014 01:58:33 +0000 (18:58 -0700)]
ArticleTablesTest: Clarify test name and docs
Change-Id: I55778b7e41da520a248fba2cb46e2c42745c6519
Bartosz Dziewoński [Thu, 4 Sep 2014 20:13:53 +0000 (22:13 +0200)]
Fix directions of some pagers
Follow-up to
6a637fb0. Turns out these are more confusing than
I originally suspected.
Bug: 70413
Change-Id: Ic4245d9ac14e4cd2f8f5aca0878edcd4dcf85521
jenkins-bot [Thu, 4 Sep 2014 20:03:11 +0000 (20:03 +0000)]
Merge "Bound the cache size of numberofWatchingusers()"
Aaron Schulz [Wed, 20 Aug 2014 23:58:13 +0000 (16:58 -0700)]
Bound the cache size of numberofWatchingusers()
Change-Id: I60c9898318e340ee3c97d24b528d85a5f8c492e5
Translation updater bot [Thu, 4 Sep 2014 19:47:32 +0000 (21:47 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I68e53f64512010d53117d424458cc37ee078b7fb
Nik Everett [Thu, 4 Sep 2014 18:59:19 +0000 (14:59 -0400)]
Be more careful with Special: prefix searching
Bug: 70409
Change-Id: I3764bff1bf7b2d11a7c8f8cc8564eeae9953ea30
Aaron Schulz [Thu, 4 Sep 2014 18:02:34 +0000 (11:02 -0700)]
Profile User::checkPassword
Change-Id: I2e7e9574a56725f4e7c34415b241006a933f631d
jenkins-bot [Thu, 4 Sep 2014 17:28:16 +0000 (17:28 +0000)]
Merge "mediawiki.skinning.content.externallinks: Code quality tweaks"
jenkins-bot [Thu, 4 Sep 2014 17:15:42 +0000 (17:15 +0000)]
Merge "LocalisationCache: Process one fallback at a time"
Timo Tijhof [Thu, 4 Sep 2014 16:57:22 +0000 (18:57 +0200)]
mediawiki.skinning: Remove obsolete #firstHeading selector
Too strong and forces all overrides to also use the ID. The
fallback skin doesn't even have the ID.
Change-Id: Iacf382d49520228a073ed2776b18303bb00b9c0d
Brad Jorsch [Wed, 3 Sep 2014 16:52:33 +0000 (12:52 -0400)]
LocalisationCache: Process one fallback at a time
Currently LocalisationCache merges the core data for all languages in
the fallback chain, then the extension data, then merges those two, and
then gives extensions like LocalisationUpdate a chance to make final
overrides with the LocalisationCacheRecache hook.
But if LocalisationUpdate doesn't want to locally duplicate all the
messages for every language (e.g. r104041), LocalisationCacheRecache is
too late: the information as to whether a message came from the primary
language or a fallback has been lost, so when LU itself has an override
for a fallback language it can't know whether or not the existing
message should be overridden or not.
The solution is for LocalisationCache to gather the data for each
fallback language separately, call a new hook for LU to affect just that
language (LocalisationCacheRecacheFallback), and only then merge the
fallback languages together.
Bug: 68781
Change-Id: Iacfe96063fcc66c1f97ca5e5292a8fc70af988cf
Bartosz Dziewoński [Sun, 31 Aug 2014 00:48:07 +0000 (02:48 +0200)]
Move mediawiki.skinning.* modules from skins/common/ to resources/
This is a BREAKING CHANGE, as we have used the names of these three
files in skins/common/ as a "public API" for skins for a long time.
Doing so has been deprecated (but still supported) in 1.23.
We must clear them out at some point, and now is as good a time as
ever, with the 1.23 LTS release still supporting the old way.
Skins may no longer rely on the presence of commonElements.css,
commonContent.css and commonInterface.css in skins/common/ and
include them in their style modules. The corresponding ResourceLoader
modules must be used instead:
- skins/common/commonElements.css → 'mediawiki.skinning.elements' module
- skins/common/commonContent.css → 'mediawiki.skinning.content' module
- skins/common/commonInterface.css → 'mediawiki.skinning.interface' module
Follow-up to I3947eaac (where I said I intend to do this) and I56758908.
Bug: 69277
Change-Id: Id8456c570ff406822a8befad8f42f528ef5bd3a6
Prateek Saxena [Thu, 31 Jul 2014 13:44:04 +0000 (19:14 +0530)]
Use 'div' instead of 'section' and 'article'
The user-agent stylesheet was making the size
of both the h1's and h2's 1.5em as it was inside
<article> and <section>
:-webkit-any(article,aside,nav,section)
h1 - 1.5em user agent stylesheet
~h1 - 2em~ user agent stylesheet
Change-Id: Ied1d03f63c132dc3904d05cd4e55f70aa3f80c3d
James D. Forrester [Thu, 4 Sep 2014 00:40:40 +0000 (17:40 -0700)]
Update OOjs UI to v0.1.0-pre (
36d0c7dc3b)
New changes:
01dd8a7 Make menus reevaluate their clipping when they change
7b51164 Fix click-block focus-loss prevention
e2a42c7 Update oojs to v1.1.0
adfcf92 Fix process dialog title text position
cde46d8 jsduck: Rename config file to jsduck.json (per standard)
7a6a0eb Fix documentation typo
060cf0c [BREAKING CHANGE] Element mixin refactor
e93f10a readme: Use <pre> instead of ```
9d15ebe Revert "Build with clean CSS"
db1b656 Automatically align popup toolgroups
4cef83f Don't use /** in CSS or LESS, use /* instead
Change-Id: Ib06422e7e81594e7f3590955feb89409d801e1a4
jenkins-bot [Wed, 3 Sep 2014 23:40:53 +0000 (23:40 +0000)]
Merge "Remove dead mime_content_type() code paths"
Aaron Schulz [Wed, 27 Aug 2014 18:32:40 +0000 (11:32 -0700)]
Tweaked cache size in getCachedRevisionObject()
Change-Id: I3b01011f21bf3218f3b5c74430b5d5f9ceaec83e
jenkins-bot [Wed, 3 Sep 2014 22:52:05 +0000 (22:52 +0000)]
Merge "Use a custom MediaWiki logo during installation"
Aaron Schulz [Tue, 2 Sep 2014 19:59:18 +0000 (12:59 -0700)]
Move log log_page entries are now that of the moved page
bug: 57084
Change-Id: Ibc20d79093eedcdaba1873861e177ca3a6108bca
Timo Tijhof [Wed, 3 Sep 2014 15:19:41 +0000 (17:19 +0200)]
Use String#slice instead of String#substr or String#substring
Quite a few reasons:
* There is a bug in IE 8 and below where the startIndex argument
does not support negative values, contrary to the ECMAScript
spec and implementations in other browsers.
IE8:
'faux'.substr( -1 ); // "faux"
Standards:
'faux'.substr( -1 ); // "x"
Code written for ES5 (and using the es5-shim) works as expected
since the shim repairs this method.
* String#substr and String#substring both exist but have
different signatures which are easily mixed up.
String.prototype.substr( start [, length] )
> Supports negative start, but not in IE8 and below.
> Takes length, *not* second index. E.g. `substr( 2, 3 )`
returns `slice( 2, 5 )`.
String.prototype.substring( indexA [, indexB] )
> Doesn't support negative indices.
> If indexA is larger than indexB, they are silently swapped!
String.prototype.slice( start [, end] )
> Supports negative indices.
'faux'.substr( 0, 2 ); // "fa"
'faux'.substring( 0, 2 ); // "fa"
'faux'.slice( 0, 2 ); // "fa"
'faux'.substr( -2 ); // "ux"
'faux'.substring( -2 ); // "faux"
'faux'.slice( -2 ); // "ux"
'faux'.substr( 1, 2 ); // "au"
'faux'.substring( 1, 2 ); // "a"
'faux'.slice( 1, 2 ); // "a"
'faux'.substr( 1, -1 ); // ""
'faux'.substring( 1, -1 ); // "f"
'faux'.slice( 1, -1 ); // "au"
'faux'.substr( 2, 1 ); // "u"
'faux'.substring( 2, 1 ); // "a"
'faux'.slice( 2, 1 ); // ""
* String#slice works the same way as Array#slice and slice
methods elsewhere (jQuery, PHP, ..).
* Also simplify calls:
- Omit second argument where it explicitly calculated the length
and passed it as is (default behaviour)
- Pass negative values instead of length - x.
- Use chatAt to extract a single character.
* Change:
- Replace all uses of substring() with slice().
- Replace all uses of substr() with slice() where only one
parameter is passed or where the first parameter is 0.
- Using substr()'s unique behaviour (length instead of endIndex)
is fine, though there's only one instances of that, in
mediawiki.jqueryMsg.js
Change-Id: I9b6dd682a64fa28c7ea0da1846ccd3b42f9430cf
jenkins-bot [Wed, 3 Sep 2014 20:28:57 +0000 (20:28 +0000)]
Merge "More tweaks to job backoff code"
Aaron Schulz [Wed, 3 Sep 2014 19:48:37 +0000 (12:48 -0700)]
Make sure getMulti() returns an array per the class interface
Change-Id: Ic08f3ac37467a2743d7f8be5f5fb0032f84c3b82
Translation updater bot [Wed, 3 Sep 2014 19:54:10 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I1c11c55dbe5f7e1e530e22fb6021a83be3adfcee
Aaron Schulz [Wed, 3 Sep 2014 18:50:12 +0000 (11:50 -0700)]
More tweaks to job backoff code
* Replace one time() call with microtime() in syncBackoffDeltas().
Also moved the call down slightly to not count flock() delay.
* Moved read-only case logic into syncBackoffDeltas().
* Moved $backoffExpireFunc logic into syncBackoffDeltas().
* Tightened the syncBackoffDeltas() checks around pop() for
better accuracy.
Change-Id: Ifed3d24ba62277c0e0f52cdc1051990a590be18a
jenkins-bot [Wed, 3 Sep 2014 18:34:48 +0000 (18:34 +0000)]
Merge "Add SkinPreloadExistence hook"
jenkins-bot [Wed, 3 Sep 2014 18:11:02 +0000 (18:11 +0000)]
Merge "Improved job backoff handling to be more properly per-server"
Bartosz Dziewoński [Fri, 29 Aug 2014 21:07:09 +0000 (23:07 +0200)]
Add SkinPreloadExistence hook
Bug: 69650
Change-Id: Ia16c2034cdf6cdc9ac8e37b113ffbbecd272087f
jenkins-bot [Wed, 3 Sep 2014 18:07:52 +0000 (18:07 +0000)]
Merge "IndexPager: Introduce constants for values of $mDefaultDirection"
Bartosz Dziewoński [Mon, 25 Aug 2014 15:26:58 +0000 (17:26 +0200)]
IndexPager: Introduce constants for values of $mDefaultDirection
I've spent several hours looking at related code and I still can't
remember which direction is 'true' and which is 'false'.
Change-Id: I58694f7a0892c986e7215f59b56b014cece8d40d
jenkins-bot [Wed, 3 Sep 2014 17:51:17 +0000 (17:51 +0000)]
Merge "mediawiki.ui: Remove deployment hack"
jenkins-bot [Wed, 3 Sep 2014 17:50:36 +0000 (17:50 +0000)]
Merge "Added BloomCache classes"
jenkins-bot [Wed, 3 Sep 2014 17:49:33 +0000 (17:49 +0000)]
Merge "mediawiki.action.view.metadata: Include the CSS we need, don't rely on shared.css"
Aaron Schulz [Wed, 2 Jul 2014 22:55:03 +0000 (15:55 -0700)]
Added BloomCache classes
* Implemented a version of BloomCache using Redis
* Added a BloomCheckTitleHasLogs handler class for avoiding
slow logging table queries when large amounts of 404 pages
are viewed (by various web crawlers at the moment).
bug: 67439
Change-Id: I26e5034755e3a7208a45991b1cf2f12467679cc1
Bartosz Dziewoński [Wed, 3 Sep 2014 13:47:59 +0000 (15:47 +0200)]
Delete skins/common/images/closewindow19x19.png
Unused in core, unused in extensions (as far as I can tell) and unused
on-wiki (as far as I can tell).
There are still requests for it (according to bug 69277 comment 11), but
we can't do anything about that if we can't tell where they come from.
Bug: 69277
Change-Id: I2cf158229955c93ecbf29c83d04df121e4b4addc
Bartosz Dziewoński [Mon, 11 Aug 2014 02:11:37 +0000 (04:11 +0200)]
Use a custom MediaWiki logo during installation
Previously we used the regular logo, which could prove confusing when
one switched back-and-forth between the installed and mediawiki.org
pages.
The new one is "half-drawn", evoking the image that we are in the
process of creating something (a new wiki). I like that.
Source: <https://commons.wikimedia.org/wiki/File:Wikitech-logo.png>,
authored by Brion, GFDL 1.2+. It was previously used as a logo of the
Wikitech wiki, but that has unicorns instead now.
Change-Id: Ic5c83bb85e6b6a11978d452fbe46d2dad9c5a553
Kevin Israel [Fri, 18 Jul 2014 06:05:26 +0000 (02:05 -0400)]
Remove dead mime_content_type() code paths
Since PHP 5.3, mime_content_type() is implemented as part of PHP's
fileinfo extension and thus is deprecated in favor of the newer
alternatives provided by that extension (already in use).
Also updated a comment in DefaultSettings.php that mentioned the
function. Did not modify lessc.inc.php, a third-party library
maintained separately from MediaWiki.
Change-Id: Ic4a0873989ddb634ec9a05c3340941a9ba3f5ec5
Sergio Santoro [Wed, 23 Jul 2014 15:28:50 +0000 (17:28 +0200)]
GlobalTest: Add test for wfRandomString()
Change-Id: I8e681ed6a32a4a13603cad3cd3dc56545e16220f
Aaron Schulz [Sat, 30 Aug 2014 02:48:09 +0000 (19:48 -0700)]
Improved job backoff handling to be more properly per-server
Change-Id: I7c8e44a474ca8d05771477665ba508a358c5747d
Bartosz Dziewoński [Thu, 28 Aug 2014 17:50:59 +0000 (19:50 +0200)]
mediawiki.action.view.metadata: Include the CSS we need, don't rely on shared.css
Change-Id: I4b1cbc5998492272825d33842ee3721a41b19b4c
jenkins-bot [Wed, 3 Sep 2014 09:36:53 +0000 (09:36 +0000)]
Merge "mediawiki.language: Implement Language::listToText in JS"
jenkins-bot [Wed, 3 Sep 2014 03:53:39 +0000 (03:53 +0000)]
Merge "Remove the sub page when using the form in Special:ListFiles"
jenkins-bot [Wed, 3 Sep 2014 03:51:55 +0000 (03:51 +0000)]
Merge "Use protocol default port with HTTP_X_FORWARDED_PROTO"
jenkins-bot [Tue, 2 Sep 2014 21:44:32 +0000 (21:44 +0000)]
Merge "OutputPage: Restore ResourceLoader condition wrap for embedded modules"
jenkins-bot [Tue, 2 Sep 2014 21:18:00 +0000 (21:18 +0000)]
Merge "Add new hook WatchlistEditorBeforeFormRender"
jenkins-bot [Tue, 2 Sep 2014 21:05:48 +0000 (21:05 +0000)]
Merge "Use descriptive key for array of in a Special:EditWatchlist line"
jenkins-bot [Tue, 2 Sep 2014 20:54:51 +0000 (20:54 +0000)]
Merge "Allow hook subscribers to also overwrite link to title"
jenkins-bot [Tue, 2 Sep 2014 20:18:02 +0000 (20:18 +0000)]
Merge "wfBaseConvert(): Work around PHP Bug #50175"
Kevin Israel [Tue, 2 Sep 2014 19:33:43 +0000 (15:33 -0400)]
wfBaseConvert(): Work around PHP Bug #50175
Before php/php-src@
834daa455bc9, PHP's gmp_init() function would try
to autodetect hex and binary numbers even when a base was explicitly
specified[1], so the results for some base-36 numbers having leading
zeros could be incorrect. Work around this bug by trimming off any
leading zeros before calling gmp_init().
[1]: https://bugs.php.net/bug.php?id=50175
Bug: 69249
Change-Id: I5f5458c1a1195f55fa12904c103da6ea7558010a
Translation updater bot [Tue, 2 Sep 2014 19:40:03 +0000 (21:40 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ief87c2034d619839fd6d0a49b9339089475275b5
jenkins-bot [Tue, 2 Sep 2014 17:04:10 +0000 (17:04 +0000)]
Merge "Add missing space to autodoc of meta=siteinfo&siprop=languages"
jenkins-bot [Tue, 2 Sep 2014 15:50:31 +0000 (15:50 +0000)]
Merge "shared.css: Limit .plainlinks styling to .external links"
Timo Tijhof [Tue, 2 Sep 2014 01:25:13 +0000 (03:25 +0200)]
OutputPage: Restore ResourceLoader condition wrap for embedded modules
Follows-up
9272bc6c47,
03c503da22.
* In
9272bc6c47, the condition wrap was removed from
OutputPage for no reason. This went unnnoticed as I had also
accidentally made the cond wrap in makeModuleResponse apply
to both only=scripts and regular (faux) responses, such as by
OutputPage embedding private modules.
* In
03c503da22, the latter bug was fixed, thus exposing the former.
This wrapper belongs in OutputPage, not in ResourceLoader. It's
OutputPage making the loader request. And just like in other places,
it's the "client"'s responsibility to ensure the request is either not
made or wrapped appropriately.
The test for "private module (only=scripts)" could be removed but
I'll keep it so we can see how this changes in the future. It's
a case that can't ever happen, but if it would, it currently gets
a double condition wrapper, which is fine.
Change-Id: Id333e4958ed769831fabca02164c1e8505962d57
withoutaname [Wed, 16 Jul 2014 18:14:52 +0000 (11:14 -0700)]
Removed request() and output() from class "MediaWiki"
Also removed the todo, as the folding was done years ago.
Change-Id: I4953ec3ca650bab9154c07a3a73f1f6ca4ee071e
jenkins-bot [Mon, 1 Sep 2014 20:30:31 +0000 (20:30 +0000)]
Merge "Use .mw-body in skins"
jenkins-bot [Mon, 1 Sep 2014 20:22:57 +0000 (20:22 +0000)]
Merge "mediawiki.language: Fix infinite loop in commafy() when pattern has no grouping"
Arlo Breault [Wed, 13 Aug 2014 11:15:47 +0000 (04:15 -0700)]
Use .mw-body in skins
* This helps Parsoid's output reach parity.
* Merge in conjunction with
Vector: Iae873906abcd8b2a986e5f728f0ce207256de770
MonoBook: I0c889950e618b2afa6332c4c56b5531744526e72
Bug: 38726
Change-Id: Id0228fa839ef80b0b3bfee864e81f2c65963e01b
Translation updater bot [Mon, 1 Sep 2014 20:04:33 +0000 (22:04 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I7d2e35ecc2b78e4103236275edb8838b61843a41
jenkins-bot [Mon, 1 Sep 2014 16:41:11 +0000 (16:41 +0000)]
Merge "QA: Remove logic for inexistant "wpvector-collapsiblenav" option"
Timo Tijhof [Mon, 1 Sep 2014 16:11:13 +0000 (18:11 +0200)]
QA: Remove logic for inexistant "wpvector-collapsiblenav" option
This option was never part of MediaWiki core and shouldn't have
been here in the first place.
It was removed from the Vector extension in October 2013 with I33dc0033c.
Not sure what this code is for or why it's not failing.
Change-Id: Ie552d9de3aa1f123a8f1c9414b444481461b4ec6
jenkins-bot [Mon, 1 Sep 2014 14:39:48 +0000 (14:39 +0000)]
Merge "mediawiki.action.edit: Improve #addButton documentation"
jenkins-bot [Mon, 1 Sep 2014 14:07:01 +0000 (14:07 +0000)]
Merge "Revert "Toolbar: Only show on WikiText pages""
jenkins-bot [Mon, 1 Sep 2014 13:58:18 +0000 (13:58 +0000)]
Merge "Category finder style cleanups"
Helder.wiki [Sat, 23 Aug 2014 23:11:01 +0000 (23:11 +0000)]
Revert "Toolbar: Only show on WikiText pages"
Classical toolbar no longer appears in Page namespace on Wikisources.
This reverts commit
7263ef1e002786b27fa06db43aa7a6fca00461fb.
Bug: 69447
Bug: 29908
Change-Id: Ifafe41f7bc91183e0db4c10d8340a8b620b380bc
Bartosz Dziewoński [Sat, 30 Aug 2014 23:30:51 +0000 (01:30 +0200)]
mediawiki.action.edit: Improve #addButton documentation
Change-Id: I6ba4e711dfb492357e1364681d986b0c5515599e
jenkins-bot [Mon, 1 Sep 2014 12:13:18 +0000 (12:13 +0000)]
Merge "Use correct progressive color on inputs"
Santhosh Thottingal [Sat, 23 Aug 2014 12:52:03 +0000 (18:22 +0530)]
mediawiki.language: Fix infinite loop in commafy() when pattern has no grouping
When the decimal part of the pattern has no grouping, commafy was entering
into an infinite loop. Corrected the logic to handle this case.
Also added qunit tests.
Bug: 69835
Change-Id: I0f9e274411aead6a4e95402fd38c54ac6b76df53
jenkins-bot [Mon, 1 Sep 2014 09:50:19 +0000 (09:50 +0000)]
Merge "Move actual OldChangesList line formatting to separate method"
umherirrender [Sat, 30 Aug 2014 08:39:34 +0000 (10:39 +0200)]
Add missing space to autodoc of meta=siteinfo&siprop=languages
Change-Id: I56ba3b3282ea747b47016558513f96ca597e28d7
James D. Forrester [Sun, 31 Aug 2014 21:26:08 +0000 (14:26 -0700)]
Update OOjs to v1.1.0
Release notes:
https://git.wikimedia.org/blob/oojs%2Fcore.git/v1.1.0/History.md
Change-Id: I37cfbfe14ef07e811bd2c8d6656ff5315dc8c3b6
jenkins-bot [Sun, 31 Aug 2014 20:40:12 +0000 (20:40 +0000)]
Merge "add mw-diff-* classes to view diff page header links"
Translation updater bot [Sun, 31 Aug 2014 19:35:32 +0000 (19:35 +0000)]
Merge "Localisation updates from https://translatewiki.net."
Translation updater bot [Sun, 31 Aug 2014 19:34:12 +0000 (21:34 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I523c093311ea09aad64e235f2d9f155c56b714a9