Bartosz Dziewoński [Tue, 15 Sep 2015 22:36:02 +0000 (00:36 +0200)]
Update UploadWizard-specific messages
Merge after I706d76ab4720a94e772d03196c91697d9047f5b9 in UploadWizard.
Two messages lost a silly link and $2 parameter:
* api-error-duplicate
* api-error-duplicate-archive
They were both confusingly phrased, as if the link led directly to the
file; instead, at least in UploadWizard, clicking on it opened a popup
dialog with a list. I don't expect the change to be problematic, the
few translations that I understand work equally well with the link
removed, and UploadWizard code can now handle both versions. I'm not
aware of any uses elsewhere, hopefully this makes the messages less
UploadWizard-specific and more reusable.
Two messages were removed because they are no longer used in Gerrit extensions::
* api-error-duplicate-archive-popup-title
* api-error-duplicate-popup-title
Bug: T34606
Change-Id: I9661f24323371f186976df1f5569aba002d4f34e
jenkins-bot [Mon, 21 Sep 2015 09:40:43 +0000 (09:40 +0000)]
Merge "Removed old "noPush" config hacks from FileBackendMultiWrite"
jenkins-bot [Mon, 21 Sep 2015 09:40:39 +0000 (09:40 +0000)]
Merge "Avoid master queries on image history view"
jenkins-bot [Mon, 21 Sep 2015 09:31:01 +0000 (09:31 +0000)]
Merge "Prevent IDEA error in doOperationsInternal()"
jenkins-bot [Mon, 21 Sep 2015 09:29:47 +0000 (09:29 +0000)]
Merge "Removed unused LockManager var"
jenkins-bot [Mon, 21 Sep 2015 09:29:24 +0000 (09:29 +0000)]
Merge "Made some FileBackendMultiWrite docs more accurate"
Aaron Schulz [Mon, 21 Sep 2015 06:04:29 +0000 (23:04 -0700)]
Prevent IDEA error in doOperationsInternal()
Change-Id: I2f0a1885803fff9dc0eb8ca4a595a83736ce421b
Aaron Schulz [Sun, 20 Sep 2015 20:57:46 +0000 (13:57 -0700)]
Removed unused LockManager var
Change-Id: I02c1fef624e6f2fe04e3c6d525aaed881eacabd7
Translation updater bot [Sun, 20 Sep 2015 19:38:30 +0000 (21:38 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Icdbc2c339c73d7535bff79444065260c8a9a8065
jenkins-bot [Sun, 20 Sep 2015 19:26:50 +0000 (19:26 +0000)]
Merge "Fix hook documentation for ArticleRevisionVisibilitySet"
Aaron Schulz [Sun, 20 Sep 2015 19:24:48 +0000 (19:24 +0000)]
Merge "Cleaned up getScopedFileLocks() return value"
umherirrender [Sun, 20 Sep 2015 08:47:29 +0000 (10:47 +0200)]
Fix hook documentation for ArticleRevisionVisibilitySet
The last parameter was not in documentation.
Follows I6a14c7b95041fdd44d7962af6dc139bcc29f7223
Change-Id: I5e5d8948d6a1f4dc2db09028c77cfb79fb4ed5d0
jenkins-bot [Sun, 20 Sep 2015 15:10:08 +0000 (15:10 +0000)]
Merge "Strip comments before gathering url(...) refs in CSS"
Aaron Schulz [Sun, 20 Sep 2015 04:11:53 +0000 (21:11 -0700)]
Made some FileBackendMultiWrite docs more accurate
Change-Id: I14c152601fef3d3c75e7ea7aac72ff87c9f5fd52
Translation updater bot [Sat, 19 Sep 2015 20:54:08 +0000 (22:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I211d55ab5194485af47b42a5e428c7475d9a7c44
Elliott Eggleston [Sat, 19 Sep 2015 19:32:09 +0000 (15:32 -0400)]
Strip comments before gathering url(...) refs in CSS
Change I5a3cdeb7d53485f161ccf8133e76850cdf5b4579 introduced tests
for existence of all local files referenced in CSS. It's currently
failing changes even when the referenced files have been commented
out. This change ensures that commented-out files are not included
in the testing list.
Change-Id: I2ad74c13a9cf36e96a7d7451bf229856bcd18422
jenkins-bot [Sat, 19 Sep 2015 18:23:06 +0000 (18:23 +0000)]
Merge "Support async writes to secondary MultiWriteBagOStuff stores"
Aaron Schulz [Fri, 18 Sep 2015 22:19:54 +0000 (15:19 -0700)]
Fixed small IDE error in \96syncFileBackend.php
Change-Id: I86c6cf73470109af2eb88d1c0d053292391630e7
jenkins-bot [Sat, 19 Sep 2015 17:00:36 +0000 (17:00 +0000)]
Merge "Update at-ease to v1.1.0, and OOjs UI to v0.12.8-atease"
mjbmr [Mon, 17 Aug 2015 11:56:04 +0000 (11:56 +0000)]
Add localized "Project" namespace alias for Northern Luri
Change-Id: I6a33acac4ccb440a1784826e8090c7746fb2af7c
Kevin Israel [Sat, 19 Sep 2015 06:07:13 +0000 (02:07 -0400)]
DatabaseBase::deadlockLoop(): Remove unused variables
Follows-up
419221e4a71b.
Change-Id: Ia0d50e40600ca2cd7b90441b66340d3c290be85f
Aaron Schulz [Fri, 21 Aug 2015 06:53:52 +0000 (23:53 -0700)]
Support async writes to secondary MultiWriteBagOStuff stores
* This is useful for ParserCache, as it tries to focus on memcached
and use other caches (e.g. mariadb) for the long-tail of less used
content, as setup on WMF. The class uses BagOStuff in a way that is
compatible with this approach.
Bug: T109751
Change-Id: Ia64eb44a9b52a988fde27b468d604d9163bed4b4
Aaron Schulz [Sat, 19 Sep 2015 00:36:09 +0000 (17:36 -0700)]
Removed old "noPush" config hacks from FileBackendMultiWrite
Change-Id: I80e688cc61c0a656524a0db6aeabb3d3f6e667bd
Ori Livneh [Wed, 16 Sep 2015 23:51:53 +0000 (16:51 -0700)]
resourceloader: Use MD4 to compute file hash rather than SHA1
The hash value generated by ResourceLoaderModule::safeFileHash() is used for
versioning and cache invalidation, so a cryptographic hash function is not
necessary. We can get better performance by using MD4.
Wikimedia on-CPU time over 24 hours of safeFileHash() in load.php:
* 6.68% with safeFileHash using SHA1 (day 1)
* 7.07% with safeFileHash using SHA1 (day 2)
* 2.84% with safeFileHash using MD4 (day 3)
Change-Id: I6ff728f1240268517c0f03e0823129316bc901cb
jdlrobson [Sat, 22 Aug 2015 00:15:48 +0000 (17:15 -0700)]
Do not double load gallery styles now cache has expired
Was separated in 1.26wmf21 (Ib1aef04dc4fece78e6615386ecaef6a9f368f49e)
We should aim to get this in 1.26wmf24 (there will still
be a small amount of pages with outdated HTML but the benefit
to all users not double loading is arguably larger at this point)
Bug: T110709
Change-Id: I96acc21f57ecc8c5e55df9528a4412d0ea641fa8
Translation updater bot [Fri, 18 Sep 2015 21:08:20 +0000 (23:08 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If90fadcca386970dc6fe43f225d873fa538f9ef7
James D. Forrester [Fri, 18 Sep 2015 18:52:43 +0000 (11:52 -0700)]
Update at-ease to v1.1.0, and OOjs UI to v0.12.8-atease
Change-Id: I2e2224f802378f583702fe54e4acfc2937612396
Aaron Schulz [Fri, 18 Sep 2015 17:45:15 +0000 (10:45 -0700)]
Cleaned up getScopedFileLocks() return value
* Just return the ScopedLock itself without wrappig it in an array.
This also makes getScopedLocksForOps() actually return the correct
type according to the docs
Change-Id: Ic2d01d56c3fcb22af3adb5e5d4d1586d62316552
Ori Livneh [Fri, 18 Sep 2015 17:44:50 +0000 (10:44 -0700)]
Fix another test broken by I826adf9
Change-Id: I15367691af8d2290d54cdb3bb134dfa71a15f9f7
Ori Livneh [Fri, 18 Sep 2015 17:26:00 +0000 (10:26 -0700)]
Fix test broken by I826adf9
Change-Id: I4313188767d47cf9efcfd24ed2716475a289bb77
Ori Livneh [Thu, 10 Sep 2015 22:22:13 +0000 (15:22 -0700)]
Replace leafo/lessphp with oyejorge/less.php
Bug: T112035
Change-Id: I826adf981ac28c44f0915ceb059d699d6b23a254
Ori Livneh [Fri, 18 Sep 2015 16:40:55 +0000 (09:40 -0700)]
Add missing semicolon to mediawiki.filewarning.less
Change-Id: Ifc6adeff9d77a0766098c7861ce11164e8218357
Glaisher [Sat, 22 Aug 2015 12:27:56 +0000 (17:27 +0500)]
SpecialChangeEmail: error if old email was entered in new email field
Current behavior is to redirect to Special:Preferences without showing
any message. Instead of that, showing an error message is user-friendlier.
Bug: T38561
Change-Id: I6173cd653f682d5a1be61104db213b577c4adfcf
jenkins-bot [Fri, 18 Sep 2015 09:16:13 +0000 (09:16 +0000)]
Merge "Don't check namespace in SpecialWantedtemplates"
jenkins-bot [Fri, 18 Sep 2015 09:10:27 +0000 (09:10 +0000)]
Merge "Database: Remove unused errorCount() method"
jenkins-bot [Fri, 18 Sep 2015 09:08:27 +0000 (09:08 +0000)]
Merge "Use User::equals() where applicable in the class"
jenkins-bot [Fri, 18 Sep 2015 09:04:57 +0000 (09:04 +0000)]
Merge "Update test documentation, fix broken links"
jenkins-bot [Fri, 18 Sep 2015 08:55:54 +0000 (08:55 +0000)]
Merge "Fix use of preg_match_all in MagicWord.php"
Michał Roszka [Thu, 20 Aug 2015 06:20:30 +0000 (08:20 +0200)]
Use User::equals() where applicable in the class
It is a minor cleanup operation. I replaced a comparison of user 'mId'
with a corresponding 'User::equals()' call.
Change-Id: I89dea55789f343e794429c38934c263168ef608d
jenkins-bot [Fri, 18 Sep 2015 08:46:56 +0000 (08:46 +0000)]
Merge "Remove dead local var in MssqlInstaller"
Kevin Israel [Fri, 18 Sep 2015 06:40:44 +0000 (02:40 -0400)]
Database: Remove unused errorCount() method
Also removed the protected $mErrorCount property used by this method.
Also removed DatabaseOracle::reportQueryError(). After removing its use
of $mErrorCount and applying relevant changes from
419221e4a71b ("Fixed
bug where catching DB errors left ignoreErrors() on"), the only effect
would be that, like for the other DB types, query errors would be
logged using wfLogDBError().
Change-Id: Ie26a5f5ef7dc5619d9db38d3eb6b7af3e6592aff
jenkins-bot [Fri, 18 Sep 2015 07:14:43 +0000 (07:14 +0000)]
Merge "HttpError: Convert line breaks in text message to <br>"
jenkins-bot [Fri, 18 Sep 2015 06:31:33 +0000 (06:31 +0000)]
Merge "API: Finish killing "raw mode""
jenkins-bot [Fri, 18 Sep 2015 06:30:08 +0000 (06:30 +0000)]
Merge "Small cleanups to WANObjectCache"
jenkins-bot [Fri, 18 Sep 2015 01:39:13 +0000 (01:39 +0000)]
Merge "Extend Title check in Skin for titles without associated titles"
Translation updater bot [Thu, 17 Sep 2015 20:16:37 +0000 (22:16 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I7269d03a73a9afa677d08dc517da608328932c18
Fomafix [Thu, 17 Sep 2015 05:35:29 +0000 (05:35 +0000)]
Load the module mediawiki.page.watch.ajax only when needed
Load the module mediawiki.page.watch.ajax only when there is
a watch button on the page.
This change uses the same checks as buildContentNavigationUrls() in SkinTemplate.php.
Also combine two if checks.
Bug: T112523
Change-Id: I78895ffea1290f8c1d90630851d0d3d443800d66
jenkins-bot [Thu, 17 Sep 2015 19:46:11 +0000 (19:46 +0000)]
Merge "ResourcesTest: Detect missing files in url(...) expressions"
Aaron Schulz [Thu, 17 Sep 2015 18:28:53 +0000 (11:28 -0700)]
Avoid unneeded memcached queries in showPatrolFooter()
Change-Id: I395019e85cbc80df7d77183ccb75b3691949efc6
jenkins-bot [Thu, 17 Sep 2015 18:46:52 +0000 (18:46 +0000)]
Merge "Guard "NotPatrollablePage" negative caching against slave lag"
Marius Hoch [Wed, 29 Jul 2015 18:23:09 +0000 (20:23 +0200)]
Guard "NotPatrollablePage" negative caching against slave lag
After some poking I'm fairly sure this is why pages get
"unpatrollable".
Bug: T100986
Change-Id: I137b25ec0538dcc7ad8b6f1b32d5103fd256462c
Aaron Schulz [Thu, 17 Sep 2015 18:00:23 +0000 (11:00 -0700)]
Small cleanups to WANObjectCache
* Added a few comments
* Renamed $locked => $lockAcquired for clarity
Change-Id: I45710974971731205d072a1f4b0f9cb37e2cb2a2
Kunal Mehta [Thu, 17 Sep 2015 17:28:38 +0000 (10:28 -0700)]
registration: Fix merging of array_plus
We want the local configuration ($GLOBALS[$key]) to override the default
values ($val). This matches what `array_merge` does.
Bug: T112868
Change-Id: I9c333a1fa67d3f24e09ffed3072b2897389f6139
jenkins-bot [Thu, 17 Sep 2015 16:46:56 +0000 (16:46 +0000)]
Merge "mw.widgets.CalendarWidget: Simplify the logic for deciding animations"
jenkins-bot [Thu, 17 Sep 2015 16:21:15 +0000 (16:21 +0000)]
Merge "mw.widgets.DateInputWidget: Ensure newly opened calendar shows current selection"
jenkins-bot [Thu, 17 Sep 2015 15:28:10 +0000 (15:28 +0000)]
Merge "Make feedlink icon visible by setting a size"
Brad Jorsch [Mon, 20 Apr 2015 18:58:55 +0000 (14:58 -0400)]
API: Finish killing "raw mode"
It was kept around in the ApiResult rewrite because Wikibase was
(mis)using it as an "XML mode" flag.
Bug: T96596
Change-Id: Ic8259649c8cb0cce0444c907607c36d96fb2eb7e
Antoine Musso [Wed, 8 Jul 2015 16:32:53 +0000 (18:32 +0200)]
Browser test: avoid loading elements over network
Page object let us search elements for which attributes match a given
regex. Unfortunatly it loads the list of elements first, then foreach
of them trigger a call to Selenium to retrieve the attribute to match.
Attempting to regex match a link href, would cause hundred of roundtrip
to the Selenium host.
Instead, use a CSS selector to get the element we are interested in
which skips the bad page object code.
Bug: T92613
Bug: T112291
Change-Id: I12949a4d0ef61d38adbaaf622722c89033949cad
jenkins-bot [Thu, 17 Sep 2015 06:48:24 +0000 (06:48 +0000)]
Merge "Add line breaks between label and value in "Username" and "Password""
jenkins-bot [Thu, 17 Sep 2015 06:16:35 +0000 (06:16 +0000)]
Merge "Drop zh-tw message "saveprefs""
Liangent [Wed, 16 Sep 2015 23:32:29 +0000 (23:32 +0000)]
Drop zh-tw message "saveprefs"
Change-Id: I4b0da9f17e77a9a0d7af7522d7cb59d8891246f7
Translation updater bot [Wed, 16 Sep 2015 20:20:29 +0000 (22:20 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Id35e5c6fd7a706cc76e88d9181edb8f39a3ac201
umherirrender [Wed, 16 Sep 2015 19:46:19 +0000 (21:46 +0200)]
Make feedlink icon visible by setting a size
Also avoid repeat and adding the necessary padding to give place for the
icon before the label.
Follows I1e47b626fa937066823f056aec6fbc0205fdb9b6,
Iabaebe9bf1e11a06bb951769693b1be4404e5b00 and
Ife5d84fb95944cb24939936785f3d8c4d9c2c187
Change-Id: Iaf8882142b58f2c793d9f8692a9d4051460c7144
jenkins-bot [Wed, 16 Sep 2015 18:57:55 +0000 (18:57 +0000)]
Merge "Move query rewriting into search backend"
Timo Tijhof [Wed, 16 Sep 2015 17:22:35 +0000 (18:22 +0100)]
HttpError: Convert line breaks in text message to <br>
Used by MediaWiki::tryNormaliseRedirect() for example with plain text
containing line breaks.
Change-Id: I5949046af4065c5536080212b96374466849b91a
Alex Monk [Tue, 15 Sep 2015 22:38:15 +0000 (23:38 +0100)]
Purge remaining oversight references from code
i18n change coming in a separate commit
Change-Id: I46b9311cd01e95e524587ce40dcbae62f58dc5a8
Amir E. Aharoni [Fri, 7 Aug 2015 14:18:59 +0000 (17:18 +0300)]
Add line breaks between label and value in "Username" and "Password"
This is supposed to separate the label from the value,
which is needed to avoid messing it up in RTL languages.
Bug: T108321
Change-Id: Idde5841c1099e171cd911cc25fb1771eda885723
jeroendedauw [Wed, 16 Sep 2015 14:54:25 +0000 (16:54 +0200)]
Remove dead local var in MssqlInstaller
Change-Id: I209166eab10b870de3d31ac1e551fd759459243a
Bartosz Dziewoński [Wed, 16 Sep 2015 16:44:10 +0000 (18:44 +0200)]
mw.widgets.CalendarWidget: Simplify the logic for deciding animations
It's all in one place now.
Change-Id: Ie8831775c1110bbcbb0ee4b84211c3df1c6b3e72
Bartosz Dziewoński [Wed, 16 Sep 2015 16:45:22 +0000 (18:45 +0200)]
mw.widgets.DateInputWidget: Ensure newly opened calendar shows current selection
CalendarWidget's #resetUI method was previously unused, it was clearly
implemented for this purpose.
Change-Id: I865a289b331d6163fb56f9e0ec3918cfd2b91343
jenkins-bot [Wed, 16 Sep 2015 17:43:04 +0000 (17:43 +0000)]
Merge "Add missing argument to dieDebug call so it does not die"
jenkins-bot [Wed, 16 Sep 2015 17:41:27 +0000 (17:41 +0000)]
Merge "Remove dead local vars in ApiRevisionDelete"
Aaron Schulz [Thu, 10 Sep 2015 22:47:54 +0000 (15:47 -0700)]
Avoid master queries on image history view
* The path that needs READ_LATEST already calls load() as needed first
Bug: T92357
Change-Id: Ia06bba6c2853823add2e527bb1b013b64d3f020a
jenkins-bot [Wed, 16 Sep 2015 17:20:26 +0000 (17:20 +0000)]
Merge "Moved some WANObjectCache number literals to constants"
Aaron Schulz [Wed, 16 Sep 2015 17:05:54 +0000 (10:05 -0700)]
Moved some WANObjectCache number literals to constants
Change-Id: I848440408b54c1dfd4961c15cc83aad9a1a19425
jeroendedauw [Wed, 16 Sep 2015 11:39:21 +0000 (13:39 +0200)]
Remove dead argument in EncryptedPassword.php
Change-Id: Ib0bb2733284262c233e6de4c7645f0b215690156
jenkins-bot [Wed, 16 Sep 2015 17:02:57 +0000 (17:02 +0000)]
Merge "FauxRequest: Avoid header leak"
umherirrender [Wed, 16 Sep 2015 16:35:37 +0000 (18:35 +0200)]
FauxRequest: Avoid header leak
Actually override initHeaders to avoid init of the header, if no header
was set.
The tests was taken from I4c06369968e.
Follows-up
578a0c082f.
Change-Id: I86b2a9bae2f5938374fd9e5e46997c3fdfe87e39
jeroendedauw [Wed, 16 Sep 2015 11:40:11 +0000 (13:40 +0200)]
Remove dead argument in SpecialEditTags
Change-Id: Idba1fd203e5616774a46e36b42fc124062261bee
jeroendedauw [Mon, 7 Sep 2015 19:21:24 +0000 (21:21 +0200)]
Remove commented out code in SpecialExport
The removed code was about exporting/importing image information,
which is not possible at the moment, but also nobody seems to work on this.
Change-Id: Ie10d3bc23454ca797f41bd12c4e05360233978a2
jenkins-bot [Wed, 16 Sep 2015 16:38:01 +0000 (16:38 +0000)]
Merge "Add '@since 1.25' annotation to wfLoad*() functions"
Florian [Wed, 16 Sep 2015 15:50:56 +0000 (17:50 +0200)]
Extend Title check in Skin for titles without associated titles
Like talk or the subject title (for a talk title). This prevents Skin.php
from trying to get the talk title of a title in a namespace that can't hold
any.
Follow up:
https://www.mediawiki.org/wiki/Special:Code/MediaWiki/80409
Bug: T110878
Change-Id: I3c803d784f931a21b47065590e567f8bb111aa2a
jeroendedauw [Wed, 16 Sep 2015 14:53:18 +0000 (16:53 +0200)]
resourceloader: Add missing argument to makeLoaderImplementScript
Change-Id: I661ec86ab53639be6999e15ac20c726477fae8a5
jeroendedauw [Wed, 16 Sep 2015 14:58:03 +0000 (16:58 +0200)]
Remove dead local vars in ApiRevisionDelete
Change-Id: I9c5ab515e9c95402e73423d4aa8632d57660bdff
jeroendedauw [Wed, 16 Sep 2015 14:52:39 +0000 (16:52 +0200)]
Add missing argument to dieDebug call so it does not die
Change-Id: I672f4f1a407b35bf88216508156035ef96a7289f
Bartosz Dziewoński [Wed, 16 Sep 2015 13:55:13 +0000 (15:55 +0200)]
Add '@since 1.25' annotation to wfLoad*() functions
Change-Id: I2cf9c2eddaa8b3449bd2852c496515b5bc133981
Bartosz Dziewoński [Wed, 16 Sep 2015 12:30:59 +0000 (14:30 +0200)]
mediawiki.Title: Correct documentation
Follow-up to
a074db332cc103319adacabcc52b1f615217e222, which removed a
config option but not its documentation entry.
Change-Id: I3a0596b27da9e36eb2bb718a635130341545abab
jeroendedauw [Mon, 7 Sep 2015 18:37:57 +0000 (20:37 +0200)]
Make MWExceptionHandler work with PHP7's exception changes
See https://wiki.php.net/rfc/throwable-interface
Bug: T107933
Change-Id: I703c8710c8adeff14c1cbaab89f5688f6cb96c24
jenkins-bot [Wed, 16 Sep 2015 11:00:33 +0000 (11:00 +0000)]
Merge "When aborting EnhancedRC block line, block should reflect that"
Matthias Mullie [Wed, 16 Sep 2015 10:44:04 +0000 (10:44 +0000)]
When aborting EnhancedRC block line, block should reflect that
It was possible to abort the rendering of all block lines, but
the block would still be rendered (with nothing inside). It
would also render a "x changes" link, even though that "x" is
no longer correct.
This had been reverted in
adba11dfe332c4c10dbbf0f817982d4a225de6b1,
but has now been fixed up.
Change-Id: Ic5d15e56bc2f46fa6aa8c9375f3cafeb13e1ea9c
jenkins-bot [Wed, 16 Sep 2015 10:12:02 +0000 (10:12 +0000)]
Merge "Revert "When aborting EnhancedRC block line, block should reflect that""
Catrope [Wed, 16 Sep 2015 09:56:29 +0000 (09:56 +0000)]
Revert "When aborting EnhancedRC block line, block should reflect that"
Caused errors when there were two new topics created on the
same Flow board on the same day.
BadMethodCallException from line 496 of
/srv/mediawiki/php-1.26wmf23/includes/changes/EnhancedChangesList.php:
Call to a member function getTitle() on a non-object (NULL)
{"exception_id":"
58b04b8c"}
This reverts commit
b30417048bb4b6b785ecae4a8b90aa1f452c4412.
Bug: T112738
Change-Id: Ib404d78eaf1aa9ac7ea34516183bcc9956efc515
jenkins-bot [Wed, 16 Sep 2015 06:21:47 +0000 (06:21 +0000)]
Merge "mediawiki.Title: Remove fileExtension option from newFromFileName"
Timo Tijhof [Sat, 12 Sep 2015 05:45:00 +0000 (06:45 +0100)]
mediawiki.Title: Remove fileExtension option from newFromFileName
Follows-up
cc8b00ed5b,
55a4946533.
Has confusing behaviour and is not used anywhere in Wikimedia Git,
nor in on-wiki scripts.
Change-Id: Ibc1a821df93fab67856d025cf6671f41efdaebb1
Timo Tijhof [Tue, 15 Sep 2015 18:35:13 +0000 (19:35 +0100)]
resourceloader: Don't localise hidden exception
Mechanical stacktraces are mostly program identifiers (which are English) with some
glue text.
When stacktraces are disabled by the site admin, the replacement message doesn't
seem valuable to localise. And one could argue it should be in the user language
instead of the site language in that case, which complicates the output buffer
and caching layers for this.
It also reduces coupling with MediaWiki (Ref T32956).
Change-Id: If446f1b815add2be4baf1c333f18a4bab0cc9c37
Bartosz Dziewoński [Thu, 3 Sep 2015 21:30:36 +0000 (23:30 +0200)]
ResourcesTest: Detect missing files in url(...) expressions
The way this is implemented is really dirty... but it found us
a few pre-existing bugs already (T111518, T111519, T111771).
I think it might be worth it.
* CSSMin: Add new method getAllLocalFileReferences() which skips the
file_exists() check.
* ResourceLoaderModule: Make use of it to track missing files too.
* ResourcesTest: Verify that the missing files are missing.
Change-Id: I5a3cdeb7d53485f161ccf8133e76850cdf5b4579
Timo Tijhof [Tue, 15 Sep 2015 23:51:18 +0000 (00:51 +0100)]
resourceloader: Support absolute-path references in mw.loader.load()
Follows-up
b5e69c4ef621 which made loader sources no longer expanded urls.
Change-Id: Ia2fcd13f46d548a98620c3e78b8f59b81d976eb4
jenkins-bot [Tue, 15 Sep 2015 23:25:38 +0000 (23:25 +0000)]
Merge "resourceloader: Don't call wfExpandUrl() on load.php urls"
jenkins-bot [Tue, 15 Sep 2015 22:40:01 +0000 (22:40 +0000)]
Merge "SpecialMovepage: Convert form to use OOUI controls"
Timo Tijhof [Tue, 15 Sep 2015 20:21:04 +0000 (21:21 +0100)]
resourceloader: Don't call wfExpandUrl() on load.php urls
wfExpandUrl() should only be used if the url needs to be absolute
and/or needs to point to the canonical, internal or default wgServer
for the wiki.
For meta-data or API responses this can make sense, but for resources
loaded by the browser from the current page, there is no added value
in expanding these to the default domain.
This is causing problems in custom setups such as at Wikimedia,
with "zero" and "m" sub domains for which $wgServer points to the
canonical domain.
Bug: T106966
Bug: T112646
Change-Id: Ie25d3a8f69564319a1b29b5c5904f3d352924a31