Antoine Musso [Sat, 19 Nov 2011 16:31:42 +0000 (16:31 +0000)]
closing a store is only available for CDB type
follow up r103684
Sam Reed [Sat, 19 Nov 2011 16:26:28 +0000 (16:26 +0000)]
* (bug 32470) Increase the length of ug_group
Postgres doesn't need extending...
Antoine Musso [Sat, 19 Nov 2011 16:23:52 +0000 (16:23 +0000)]
add possibility to close a LCStore_CDB
also close an LCStore_CDB after checking for expiry
Sam Reed [Sat, 19 Nov 2011 16:19:35 +0000 (16:19 +0000)]
Global tables died
Roan Kattouw [Sat, 19 Nov 2011 16:02:26 +0000 (16:02 +0000)]
Make ResourceLoader::register() non-recursive, was calling itself recursively on every page load.
Raimond Spekking [Sat, 19 Nov 2011 14:32:52 +0000 (14:32 +0000)]
Localisation update for core and extension messages from translatewiki.net
Derk-Jan Hartman [Sat, 19 Nov 2011 14:32:45 +0000 (14:32 +0000)]
Fixes broken alignment of catlinks in cologneblue and simple skins.
Follow up to r102297
Fixes bug 32460
Daniel Friesen [Sat, 19 Nov 2011 14:14:57 +0000 (14:14 +0000)]
Incorporate a router into our maintenance/dev/ code to better handle the variety of file types we support.
Derk-Jan Hartman [Sat, 19 Nov 2011 14:09:58 +0000 (14:09 +0000)]
Fix the sitesub of cologneblue. Follow up to r80785
Derk-Jan Hartman [Sat, 19 Nov 2011 13:48:02 +0000 (13:48 +0000)]
Fix an issue with the header of CologneBlue. Introduced in r97657
Fixes bug 32474
Antoine Musso [Sat, 19 Nov 2011 11:42:25 +0000 (11:42 +0000)]
bug 32086 get fixed in 1.18 not 1.18
r101478 did not get merged in 1.18
Alexandre Emsenhuber [Sat, 19 Nov 2011 09:44:03 +0000 (09:44 +0000)]
* Use local context to get messages
* Escape 'word-separator' and 'parentheses' messages
Alexandre Emsenhuber [Sat, 19 Nov 2011 08:54:03 +0000 (08:54 +0000)]
Use ParserOptions::newFromContext() instead of 'new ParserOptions' to use the local context instead of relying on $wgUser and $wgLang
Alexandre Emsenhuber [Sat, 19 Nov 2011 08:51:20 +0000 (08:51 +0000)]
Use WikiPage instead of Article
Alexandre Emsenhuber [Sat, 19 Nov 2011 08:29:49 +0000 (08:29 +0000)]
Follow-up r103332: fix "invalidoldimage" error message to say "oldimage" instead of "oldid"
Aaron Schulz [Sat, 19 Nov 2011 05:37:24 +0000 (05:37 +0000)]
Made ChangesList generate page links with rcid=x for new pages when $wgUseNPPatrol is on (not just $wgUseRCPatrol)
Robin Pepermans [Sat, 19 Nov 2011 05:18:32 +0000 (05:18 +0000)]
Make $wgDummyLanguageCodes an associative array so it maps to the correct codes; and use it in WikimediaIncubator to check whether the wiki exists (so e.g. Wx/sgs recognizes that the wiki corresponding to Wx/bat-smg exists). The extension is compatible with the old $wgDummyLanguageCodes array.
gicode [Sat, 19 Nov 2011 02:53:37 +0000 (02:53 +0000)]
Don't force a localization cache rebuild if it will be handled automatically.
Alexandre Emsenhuber [Fri, 18 Nov 2011 21:36:57 +0000 (21:36 +0000)]
* Use ParserOptions::newFromContext() to not depend on $wgUser and $wgLang
* Use a WikiPage object instead of Article to get the text or the ParserOutput and create the object directly in getParsedSectionOrText()
* Use Title::getLatestRevID() instead of Article::getRevIdFetched() since the latter will always return the current revision ID when 0 is passed as second parameter to the constructor
* Pass the User object to Revision::getText()
* Removed double setting of $wgTitle
Raimond Spekking [Fri, 18 Nov 2011 14:57:27 +0000 (14:57 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Ariel Glenn [Fri, 18 Nov 2011 09:08:29 +0000 (09:08 +0000)]
followup to r103448, tighten up code
Alexandre Emsenhuber [Fri, 18 Nov 2011 07:10:03 +0000 (07:10 +0000)]
Fix for r103502: make PoolWorkArticleView::doWork() return true when the parse is successful; also fixed getIsDirty() to return the member parameter and not try to execute a non-existing function
Raimond Spekking [Thu, 17 Nov 2011 22:50:20 +0000 (22:50 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Alexandre Emsenhuber [Thu, 17 Nov 2011 20:30:28 +0000 (20:30 +0000)]
Use local context to get messages
Alexandre Emsenhuber [Thu, 17 Nov 2011 20:21:54 +0000 (20:21 +0000)]
* Added WikiPage::getParserOutput() and changed Article::getParserOutput() to use it
* WikiPage::getParserOutput() requires a ParserOptions object (and optionally the revision ID) instead of an User object, removes an hidden dependency on $wgLang. For this reason, WikiPage::isParserCacheUsed() now also uses a ParserOptions object instead of an User object (doesn't change anything in the code except the variable name and it's not called in extensions)
* Moved PoolWorkArticleView to WikiPage.php and added an entry in the AutoLoader and moved output-related stuff directly in Article::view() so that in can be shared with WikiPage::getParserOutput() (removes code duplication, etc.)
* Added the revision ID to the PoolCounter key so that it knows which revision is being parsed and doesn't wait for another parse operation with same options but different revisions
* Removed Article::doViewParse(), Article::tryDirtyCache() and Article::getOutputFromWikitext() since they are now integrated in PoolWorkArticleView and Article::view() and there are no callers in extensions. This also fixes a bug since Article::doViewParse() will get another ParserOptions instance with special options set in Article::view() not be repercuted.
* Updated DifferenceEngine to use the new system
* Updated docs/memcached.txt to correct method names
Sam Reed [Thu, 17 Nov 2011 19:06:30 +0000 (19:06 +0000)]
Fix the rest of 'inlanguage ' in r93765
Sam Reed [Thu, 17 Nov 2011 19:00:09 +0000 (19:00 +0000)]
Fix trailing space in r93765
Antoine Musso [Thu, 17 Nov 2011 16:46:45 +0000 (16:46 +0000)]
(bug 32450) MediaWiki: .js|.css pages parsed [[Category:#]] links
This patch skip the [[Category:#]] parsing logic when the Title is in
NS_MEDIAWIKI and ends with .js or .css. This way the code is kept as is
and pages are no more categorized.
How to reproduce the issue:
$ echo 'var foo = "[[Category:bug32450]]"' \
| php maintenance/parse.php --title MediaWiki:Foobar.js
<p>var foo = ""
</p>
$
Note how the text got stripped.
After this patch:
$ echo 'var foo = "[[Category:bug32450]]"' \
| php maintenance/parse.php --title MediaWiki:Foobar.js
<p>var foo = "[[Category:bug32450]]"
</p>
$
TEST PLAN:
==========
$ php parserTests.php --quiet
This is MediaWiki version 1.19alpha (r103473).
Reading tests from "tests/parser/parserTests.txt"...
Reading tests from "tests/parser/extraParserTests.txt"...
Passed 654 of 654 tests (100%)... ALL TESTS PASSED!
$
Mark A. Hershberger [Thu, 17 Nov 2011 16:00:41 +0000 (16:00 +0000)]
Apply cryptocoryne's patch from Bug 32454 - ArticlePurge hook is broken after r86041
Mark A. Hershberger [Thu, 17 Nov 2011 15:16:03 +0000 (15:16 +0000)]
Adapt and re-apply Michael Newton's patch from Bug 24464 - Execute
LoginAuthenticateAudit hook more often.
Also updated release notes.
Antoine Musso [Thu, 17 Nov 2011 14:46:17 +0000 (14:46 +0000)]
use spaces for usage indentation
Alexandre Emsenhuber [Thu, 17 Nov 2011 10:33:20 +0000 (10:33 +0000)]
* Use the fact that WikiPage::getLatest() is updated when editing the page since r103383
* Moved override of $wgTitle and creation of EditPage object to the place they will be used
Antoine Musso [Thu, 17 Nov 2011 10:10:40 +0000 (10:10 +0000)]
skip Media: links in addition to Special: links
That one triggered an exception stack trace when using Media:foo as
a target on Special:WhatLinksHere.
Example:
Special:WhatLinksHere/Media:file.png
That is a rare occurence that "should not happen". I am not sure it is
worth backporting to 1.18 although it impacts live site:
http://en.wikipedia.org/wiki/Special:WhatLinksHere/Media:BSicon_uBS2lf.svg
Alexandre Emsenhuber [Thu, 17 Nov 2011 10:06:56 +0000 (10:06 +0000)]
* Removed Preferences::validateEmail() to that e-mail address modification is in another special page, no callers
* Added $form parameter to Preferences::cleanSignature() and Preferences::validateSignature(), they are passed to the functions since r102879
* Use local context to get messages
Ariel Glenn [Thu, 17 Nov 2011 09:20:51 +0000 (09:20 +0000)]
if user id is 0 and username is actually an IP, write it as <ip>, not <username>
Siebrand Mazeland [Thu, 17 Nov 2011 04:43:41 +0000 (04:43 +0000)]
Put $fallback back that was accidentally removed in r96692. Spotted by Merlissimo.
Cannot explain how this happened.
Siebrand Mazeland [Thu, 17 Nov 2011 03:28:48 +0000 (03:28 +0000)]
Follow-up r103437: fix typo and add quotes.
Aaron Schulz [Thu, 17 Nov 2011 03:14:05 +0000 (03:14 +0000)]
Documentation
Siebrand Mazeland [Thu, 17 Nov 2011 03:13:33 +0000 (03:13 +0000)]
Tweak message updated in r103386.
Brian Wolff [Wed, 16 Nov 2011 23:55:40 +0000 (23:55 +0000)]
revert r103396 (breaks unit tests) - In lots of these places $u is undefined (for example, of a user doesn't specify a name, we havn't created a user object yet at the time of that check). Probably need to do something like create a second hook for loginAuditUserTotallyFailed or something.
Aaron Schulz [Wed, 16 Nov 2011 22:55:48 +0000 (22:55 +0000)]
Moved File classes to filerepo/file (as well as ArchivedFile)
Aaron Schulz [Wed, 16 Nov 2011 22:33:34 +0000 (22:33 +0000)]
Fixed comment typo
Mark A. Hershberger [Wed, 16 Nov 2011 22:24:03 +0000 (22:24 +0000)]
Applying Michael Newton's patch from Bug 24464 - Execute
LoginAuthenticateAudit hook more often
Tested and it *seems* reasonable to me.
Mark A. Hershberger [Wed, 16 Nov 2011 21:43:32 +0000 (21:43 +0000)]
Apply patch from Bug 17056 - list items in Special:NewPages should
each link to the first revision of the page
Patch from Umherirrender
Mark A. Hershberger [Wed, 16 Nov 2011 21:25:31 +0000 (21:25 +0000)]
Apply jdanni's patch from from 2+ years ago for Bug 15218 - LinkSearch results should use as much of the path as is provided, not simply search by domain
Patch only updates the messages.
Alexandre Emsenhuber [Wed, 16 Nov 2011 21:03:06 +0000 (21:03 +0000)]
* Put the LinkCache update in WikiPage::updateRevisionOn() so that we are sure that it is executed every time that function get called (and the update succeeds of course); and removed the call to Title::resetArticleID() which is already done by insertOn()
* Also update $this->mLatest and $this->mIsRedirect in updateRevisionOn() (will use this in ApiEditPage to have to create another istance just to grab the new revision ID)
* In WikiPage::doEdit(), get the current latest before going through the process since it's now updated in updateRevisionOn() (would break RecentChange::notifyEdit() otherwise) and pass the current redirect state to use the optimisation in updateRedirectOn() if possible
Alexandre Emsenhuber [Wed, 16 Nov 2011 20:54:40 +0000 (20:54 +0000)]
Per Aaron, fix for r102973: create directly a WikiFilePage object and call setFile() on it to restore previous behaviour
Aaron Schulz [Wed, 16 Nov 2011 20:38:24 +0000 (20:38 +0000)]
Fixed totally broken --file parameter (running the sha1 for one file)
Raimond Spekking [Wed, 16 Nov 2011 20:05:35 +0000 (20:05 +0000)]
Localisation updates for core and extension messages from translatewiki.net
OverlordQ [Wed, 16 Nov 2011 19:55:21 +0000 (19:55 +0000)]
Followup to r103365, actually include said patch file
OverlordQ [Wed, 16 Nov 2011 19:54:38 +0000 (19:54 +0000)]
Followup to r100640, use correct name scheme for sequence, correct references to sequence and add optional patch file for sites following trunk
Brian Wolff [Wed, 16 Nov 2011 19:50:59 +0000 (19:50 +0000)]
(bug 31535; bug 332) Properly truncate upload summaries (img_description) on the php side.
Before it would get truncated when inserted into the 255 byte db field. This is bad as it can leave dangling multi-byte unicode sequences, additionally, since directly after upload we appearently cache the file object, this can result in the comment in the file history table being super-huge.
This also removes the parenthesis in the comment field in the table. Its a table, we don't need to use () to visually separate it from the rest of the page content.
This commit also causes '...' (or the i18n'ed equivalent) to be appended when truncated a comment. Previously that didn't happen. Also I changed it to use a method that doesn't check for '*' as a special value to mean no description. I looked at the toolserver db, and even uploads to enwikipedia from 2002 don't use '*' as special no-description marker.
Raimond Spekking [Wed, 16 Nov 2011 19:03:43 +0000 (19:03 +0000)]
Register new message key from r103314 for maintenance scripts
Sam Reed [Wed, 16 Nov 2011 16:59:21 +0000 (16:59 +0000)]
Fix extension URL
Platonides [Wed, 16 Nov 2011 16:53:12 +0000 (16:53 +0000)]
On errors not using OutputPage, Content-Type header wasn't set,
although we output localised UTF-8 messaged.
Alexandre Emsenhuber [Wed, 16 Nov 2011 15:57:56 +0000 (15:57 +0000)]
* Use WikiPage instead of Article
* Create the WikiPage object directly in execute() and pass it to both delete() and deleteFile()
* Reordered parameters of delete() and deleteFile() to be consistent and take both on the WikiPage and User objects (instead of relying on $wgUser); no callers outside of this class
* Fixed deleteFile() to match the behaviour of FileDeleteForm with oldimage parameter
* Pass the User object to getPermissionsError()
* Factorised duplicated code
* Added missing error code to ApiBase (and also a new one)
* Added missing possible error codes (with a new one too)
Max Semenik [Wed, 16 Nov 2011 15:21:44 +0000 (15:21 +0000)]
Follow-up r101449 and friends: no need to consider LC rebuild a database update and especially it shouldn't be listed separately for every DB updater
Antoine Musso [Wed, 16 Nov 2011 15:12:00 +0000 (15:12 +0000)]
bug 28643 improvement to serbian variants conversion
This patch is a PARTIAL merge of /branches/nikola/phase3 ::
r85224 avoid double conversion when text already use the correct variant
r85239 minor fixes to previous
r85308 documentation (@since 1.18 update to 1.19)
r101359 guessVariant doc + boolean typecast
r101369 tests
r103131 additional test
Test plan:
==========
$ ./phpunit.php --filter LanguageSr
PHPUnit 3.6.3 by Sebastian Bergmann.
Configuration read from /srv/trunk/tests/phpunit/suite.xml
.....
Time: 1 second, Memory: 78.50Mb
OK (5 tests, 19 assertions)
$
Sam Reed [Wed, 16 Nov 2011 13:22:03 +0000 (13:22 +0000)]
Comments, braces, explicit member variables
Remove a couple of unused variables
Sam Reed [Wed, 16 Nov 2011 13:18:00 +0000 (13:18 +0000)]
Trim some long lines. Add fullstops
Alexandre Emsenhuber [Wed, 16 Nov 2011 13:17:53 +0000 (13:17 +0000)]
Follow-up r103202: removed unused global declaration
Sam Reed [Wed, 16 Nov 2011 13:00:56 +0000 (13:00 +0000)]
Fill up, and synchronise RELEASE-NOTES-1.18
Ariel Glenn [Wed, 16 Nov 2011 12:01:58 +0000 (12:01 +0000)]
add checkbox for listauthors on export form if wgExportAllowListContributors set
Roan Kattouw [Wed, 16 Nov 2011 10:37:27 +0000 (10:37 +0000)]
Clarify comment in r103019
John Du Hart [Wed, 16 Nov 2011 04:39:21 +0000 (04:39 +0000)]
Followup r103294, remove a space that got added on the end of the method
John Du Hart [Wed, 16 Nov 2011 04:37:17 +0000 (04:37 +0000)]
Following r100264, update usages in core
John Du Hart [Wed, 16 Nov 2011 00:17:26 +0000 (00:17 +0000)]
Removed the 'eclipse helper' bit on top of every API module
It's a parctice that dates back to 2006 when the API was first written, and frankly isn't covered by the coding conventions. Same thing with the docblocks, they're all copypasted with some bits changed and don't even make sense if you look at them in the genereated code docs.
I don't feel that any of us depend on this anymore (get a better IDE), so in the inerest of consistancy it's time we said goodbye to it.
Alexandre Emsenhuber [Tue, 15 Nov 2011 21:46:05 +0000 (21:46 +0000)]
Deprecated WikiPage::preSaveTransform() in favour of Parser::preSaveTransform() and updated callers; added wfDeprecated() call since there are no callers in extensions
Aaron Schulz [Tue, 15 Nov 2011 19:41:32 +0000 (19:41 +0000)]
Added Article::newFromWikiPage() function to create an appropriate Article object from a WikiPage and keep the process cache vars of the later
gicode [Tue, 15 Nov 2011 18:53:20 +0000 (18:53 +0000)]
Make wfExpandUrl use wfRemoveDotSegments on the resulting path. This finishes
off bug 32168.
Also follow-up r103199 (related) to use isset.
Alexandre Emsenhuber [Tue, 15 Nov 2011 18:28:26 +0000 (18:28 +0000)]
Removed useless constructor, just use parent's one which is identical
Alexandre Emsenhuber [Tue, 15 Nov 2011 18:26:05 +0000 (18:26 +0000)]
Moved read only check after permissions and block so that the user doesn't think the error is temporary in case he doesn't have the permission and the database is in read only mode
Alexandre Emsenhuber [Tue, 15 Nov 2011 18:08:34 +0000 (18:08 +0000)]
* Factorise common code in ImagePage::delete() and allow normal page deletion if $wgUploadMaintenance is true
* Moved $wgUploadMaintenance check after permissions and read only, so that the user doesn't think the error is temporary if he both doesn't have the permission and $wgUploadMaintenance is true
* Show normal error page when $wgUploadMaintenance and added a message for the error title
* Moved watchlist updating to FileDeletForm::execute(), it has nothing to do in doDelete() (would also be executed for api requests, etc.)
* Added $user parameter to FileDeletForm::doDelete() to pass the user doing the action
* Use WikiPage instead of Article
gicode [Tue, 15 Nov 2011 17:38:20 +0000 (17:38 +0000)]
Add wfAssembleUrl and unit tests. This is the next step towards fixing
bug 32168. This function is the inverse of wfParseUrl and is useful when you
need to modify part of a URL and have to put it back together.
Further, with the addition of this function, there is sufficient code in core
to create a proper URI class.
Platonides [Tue, 15 Nov 2011 16:35:52 +0000 (16:35 +0000)]
Fixup for r102997. If you add returns to a profiled function,
you should make sure to wfProfileOut on all branches.
Platonides [Tue, 15 Nov 2011 16:27:16 +0000 (16:27 +0000)]
Follow-up r103179: $handled variable undefined
Chad Horohoe [Tue, 15 Nov 2011 15:04:36 +0000 (15:04 +0000)]
Address fixme on r101644 (bug 32325, bug 32263), originally for bug 31822. PHP 5.2 below 5.2.7 throws a warning when you try to fopen() in append mode. Fixed by only fwrite()ing to STDIN|STDERR when in cli, use print otherwise (per Tim's suggestion).
People didn't seem to like the idea of bumping the minimum version to 5.2.7 since some distros like being behind the times.
Robin Pepermans [Tue, 15 Nov 2011 13:27:14 +0000 (13:27 +0000)]
The names for Kashmiri were in Urdu and Hindi. Change to native names per ks.wikipedia.org/wiki/User_talk:SPQRobin
Sam Reed [Tue, 15 Nov 2011 11:04:00 +0000 (11:04 +0000)]
Followup r102575, recreate export-0.6.xsd copied with export-0.5.xsd history
Sam Reed [Tue, 15 Nov 2011 11:02:21 +0000 (11:02 +0000)]
Followup r102575, delete export-0.6.xsd to create from a copy of export-0.5.xsd
Roan Kattouw [Tue, 15 Nov 2011 09:59:32 +0000 (09:59 +0000)]
(bug 32241) Fix flickering behavior in IE. Patch by Lupo. See also r102948
Santhosh Thottingal [Tue, 15 Nov 2011 04:28:34 +0000 (04:28 +0000)]
Follow up r102802. Bug 32359
Use negative sign itself instead of $_[0] since $_ is mixed type.
Add more test cases.
John Du Hart [Tue, 15 Nov 2011 02:42:07 +0000 (02:42 +0000)]
Fix for r102649
John Du Hart [Tue, 15 Nov 2011 02:25:36 +0000 (02:25 +0000)]
Convert SpecialBlock to subclass FormSpecialPage
Also fixes the problem introduced in r103115
Aaron Schulz [Tue, 15 Nov 2011 02:20:08 +0000 (02:20 +0000)]
Changed new LocalFilePurgeThumbnails hook arguments and updated wmf/swift.php to actually work for archived file thumbs.
John Du Hart [Tue, 15 Nov 2011 01:34:19 +0000 (01:34 +0000)]
Updated core SpecialPages to use new functions introduced in r103111 and r103095
John Du Hart [Tue, 15 Nov 2011 01:19:04 +0000 (01:19 +0000)]
Adding function for checking if the database is in readonly mode
Replacing some code in SpecialPageForm to use these new functions
John Du Hart [Tue, 15 Nov 2011 00:37:38 +0000 (00:37 +0000)]
Added function to SpecialPage to simplify permissions checking in SpecialPage classes.
Derk-Jan Hartman [Mon, 14 Nov 2011 23:28:48 +0000 (23:28 +0000)]
Make sure that the old insertTags of mediawiki.action.edit.js works with each textarea or text input field on a page.
Note. Using input:text, because input[type=text] doesn't return the input's with no type set.
This fixes bug 31682, where Extension:CharInsert wasn't working on upload pages anymore and
bug 31566, where Extension:Proofread's header and footer fields didn't work icw CharInsert
Daniel Friesen [Mon, 14 Nov 2011 21:57:36 +0000 (21:57 +0000)]
Add isset tests to stuff inside BaseTemplate::getToolbox.
Alexandre Emsenhuber [Mon, 14 Nov 2011 21:42:27 +0000 (21:42 +0000)]
Fix for r102997: forgot to change that variable
Raimond Spekking [Mon, 14 Nov 2011 21:39:03 +0000 (21:39 +0000)]
Localisation updates for core and extension messages from translatewiki.net
Sam Reed [Mon, 14 Nov 2011 21:14:31 +0000 (21:14 +0000)]
Reverts r102799, followsup r102800 also
Logged LoggedUpdateMaintenance did the inserting, the problem was the script was unconditionally run
Added some documentation tooo
Roan Kattouw [Mon, 14 Nov 2011 20:00:35 +0000 (20:00 +0000)]
(bug 19833) Make the searching-for-an-IP-means-you-want-Special:Contributions behavior configurable. Patch by Olivier Finlay Beaton
Roan Kattouw [Mon, 14 Nov 2011 19:44:13 +0000 (19:44 +0000)]
Remove commented-out variable ApiMain::$mRequest
Alexandre Emsenhuber [Mon, 14 Nov 2011 18:31:44 +0000 (18:31 +0000)]
Fix for r103001: using the object is actually a good idea
Alexandre Emsenhuber [Mon, 14 Nov 2011 18:28:01 +0000 (18:28 +0000)]
Update DifferenceEngine::renderNewRevision() to run the 'ArticleViewCustom' hook and create a WikiPage object and do "normal wikitext" processing only when really needed
Alexandre Emsenhuber [Mon, 14 Nov 2011 18:05:55 +0000 (18:05 +0000)]
Some cleanup to Article::view() and related:
* Moved the page check if oldid was given from Article::fetchContent() to Article::getOldidIDFromRequest() so that it's done directly when executing Article::view(); this should not happen though for normal view requests since oldid and related are checked in MediaWiki::parseTitle()
* Removed $oldid parameter from Article::fetchContent() and always use the oldid parameter passed either in the constructor or the request; also changed call from Article::loadContent() to Article::fromContent() since the former is now only a redirect to the latter
* Moved the 'read' permission check to the beginning of Article::view() since the Title is now correct directly after calling Article::getOldID()
* Merged the two calls to the parser cache and make WikiPage::isParserCacheUsed() also return true when the latest revision id is given. Article::setOldSubtitle() is still called when the oldid is passed to display the "You are view the current revision of this article".
* Also moved the non-existing page check a bit up to avoid running a good part of useless code when the page doesn't exist
* Merged two calls to Title::quickUserCan( 'edit' ) to set edit sections to false
Max Semenik [Mon, 14 Nov 2011 16:53:50 +0000 (16:53 +0000)]
find on Windows is incompatible with *nix
Roan Kattouw [Mon, 14 Nov 2011 14:40:55 +0000 (14:40 +0000)]
Followup r99224: add message to ApiBase::$messageMap too