Bartosz Dziewoński [Wed, 3 Aug 2016 00:13:01 +0000 (02:13 +0200)]
Introduce UploadStashFile hook, improve API handling of stash errors
UploadBase:
* Introduce a new method, tryStashFile(), as a replacement for the
now-soft-deprecated stashFile(). The method runs the new hook and
returns a Status object, with an error (if the hook returned an
error) or a value (if it didn't).
* Introduce a new hook, UploadStashFile, allowing extensions to
prevent a file from being stashed. Note that code in extensions
which has not been updated for MediaWiki 1.28 may still call
stashFile() directly, and therefore not call this hook. For
important checks (not just for UI), extension authors should use
UploadVerifyFile or UploadVerifyUpload hooks.
* Extract common code of tryStashFile() and stashFile() to
a new protected method doStashFile().
SpecialUpload:
* Use tryStashFile() when stashing a file after a warning or
"recoverable error" was encountered.
ApiUpload:
* Refactor stashing code so that error handling only happens in one
place, not four different ones. Use Status objects rather than
exception throwing/catching for control flow.
* Simplify the error messages slightly (error codes are unchanged).
Produce better ones by always using handleStashException().
'stashfailed' is now always at root (not nested inside 'warnings'),
behaving the same as 'filekey' does on success.
* Use tryStashFile() when stashing. Handle errors so as to allow
custom API results passed via ApiMessage to be preserved.
Some API result changes for different requests are shown below.
api.php?action=upload&format=json&filename=good.png&file=...&stash=1
Before:
{
"error": {
"code": "stashfilestorage",
"info": "Could not store upload in the stash: Stashing temporary file failed: UploadStashFileException Error storing file in '/tmp/phpB32SRT': Could not create directory \"mwstore://local-backend/local-temp/3/3a\".",
"*": "See http://localhost:3080/w/api.php for API usage"
}
}
After:
{
"error": {
"code": "stashfilestorage",
"info": "Could not store upload in the stash: Error storing file in '/tmp/phpB32SRT': Could not create directory \"mwstore://local-backend/local-temp/3/3a\".",
"*": "See http://localhost:3080/w/api.php for API usage"
}
}
api.php?action=upload&format=json&filename=[bad].png&file=...
Before:
{
"upload": {
"result": "Warning",
"warnings": {
"badfilename": "-bad-.png",
"stashfailed": "Stashing temporary file failed: UploadStashFileException Error storing file in '/tmp/phpB32SRT': Could not create directory \"mwstore://local-backend/local-temp/3/3a\"."
}
}
}
After:
{
"upload": {
"result": "Warning",
"stashfailed": "Could not store upload in the stash: Error storing file in '/tmp/phpB32SRT': Could not create directory \"mwstore://local-backend/local-temp/3/3a\"."
"warnings": {
"badfilename": "-bad-.png",
}
}
}
Bug: T140521
Change-Id: I2f574b355cd33b2e9fa7ff8e1793503b257cce65
Edward Chernenko [Tue, 9 Aug 2016 08:34:17 +0000 (11:34 +0300)]
Resources.php: mark "mediawiki.api.upload" module as 'targets' => [ 'desktop', 'mobile' ]
This module doesn't call anything desktop-specific.
There is no reason to deny this module to scripts which run on both desktop and mobile.
Change-Id: Ia6b778ca8a188688e2c0e813332aee03d3b5ac52
jenkins-bot [Tue, 9 Aug 2016 00:06:07 +0000 (00:06 +0000)]
Merge "jquery.tablesorter: Handle more than single characters in 'tableSorterCollation'"
Bartosz Dziewoński [Fri, 5 Aug 2016 18:01:17 +0000 (20:01 +0200)]
jquery.tablesorter: Handle more than single characters in 'tableSorterCollation'
The code that uses this will already work fine, we only need to change
how the regex is built.
Bug: T140240
Change-Id: I014d9b13815d8ae085a6ed7c6df2d62337bb46f7
Aaron Schulz [Mon, 8 Aug 2016 21:55:56 +0000 (14:55 -0700)]
Use MediaWikiServices in restInPeace() for load balancer factory
Change-Id: Icc12100bd3409900c848c72a31417a8c25ae1021
jenkins-bot [Mon, 8 Aug 2016 21:04:40 +0000 (21:04 +0000)]
Merge "Mention UploadBase::stashFile() "checked" exceptions in docs"
jenkins-bot [Mon, 8 Aug 2016 20:14:53 +0000 (20:14 +0000)]
Merge "Add missing addQuotes() call to masterPosWait()"
Translation updater bot [Mon, 8 Aug 2016 20:02:55 +0000 (22:02 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I5b592794dcf6c4ee5c5b2c81885b0c1e816a0fa1
Aaron Schulz [Mon, 8 Aug 2016 19:36:18 +0000 (12:36 -0700)]
Add missing addQuotes() call to masterPosWait()
Change-Id: Ic7f35920fe10d99b63fdff23dc6e3f7cd4c7ca8b
jenkins-bot [Mon, 8 Aug 2016 18:08:26 +0000 (18:08 +0000)]
Merge "SpecialNewFiles: Restore the 'newimagestext' message"
Bartosz Dziewoński [Mon, 8 Aug 2016 17:54:03 +0000 (19:54 +0200)]
SpecialNewFiles: Restore the 'newimagestext' message
Follow-up to
c5ed2698579a085747ef290c9e6e3b8ba3f8960b.
Bug: T142191
Change-Id: If3d0c6d80c97494a6545db67a7adbd7c7ca05cb1
jenkins-bot [Mon, 8 Aug 2016 17:56:25 +0000 (17:56 +0000)]
Merge "SpecialUpload: Use LinkRenderer instead of Linker::link()"
Kunal Mehta [Thu, 4 Aug 2016 22:53:02 +0000 (15:53 -0700)]
SpecialUpload: Use LinkRenderer instead of Linker::link()
Fixed a typo too!
Change-Id: I0b58c2a78c2ae1de850f8e00a549dd29b8cedba2
jenkins-bot [Mon, 8 Aug 2016 16:30:59 +0000 (16:30 +0000)]
Merge "Adding a bunch of hooks from wikiHow into DifferenceEngine, 2nd try"
jenkins-bot [Sun, 7 Aug 2016 21:11:35 +0000 (21:11 +0000)]
Merge "Fix display of numeric tag names on Special:Tags"
jenkins-bot [Sun, 7 Aug 2016 20:55:05 +0000 (20:55 +0000)]
Merge "registration: Add hint about UnitTestsList hook in conversion script"
Translation updater bot [Sun, 7 Aug 2016 20:06:56 +0000 (22:06 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia20da2a7d3a9b9b0f7eee2620b85252cfff2126f
Glaisher [Sat, 30 Jul 2016 10:05:36 +0000 (15:05 +0500)]
Use different message when (un)watching a page in talk namespace
addedwatchtext and removedwatchtext uses the phrase "$1 and its discussion page".
As this is inaccurate on talk namespace pages, two new messages, addedwatchtext-talk
and removedwatchtext-talk, have been introduced for use in talk namespace pages.
Bug: T87856
Change-Id: Iafd86402d3a2a65ce2be007c87c981ac08f44e67
Amir Sarabadani [Sun, 7 Aug 2016 10:27:38 +0000 (14:57 +0430)]
Clean up array() syntax in docs, part II
Change-Id: I226ce6bcb5bbf6ed3802042dd2790f85617833e1
Kunal Mehta [Sun, 7 Aug 2016 09:27:09 +0000 (02:27 -0700)]
registration: Add hint about UnitTestsList hook in conversion script
Change-Id: Ia161c2e10943e75c98ee8e0d2341bc2c9a418faf
This, that and the other [Sun, 7 Aug 2016 05:14:16 +0000 (15:14 +1000)]
Fix display of numeric tag names on Special:Tags
All tag names that were numbers (e.g. "123456") showed up as "0".
Change-Id: I8da326fa4dfa7e6556fb508c5e4b1f1573d1369b
jenkins-bot [Sun, 7 Aug 2016 04:07:26 +0000 (04:07 +0000)]
Merge "Balancer: pass configuration array to flatten instead of individual booleans"
jenkins-bot [Sun, 7 Aug 2016 02:43:45 +0000 (02:43 +0000)]
Merge "Revert "API: Remove deprecated response values from action=login""
jenkins-bot [Sun, 7 Aug 2016 01:57:51 +0000 (01:57 +0000)]
Merge "Don't force loading of groups and options on User::loadFromUserObject"
daniel [Sat, 6 Aug 2016 16:44:08 +0000 (18:44 +0200)]
Don't force loading of groups and options on User::loadFromUserObject
When copying state from one User object to another, don't force
the source object to be initialized. The target object can initialize
groups and options on demand as usual.
Among other things, this helps to avoid some cases of recursive calls
to User::load(), see I6d1b9fe0789b4.
Bug: T142295
Bug: T137051
Change-Id: Ib369cf5b00628550591c2ee5dcb195db7c59a59c
jenkins-bot [Sat, 6 Aug 2016 23:18:16 +0000 (23:18 +0000)]
Merge "HtmlArmor: Pass ENT_QUOTES to htmlspecialchars()"
Fomafix [Sat, 6 Aug 2016 22:49:05 +0000 (22:49 +0000)]
Move style for #wikiPreview to mediawiki.action.edit.styles.css
The style module 'mediawiki.action.edit.styles' gets loaded in EditPage.php.
Bug: T89981
Change-Id: Ie691df4e926be8f094e4117c836334d01d935868
jenkins-bot [Sat, 6 Aug 2016 22:35:56 +0000 (22:35 +0000)]
Merge "Adding release notes about the addition of numeric sorting support"
Kaldari [Thu, 4 Aug 2016 20:35:56 +0000 (13:35 -0700)]
Adding release notes about the addition of numeric sorting support
Bug: T8948
Change-Id: I371c83f21927bd2903c7a87059b088e788702b6b
Bartosz Dziewoński [Sat, 6 Aug 2016 22:19:15 +0000 (00:19 +0200)]
HtmlArmor: Pass ENT_QUOTES to htmlspecialchars()
Change-Id: I0f025d938bd7def8a29788e3c02009a447853275
jenkins-bot [Sat, 6 Aug 2016 22:15:46 +0000 (22:15 +0000)]
Merge "Move Special:Upload styling out of mediawiki.special.styles"
jenkins-bot [Sat, 6 Aug 2016 22:08:25 +0000 (22:08 +0000)]
Merge "Move CSS for patrol from mediawiki.legacy to new module mediawiki.page.patrol"
C. Scott Ananian [Thu, 4 Aug 2016 19:35:59 +0000 (15:35 -0400)]
Balancer: pass configuration array to flatten instead of individual booleans
This refactoring makes it easier to add additional options later without
having to pass them manually through the call chain.
Change-Id: I46814f17d1b338b971ab57f63c2ec75d4a6b45d5
jenkins-bot [Sat, 6 Aug 2016 14:49:50 +0000 (14:49 +0000)]
Merge "Fix @covers tag"
Fomafix [Sat, 6 Aug 2016 13:46:47 +0000 (13:46 +0000)]
Move CSS for patrol from mediawiki.legacy to new module mediawiki.page.patrol
Also change the selector from
div.patrollink
to
.patrollink
Bug: T89981
Change-Id: Ib79d17fab61b1a7b940b2acff6d19a58a3fe0bc9
jenkins-bot [Sat, 6 Aug 2016 08:47:47 +0000 (08:47 +0000)]
Merge "Include AuthManager API endpoints in authmanager channel"
jenkins-bot [Sat, 6 Aug 2016 08:45:59 +0000 (08:45 +0000)]
Merge "Add dependency to 'jquery.textSelection' for 'mediawiki.toolbar'"
jenkins-bot [Sat, 6 Aug 2016 08:42:06 +0000 (08:42 +0000)]
Merge "Show wgPageParseReport on page previews too"
Kunal Mehta [Sat, 6 Aug 2016 08:04:21 +0000 (01:04 -0700)]
Fix @covers tag
Trying to @cover or @use not existing method
"ResourceLoaderFileModule::getScripts"
Change-Id: Ifc4d2c98f5129f0d205e12081dfb48568d8250cb
jenkins-bot [Sat, 6 Aug 2016 01:02:40 +0000 (01:02 +0000)]
Merge "Fix increment() statsd call in JobRunner"
Aaron Schulz [Thu, 4 Aug 2016 19:35:23 +0000 (12:35 -0700)]
Fix increment() statsd call in JobRunner
Change-Id: I17e04db59a44a491aae99c4542216316361010a0
Ben Davis [Mon, 18 Jul 2016 19:26:07 +0000 (14:26 -0500)]
Fix for "Invalid key type: integer"
MWCryptHash::hmac requires a string, but mt_rand() returns an integer.
This issue resulted in an uncaught exception in a fresh installation
of mediawiki.
Imported from https://github.com/wikimedia/mediawiki/pull/55
Change-Id: Idccf5f230bfc2de30357b03c78c51cdad4839515
Aaron Schulz [Fri, 5 Aug 2016 23:28:18 +0000 (16:28 -0700)]
Mention UploadBase::stashFile() "checked" exceptions in docs
Change-Id: I732db6526511711e7c21cf81ddd088e50ab601ec
Gergő Tisza [Fri, 5 Aug 2016 22:50:11 +0000 (22:50 +0000)]
Revert "API: Remove deprecated response values from action=login"
Revert commit
23e5cdb5034dca5bbdfc2ac9c111c5fac20ff579
temporarily so Pywikibot users can catch up with API changes
Bug: T121527
Bug: T142155
Change-Id: I3879a5d76a1727dd653daeebc79d4d9cabd0332e
Aaron Schulz [Fri, 5 Aug 2016 21:52:14 +0000 (14:52 -0700)]
Fix inconsistent RevDelFileItem visibilities
Bug: T142228
Change-Id: Ib5a0a1adbea2daf2b035cf6be367841362de03cc
jenkins-bot [Fri, 5 Aug 2016 22:09:20 +0000 (22:09 +0000)]
Merge "Keep $user->mEditCount up to date"
jenkins-bot [Fri, 5 Aug 2016 21:48:56 +0000 (21:48 +0000)]
Merge "SpecialProtectedpages: Use LinkRenderer instead of Linker::link()"
jenkins-bot [Fri, 5 Aug 2016 21:44:51 +0000 (21:44 +0000)]
Merge "Unify Special:Contribs/DeletedContribs subtitle implementation"
Aaron Schulz [Fri, 5 Aug 2016 21:41:40 +0000 (14:41 -0700)]
Show wgPageParseReport on page previews too
Also make EditPage::getPreviewLimitReport return the same
output instead of using copy-pasted code from the old hook.
Bug: T142210
Bug: T142214
Change-Id: I16c3c2da067fd24bf7ae564cb1d61beaa3be58c1
jenkins-bot [Fri, 5 Aug 2016 21:40:48 +0000 (21:40 +0000)]
Merge "SpecialContributions: Use LinkRenderer instead of Linker::link()"
jenkins-bot [Fri, 5 Aug 2016 21:34:03 +0000 (21:34 +0000)]
Merge "Provide context in ContributionsToolLinks hook"
jenkins-bot [Fri, 5 Aug 2016 20:54:20 +0000 (20:54 +0000)]
Merge "Change explicit class to self in AutoloadGenerator"
Translation updater bot [Fri, 5 Aug 2016 19:58:23 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I049258472a2111a94733403ee8eb8a36bd0280cc
Florian [Fri, 5 Aug 2016 18:04:10 +0000 (20:04 +0200)]
Change explicit class to self in AutoloadGenerator
Follow-up: I3a426b92892f4c00cab33a13f6a717751120367c
Change-Id: I9d91ca42dbf41604639fff2ca00efa6fb262cb3d
James D. Forrester [Fri, 5 Aug 2016 18:04:02 +0000 (11:04 -0700)]
build: Fix stylelint devDependencies
Change-Id: I26cee89c27e3cd8f3c1fc48088b2a8e8b3927e4a
Stephane Bisson [Wed, 3 Aug 2016 15:26:47 +0000 (11:26 -0400)]
Keep $user->mEditCount up to date
Whenever User::incEditCount() is called,
this tries to keep the user object up
to date so hooks can read the edit count
without reloading the user from the db.
Another option would be invalidate the
instance cache and let the read
repopulate it. It would add a db access
on each edit.
Bug: T128249
Change-Id: I79194c41d6b2fd84ad658909a2941d9d3d28d94e
Fomafix [Fri, 5 Aug 2016 13:01:03 +0000 (13:01 +0000)]
Add dependency to 'jquery.textSelection' for 'mediawiki.toolbar'
Change-Id: Ie3b001551802364b488ba84588a028c44c73e755
Gergő Tisza [Fri, 5 Aug 2016 02:17:28 +0000 (02:17 +0000)]
Include AuthManager API endpoints in authmanager channel
Change-Id: I0fa6e9687d02a67c5d36e16b3827e7cc3beb8259
jenkins-bot [Fri, 5 Aug 2016 00:54:57 +0000 (00:54 +0000)]
Merge "Balancer style tweaks"
jenkins-bot [Fri, 5 Aug 2016 00:27:25 +0000 (00:27 +0000)]
Merge "Balancer: remove redundant assignment"
jenkins-bot [Fri, 5 Aug 2016 00:05:36 +0000 (00:05 +0000)]
Merge "Balancer: consistent single-line comment style"
jenkins-bot [Thu, 4 Aug 2016 23:18:14 +0000 (23:18 +0000)]
Merge "resourceloader: Add missing @private and @protected to mw.loader methods"
Timo Tijhof [Thu, 4 Aug 2016 22:45:39 +0000 (15:45 -0700)]
resourceloader: Add missing @private and @protected to mw.loader methods
Several local functions were indexed by JSDuck as mw.loader methods whereas
they are in fact they don't even exist on that object. Mark them as @private.
Also add @protected on the internal methods 'work()' and 'require()',
which are public but not for general use (and may change without warning).
Change-Id: If521cc5ae4a565a46161890cf32e95a8c7f4ca50
Kunal Mehta [Thu, 4 Aug 2016 22:48:34 +0000 (15:48 -0700)]
Move Special:Upload styling out of mediawiki.special.styles
...into the specific mediawiki.special.upload.styles module which is
only supposed to be loaded upon Special:Upload.
Change-Id: I782bb3b05ef4fe9f2fc666afe8e1cb9514fc8b52
Kunal Mehta [Thu, 4 Aug 2016 22:25:13 +0000 (15:25 -0700)]
SpecialProtectedpages: Use LinkRenderer instead of Linker::link()
And remove an unused variable while we're at it.
Change-Id: I494caccfff4fb0510f26554395150e59c728c5a1
Kunal Mehta [Thu, 4 Aug 2016 22:19:59 +0000 (15:19 -0700)]
Unify Special:Contribs/DeletedContribs subtitle implementation
Basically all of the code was duplicated, except that Contribs had a
link to DeletedContribs, and DeletedContribs had a link to Contribs.
Now DeletedContribs will call the function in Contribs, and remove the
DeletedContribs link, and add its own link to Contribs instead of
needing to duplicate the entire list of links.
Change-Id: Ia004a4a69427fd5b554131b19b0e263523b7da67
Tim Starling [Mon, 1 Aug 2016 06:27:09 +0000 (16:27 +1000)]
Balancer style tweaks
* Use for loops where appropriate, instead of while
* De-indent a large block which was unnecessarily indented
* Use camel case for variable names, per the style guide
Change-Id: I0b2c37fdcab7f7238db0393085c43297e7a03ab2
Tim Starling [Mon, 1 Aug 2016 02:12:43 +0000 (12:12 +1000)]
Balancer: remove redundant assignment
Change-Id: I6c22d6227e43a2c5be454955eff6b053a94a1657
Timo Tijhof [Thu, 4 Aug 2016 21:47:57 +0000 (14:47 -0700)]
resourceloader: Disable filesystem cache for Less
Follows-up
ea862efa7, which enables use of Less_Cache as part
of the switch from leafo/lessphp to oyejorge/less.php.
Since then
12afb3607 introduced a better caching method in
FileModule::compileLessFile(), which:
* Uses APC where possible, with fallback to main objectcache.
* Verifies both the input file and the indirectly used files have
not changed before using the cache. The built-in cache system
only seems to check the root file.
As such, we're incurring the overhead of generating them and storing
on-disk, but raraly ever making use of them. (And even if we do
use it when the APC object first expires, it's risky due to the
lack of indirect file validation).
Bug: T121519
Change-Id: I6e3c66f86a536463488697efc166fb704be0715c
Kunal Mehta [Thu, 4 Aug 2016 21:48:55 +0000 (14:48 -0700)]
SpecialContributions: Use LinkRenderer instead of Linker::link()
Change-Id: I9d6b81d5c71ab56fef2fe4bd95cfa1a6c38cbc32
Kunal Mehta [Thu, 4 Aug 2016 21:48:29 +0000 (14:48 -0700)]
Provide context in ContributionsToolLinks hook
Most of the hook functions need context to see what the current user's
permissions are, to generate messages, or the LinkRenderer service to
generate the tool links.
Change-Id: I19fa27c8115ee39dded6cb98f29c35b66b934f8a
Translation updater bot [Thu, 4 Aug 2016 20:50:42 +0000 (22:50 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I7f4659b50dcebe65487d1cc01ab9b1b6aeefbcec
jenkins-bot [Thu, 4 Aug 2016 19:44:28 +0000 (19:44 +0000)]
Merge "Add search-ignored-headings string, copied from cirrus-search-ignored-headings."
Tim Starling [Mon, 1 Aug 2016 01:51:46 +0000 (11:51 +1000)]
Balancer: consistent single-line comment style
Also break a line that was over 100 bytes
Change-Id: I875d572d4147f2438526a49ca6cb5b73907bdc9b
jenkins-bot [Thu, 4 Aug 2016 19:10:09 +0000 (19:10 +0000)]
Merge "Allow closures as HTMLInfoField values"
jenkins-bot [Thu, 4 Aug 2016 18:48:39 +0000 (18:48 +0000)]
Merge "resourceloader: Implement 'deprecated' option for FileModule"
Stanislav Malyshev [Tue, 14 Jun 2016 21:01:13 +0000 (14:01 -0700)]
Add search-ignored-headings string, copied from cirrus-search-ignored-headings.
Change-Id: I4178f872996800379843301f7119840f4a4551df
jdlrobson [Thu, 14 Jul 2016 22:09:06 +0000 (15:09 -0700)]
resourceloader: Implement 'deprecated' option for FileModule
ResourceLoader modules can now carry a 'deprecated' option which can
be a boolean or an object with message key. This message or a default
deprecation message will be show whenever that module is used in production.
Note: This will not work in debug mode for ResourceLoaderFile modules
and this is deemed acceptable for the time being. We can revisit later.
Bug: T137772
Change-Id: Ib9ebd2d39a59fd41d8537e06884699f77b03580c
Kunal Mehta [Thu, 4 Aug 2016 16:44:55 +0000 (09:44 -0700)]
Autodiscover extension unittests
Instead of requiring every extension that wants to add unit tests to
copy the exact same boilerplate over and over, let's just automatically
discover them. We now have an extension registry, so we know exactly
which extensions are loaded (this won't work for extensions not being
loaded through extension.json).
For each extension, we check to see if the directory "tests/phpunit/"
exists, and if it does, add those unit tests. If there is a
`UnitTestsList` subscriber already set, PHPUnit will automatically
de-duplicate test cases so we won't be running anything twice.
Change-Id: I6ec654ef2d8ee3630b121b1277b4ee21ba0b6cd4
jenkins-bot [Thu, 4 Aug 2016 15:54:36 +0000 (15:54 +0000)]
Merge "Make content handlers assemble content for search"
jenkins-bot [Thu, 4 Aug 2016 09:34:34 +0000 (09:34 +0000)]
Merge "MediaHandlerFactory: Don't use any global state"
jenkins-bot [Thu, 4 Aug 2016 09:30:53 +0000 (09:30 +0000)]
Merge "Move MediaHandler defaults out of global scope"
jenkins-bot [Thu, 4 Aug 2016 09:27:33 +0000 (09:27 +0000)]
Merge "Override MediaHandlers in tests using MediaWikiServices"
jenkins-bot [Thu, 4 Aug 2016 09:27:23 +0000 (09:27 +0000)]
Merge "Introduce MediaHandlerFactory to create MediaHandler objects"
jenkins-bot [Thu, 4 Aug 2016 02:14:01 +0000 (02:14 +0000)]
Merge "OutputPage: Add addHeadItems() method"
jenkins-bot [Thu, 4 Aug 2016 01:18:54 +0000 (01:18 +0000)]
Merge "Pass $archivedRevisionCount to the ArticleDeleteComplete hook"
Andrew Otto [Tue, 12 Jul 2016 18:42:33 +0000 (14:42 -0400)]
Pass $archivedRevisionCount to the ArticleDeleteComplete hook
Bug: T134502
Change-Id: I1df89beeadbec2a3592e51fbb525ed6db2424619
jenkins-bot [Thu, 4 Aug 2016 00:14:34 +0000 (00:14 +0000)]
Merge "phpdoc File::makeTransformTmpFile can return null"
Kunal Mehta [Fri, 29 Jul 2016 00:01:08 +0000 (17:01 -0700)]
MediaHandlerFactory: Don't use any global state
Instead inject the configured MediaHandlers in the service constructor.
Change-Id: I039c01ef531389c74524cb7adcb8cf1229d9a95d
Kunal Mehta [Tue, 26 Jul 2016 02:56:16 +0000 (19:56 -0700)]
Move MediaHandler defaults out of global scope
The defaults that were in $wgMediaHandlers are now listed in
MediaHandlerFactory.
The main advantage of doing this is we get O(1) replacement when
extensions set a media handler in their extension.json.
Bug: T141305
Change-Id: I05771a673837ab8d6331eedc24eb707be7f3a250
Kunal Mehta [Tue, 26 Jul 2016 02:46:13 +0000 (19:46 -0700)]
Override MediaHandlers in tests using MediaWikiServices
Change-Id: Ie39fd9243e7817191b87179f792d932f7b96de0c
Kunal Mehta [Tue, 26 Jul 2016 02:19:25 +0000 (19:19 -0700)]
Introduce MediaHandlerFactory to create MediaHandler objects
This will allow further refactoring of override logic in parser tests.
Ideally the factory class would not use $wgMediaHandlers directly, but
that ends up breaking too many tests for now.
Change-Id: I34a63ee7089ff26f86f3dd6f3cd1a37928bc4005
jenkins-bot [Wed, 3 Aug 2016 21:17:02 +0000 (21:17 +0000)]
Merge "Wrap revision info and nav in a div for easy formatting in MobileFrontend"
Translation updater bot [Wed, 3 Aug 2016 19:59:27 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I0ac53363139c522e4b35b8fbe49a7ac8d5ccbf45
jenkins-bot [Wed, 3 Aug 2016 18:31:23 +0000 (18:31 +0000)]
Merge "Pingback: Fix phpdoc"
jenkins-bot [Wed, 3 Aug 2016 18:27:27 +0000 (18:27 +0000)]
Merge "auth: Fix case of function call"
addshore [Wed, 3 Aug 2016 17:42:54 +0000 (18:42 +0100)]
phpdoc File::makeTransformTmpFile can return null
Change-Id: Ibeefb87919dfa2e5f850570942cbeab01e84e8a7
James D. Forrester [Wed, 3 Aug 2016 16:41:35 +0000 (09:41 -0700)]
Update OOjs UI to v0.17.7
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.17.7
Change-Id: I0f36a3485a75ad0346eef9ae98aa47eddb099faf
Florian [Wed, 20 Jan 2016 18:27:47 +0000 (19:27 +0100)]
Structure test: Add autoload.php order check
If a class is added manually to the autoload.php another run of
the maintenance script will probably add unnecessary noise to
another change. The added structure test checks, if the output of
the maintenance script equals to the contents of the commited
autoload.php.
Bug: T121921
Change-Id: I3a426b92892f4c00cab33a13f6a717751120367c
Kunal Mehta [Wed, 3 Aug 2016 08:56:28 +0000 (01:56 -0700)]
Pingback: Fix phpdoc
Change-Id: Ib4fd932a9b65e46e9b43e594a6e1ab5a4dac76d9