From: Thiemo Mättig <thiemo.maettig@wikimedia.de>
Date: Thu, 17 Jul 2014 07:42:19 +0000 (+0200)
Subject: Add tests for disabled actions in ActionTest
X-Git-Tag: 1.31.0-rc.0~14826^2
X-Git-Url: http://git.cyclocoop.org/%28%5B%5E/404?a=commitdiff_plain;h=1ccdd5bec0fa2a9bed75cb940828c827c11285e4;p=lhc%2Fweb%2Fwiklou.git

Add tests for disabled actions in ActionTest

Change-Id: I2c742fca0fa87604c1d503b938ecc495aafd8376
---

diff --git a/tests/phpunit/includes/actions/ActionTest.php b/tests/phpunit/includes/actions/ActionTest.php
index 1297af3326..4eb30ec05a 100644
--- a/tests/phpunit/includes/actions/ActionTest.php
+++ b/tests/phpunit/includes/actions/ActionTest.php
@@ -16,6 +16,7 @@ class ActionTest extends MediaWikiTestCase {
 		$context = $this->getContext();
 		$this->setMwGlobals( 'wgActions', array(
 			'null' => null,
+			'disabled' => false,
 			'dummy' => true,
 			'string' => 'NamedDummyAction',
 			'declared' => 'NonExistingClassName',
@@ -98,6 +99,26 @@ class ActionTest extends MediaWikiTestCase {
 		$this->assertType( $expected ?: 'null', $action );
 	}
 
+	public function testDisabledAction_exists() {
+		$exists = Action::exists( 'disabled' );
+
+		$this->assertTrue( $exists );
+	}
+
+	public function testDisabledAction_isNotResolved() {
+		$context = $this->getContext( 'disabled' );
+		$actionName = Action::getActionName( $context );
+
+		$this->assertEquals( 'nosuchaction', $actionName );
+	}
+
+	public function testDisabledAction_factoryReturnsFalse() {
+		$context = $this->getContext( 'disabled' );
+		$action = Action::factory( 'disabled', $context->getWikiPage(), $context );
+
+		$this->assertFalse( $action );
+	}
+
 	public function dummyActionCallback() {
 		$context = $this->getContext();
 		return new CalledDummyAction( $context->getWikiPage(), $context );