daniel [Tue, 3 Jul 2018 15:46:30 +0000 (17:46 +0200)]
Use consistent caching strategy in Revision storage classes
DEPLOYMENT: This changes the cache key for revision
content blobs. Expect a brief rise in ExternalStore hits.
Bug: T198704
Change-Id: Icc2d16bc5a1e27ba4caea49a784ba7aeac15042a
Aaron Schulz [Thu, 5 Jul 2018 12:50:57 +0000 (13:50 +0100)]
rdbms: add resolveDomainID() method to LBFactory/LoadBalancer
Also add LBFactory::getLocalDomainID to match the one in LoadBalancer
Change-Id: Ia31f0800bd3b692194c08b1eab9cfb2f43679c7a
jenkins-bot [Thu, 5 Jul 2018 11:05:12 +0000 (11:05 +0000)]
Merge "Add support for extra database connections in unit tests."
jenkins-bot [Thu, 5 Jul 2018 11:05:07 +0000 (11:05 +0000)]
Merge "Remove outdated transition code"
Adam Wight [Wed, 4 Jul 2018 22:45:09 +0000 (00:45 +0200)]
Remove outdated transition code
This was a soft transition left over from when "edittime" was the last
form parameter. It has been replaced with an explicit "ultimate" param.
Change-Id: I28767fdf8fab512830fe6e24cacabb598d7cca90
jenkins-bot [Wed, 4 Jul 2018 22:18:08 +0000 (22:18 +0000)]
Merge "Limit the number of cached languages in MessageCache via MapCacheLRU"
Translation updater bot [Wed, 4 Jul 2018 19:53:37 +0000 (21:53 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie56758895fb4a1d83a0dc372463df7907f07b08c
daniel [Wed, 4 Jul 2018 15:20:31 +0000 (17:20 +0200)]
Add support for extra database connections in unit tests.
This adds a way to take any connection to the wiki database and
allow it to be used for unit tests.
This is needed to test code that requires two independent DB
connections, to the same database or to a different wiki's database.
Change-Id: I0b84a0c4d174cbde830786028ee7568c4ea9fb5d
Aaron Schulz [Wed, 4 Jul 2018 07:20:53 +0000 (08:20 +0100)]
Fix CONCAT assertions in some MCR tests
Change-Id: I9507ae60751f8e9cc5e6205148cf2e37f67f42c5
jenkins-bot [Wed, 4 Jul 2018 02:00:58 +0000 (02:00 +0000)]
Merge "mw.Upload.BookletLayout: Update padding/margin to match OOUI to avoid scrollbars"
jenkins-bot [Wed, 4 Jul 2018 00:44:28 +0000 (00:44 +0000)]
Merge "Add missing use statements"
Bartosz Dziewoński [Mon, 2 Jul 2018 23:20:47 +0000 (01:20 +0200)]
mw.Upload.BookletLayout: Update padding/margin to match OOUI to avoid scrollbars
Change-Id: Ie3b246fcb064a04bc90fec06f6285306a013a819
Translation updater bot [Tue, 3 Jul 2018 19:54:37 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I3aa4ab1da349c15c6fb33c323324119aa352eff8
Arlo Breault [Tue, 3 Jul 2018 19:02:26 +0000 (15:02 -0400)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
bbc56abd8fcc245876fc340723ed3431565b61d1
Change-Id: I463401aa3d2dd290d5ba6813e8e869f713682dd3
jenkins-bot [Tue, 3 Jul 2018 17:20:34 +0000 (17:20 +0000)]
Merge "Fix error in various deprecated selectFields() methods"
jenkins-bot [Tue, 3 Jul 2018 17:08:02 +0000 (17:08 +0000)]
Merge "Remove deprecated CONN_TRX_AUTO alias"
jenkins-bot [Tue, 3 Jul 2018 16:29:57 +0000 (16:29 +0000)]
Merge "Hard deprecate wfBCP47, which was soft deprecated in 1.31"
Brad Jorsch [Tue, 3 Jul 2018 15:59:18 +0000 (11:59 -0400)]
Fix error in various deprecated selectFields() methods
When aliasing a field to null, it has to be aliased to the string 'NULL'
rather than PHP null.
Bug: T198687
Change-Id: I6096f306b97022da781eaabeb15e502f391673a9
jenkins-bot [Tue, 3 Jul 2018 15:37:45 +0000 (15:37 +0000)]
Merge "build: Set Travis conf to "allow failure" for long-failing builds"
jenkins-bot [Tue, 3 Jul 2018 15:01:03 +0000 (15:01 +0000)]
Merge "Use CONN_TRX_AUTOCOMMIT instead of deprecated CONN_TRX_AUTO alias"
C. Scott Ananian [Tue, 26 Jun 2018 18:11:59 +0000 (14:11 -0400)]
Hard deprecate wfBCP47, which was soft deprecated in 1.31
Change-Id: I8632f08a8cb22641b5d16d955f3164dc45843520
jenkins-bot [Tue, 3 Jul 2018 13:06:35 +0000 (13:06 +0000)]
Merge "mw.widgets.TitleWidget: Don't mark optional fields as invalid when empty"
Aaron Schulz [Tue, 3 Jul 2018 12:03:55 +0000 (13:03 +0100)]
Remove deprecated CONN_TRX_AUTO alias
Change-Id: I0bc9b89e998cd3b324f9c72507d40a473bfb6118
Aaron Schulz [Tue, 3 Jul 2018 12:03:44 +0000 (13:03 +0100)]
Use CONN_TRX_AUTOCOMMIT instead of deprecated CONN_TRX_AUTO alias
Change-Id: I23dc7052bd1ca9a9c8fec2409f3067304745043a
jenkins-bot [Tue, 3 Jul 2018 11:18:43 +0000 (11:18 +0000)]
Merge "RESTBagOStuff: improve timeouts and logging"
jenkins-bot [Tue, 3 Jul 2018 11:12:11 +0000 (11:12 +0000)]
Merge "resourceloader: Simplify ResourceLoader::isFileModule()"
Aaron Schulz [Mon, 25 Jun 2018 09:45:55 +0000 (10:45 +0100)]
Limit the number of cached languages in MessageCache via MapCacheLRU
Change-Id: I37a128cfc553e0edaab524098461776cec3fe08a
jenkins-bot [Tue, 3 Jul 2018 07:58:40 +0000 (07:58 +0000)]
Merge "Add MediaWikiService::getPerDbNameStatsdDataFactory"
jenkins-bot [Tue, 3 Jul 2018 05:40:03 +0000 (05:40 +0000)]
Merge "rdbms: fix Sqlite::tableExists() method to avoid STATUS_TRX_ERROR"
Timo Tijhof [Tue, 3 Jul 2018 01:08:02 +0000 (18:08 -0700)]
build: Set Travis conf to "allow failure" for long-failing builds
Specifically, PHP 7.2, postgres and all HHVM builds have been
failing for at least a month or more. In order for notifications
to become useful, whitelist these for now, so that next time
the main MySQL/PHP 7.0 or PHP 7.1 build failes, we'll notice
sooner.
Also move the notifs back to #wikimedia-dev and make it match
the configuration of other repos that use Travis via GitHub
(such as CSSJanus), specifically, to use a message template
that spans only a single line, instead of the default which
spans several lines.
Change-Id: I3abbff51414d33cde34cca26896724e8999c32db
Timo Tijhof [Tue, 3 Jul 2018 01:04:31 +0000 (18:04 -0700)]
resourceloader: Simplify ResourceLoader::isFileModule()
Method already has 100% test coverage.
Change-Id: I695e0ecca7a749e1721e489007f3b9f99358a96b
jenkins-bot [Mon, 2 Jul 2018 22:36:47 +0000 (22:36 +0000)]
Merge "RC Filters: Avoid unnecessary update events when clearing highlight"
jenkins-bot [Mon, 2 Jul 2018 22:33:30 +0000 (22:33 +0000)]
Merge "RC Filters: Lazy build menu on model initialization"
Kunal Mehta [Sun, 24 Jun 2018 21:09:32 +0000 (00:09 +0300)]
shell: Note that ::isDisabled() should be called before ::command()
And check it in the FirejailCommandTest (integration) for completeness,
even though it will make no practical difference.
Change-Id: Ieb130a888ef8a8162cb0a049ab9c20eac3f58217
Kunal Mehta [Sun, 24 Jun 2018 21:07:42 +0000 (00:07 +0300)]
Maintenance: Don't try shelling out if it's disabled
Change-Id: Ib30c55aa9e048960f8fa66a41f7e2aa2fa03b253
jenkins-bot [Mon, 2 Jul 2018 21:53:10 +0000 (21:53 +0000)]
Merge "Prevent fatal error when {{#translation:}} is placed on subpage named code"
jenkins-bot [Mon, 2 Jul 2018 21:49:46 +0000 (21:49 +0000)]
Merge "Special:Preferences: Replace OOUI preferences CSS by LESS file"
jenkins-bot [Mon, 2 Jul 2018 21:47:58 +0000 (21:47 +0000)]
Merge "Special:Preferences: Improve section grouping"
Fomafix [Tue, 19 Jun 2018 19:37:17 +0000 (21:37 +0200)]
Deprecate string type for $lang of DifferenceEngine::setTextLanguage
Also move the comment about the default value from the setter to the
getter.
Change-Id: I2e1bd29db986dfa92d41a876340a6aa59ac6670d
Depends-On: I8b573866c2de9b21d3849f02269c1b9ca4f62aba
Kosta Harlan [Sat, 30 Jun 2018 16:30:23 +0000 (12:30 -0400)]
RC Filters: Lazy build menu on model initialization
Use setTimeout() on model initialization to build the menu as part of the
page load process to remove the perceptible delay on the first click of the
menu.
Bug: T198535
Change-Id: Icaf0a37444786e80536b680fa37d04d095091377
Translation updater bot [Mon, 2 Jul 2018 19:54:08 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8dd1dd52e3e29ae52591624bff32b8a0375afc3a
jenkins-bot [Mon, 2 Jul 2018 19:47:18 +0000 (19:47 +0000)]
Merge "RC Filters: Prevent updateIfHeightChanged on tag multiselect widget"
addshore [Mon, 2 Jul 2018 17:01:45 +0000 (18:01 +0100)]
Add MediaWikiService::getPerDbNameStatsdDataFactory
Bug: T196609
Change-Id: I08a4909e2855e33569641166b77be5d8bf4e2c34
jenkins-bot [Mon, 2 Jul 2018 17:23:04 +0000 (17:23 +0000)]
Merge "Use array_merge to merge indexed arrays in categoryChangesAsRdf.php."
Kosta Harlan [Fri, 29 Jun 2018 18:58:03 +0000 (14:58 -0400)]
RC Filters: Avoid unnecessary update events when clearing highlight
The strict equality check just below the lines added in this commit will fail
if the Item's highlightColor is null/undefined, and if the incoming parameter
is null. This situation happens when
mw.rcfilters.dm.ItemModel.prototype.clearHighlightColor is called when updating
the state from the query parameters. By returning early we can avoid emitting
update events for every filter item.
Bug: T198359
Change-Id: Ia3e5f333964545c7f33777be915389728c03eace
daniel [Mon, 2 Jul 2018 15:43:41 +0000 (17:43 +0200)]
Use array_merge to merge indexed arrays in categoryChangesAsRdf.php.
Bug: T198356
Change-Id: Ic29568ecfc26da7e6d8c9a875232bfa4e0f9f380
Niklas Laxström [Mon, 2 Jul 2018 09:30:52 +0000 (11:30 +0200)]
Prevent fatal error when {{#translation:}} is placed on subpage named code
Bug: T198518
Change-Id: Ia202e78adc53a54f95597b8701304c7f3832bf9c
Aaron Schulz [Mon, 2 Jul 2018 11:54:41 +0000 (12:54 +0100)]
Fix incorrect arguments to prepareContent() call in WikiPage
Bug: T198483
Change-Id: I7115a9f8c7d5a6d84b77149fda266ad05ff3274d
Gergő Tisza [Mon, 2 Jul 2018 14:20:34 +0000 (16:20 +0200)]
Update parser tests for translation change
Bug: T198625
Change-Id: I1f52288be319f7d429a8536987cf5efc357d78c6
Translation updater bot [Sun, 1 Jul 2018 19:52:47 +0000 (21:52 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I1175766566835e0f1aa5d23b5fd74a23db9659de
Translation updater bot [Sat, 30 Jun 2018 19:55:47 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: If06de066ea51f0418a4241c33a4b7e9593a3e392
Volker E [Sat, 30 Jun 2018 13:26:12 +0000 (15:26 +0200)]
Special:Preferences: Replace OOUI preferences CSS by LESS file
Also use 'mediawiki.mixins' and structure file in LESS way.
Change-Id: I3de02eb3996c1ebe9536067df593d3096a5f1eaa
Kosta Harlan [Sat, 30 Jun 2018 11:39:51 +0000 (07:39 -0400)]
RC Filters: Prevent updateIfHeightChanged on tag multiselect widget
If not overridden, TagMultiselectWidget's updateIfHeightChange is invoked on
page load which triggers a resize event.
Bug: T198399
Change-Id: I47bbb54b53c2b0899fb4bfbfb36bbc012654fd8e
jenkins-bot [Fri, 29 Jun 2018 23:53:29 +0000 (23:53 +0000)]
Merge "WikiPage: Do not set "undid revision ID" for rollbacks"
Bartosz Dziewoński [Fri, 29 Jun 2018 22:49:08 +0000 (00:49 +0200)]
mw.widgets.TitleWidget: Don't mark optional fields as invalid when empty
Bug: T198402
Change-Id: I0e69f2015894ddf5ad53190740255f1c073fd76a
jenkins-bot [Fri, 29 Jun 2018 22:38:45 +0000 (22:38 +0000)]
Merge "Allow MediaWikiTestCase::insertPage to use given User"
MusikAnimal [Fri, 29 Jun 2018 19:56:22 +0000 (15:56 -0400)]
Allow MediaWikiTestCase::insertPage to use given User
Sometimes you need to create pages with a non-sysop.
Example: I31aedcb9af7584fa5504916c67ca10f205ec9910
Change-Id: I9e48f7c00efbce8c2de3f5db3a74462d47ae8f64
jenkins-bot [Fri, 29 Jun 2018 21:03:32 +0000 (21:03 +0000)]
Merge "RCFilters: Fix highlight container selector in Watchlist overrides"
Matěj Suchánek [Fri, 29 Jun 2018 20:53:11 +0000 (22:53 +0200)]
WikiPage: Do not set "undid revision ID" for rollbacks
It causes them to be tagged with the "mw-undo" tag, in addition to the
"mw-rollback" tag they already have.
Bug: T190374
Change-Id: Ia447a107f0844cfef4a51a72fdec7aeea0480c70
Translation updater bot [Fri, 29 Jun 2018 19:58:43 +0000 (21:58 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I87bb2d2a0c503c4945c8acc2c57389d498e8492e
Moriel Schottlender [Fri, 29 Jun 2018 16:06:14 +0000 (09:06 -0700)]
RCFilters: Fix highlight container selector in Watchlist overrides
Bug: T198445
Change-Id: I01f0ccc964595c0f65aca6cbcac7828ebad33818
jenkins-bot [Fri, 29 Jun 2018 19:37:18 +0000 (19:37 +0000)]
Merge "selenium: Remove '☃' character (U+2603 snowman emoji) from random usernames"
jenkins-bot [Fri, 29 Jun 2018 19:34:47 +0000 (19:34 +0000)]
Merge "Prevent "Undefined offset notice""
jenkins-bot [Fri, 29 Jun 2018 17:19:01 +0000 (17:19 +0000)]
Merge "Consolidate AtomicSectionUpdate code in DerivedPageDataUpdater."
jenkins-bot [Fri, 29 Jun 2018 17:18:56 +0000 (17:18 +0000)]
Merge "Add Manipuri/Meitei to Names.php"
Volker E [Fri, 29 Jun 2018 17:04:19 +0000 (19:04 +0200)]
Special:Preferences: Improve section grouping
Improving section grouping per tab/meta section by increasing
whitespace.
Also remove sub-borders in No-JS clients and unnecessary property.
Bug: T198499
Change-Id: Id28f0d9631dfb08c51bf287c0aac0c1c206ea795
jenkins-bot [Fri, 29 Jun 2018 16:09:53 +0000 (16:09 +0000)]
Merge "RCFilters: Hide highlight containers when RCFilters is disabled"
Kevin Israel [Thu, 28 Jun 2018 09:58:28 +0000 (05:58 -0400)]
MWNamespace: Add getCategoryLinkType() method
This method returns the value used as cl_type for category links that
are "from" pages within the namespace, and is added to avoid duplication
of code across a few classes.
Change-Id: I4e55932a5a27858cfedb12009b455fcd02f9b5df
jenkins-bot [Fri, 29 Jun 2018 15:21:24 +0000 (15:21 +0000)]
Merge "Ensure services are added to MediaWikiServicesTest::provideGetService"
jenkins-bot [Fri, 29 Jun 2018 15:21:19 +0000 (15:21 +0000)]
Merge "Add @see $wgContentHandlerUseDB to RevisionStore params"
Bartosz Dziewoński [Fri, 29 Jun 2018 14:58:36 +0000 (16:58 +0200)]
selenium: Remove '☃' character (U+2603 snowman emoji) from random usernames
The AntiSpoof extension disallows this character in usernames, causing
tests to fail on some setups. Its error message claims it is an
"unassigned character" (which is false), but it seems it's
intentionally disallowed and the error message should instead say
"non-script character" or something.
Bug: T198384
Change-Id: Ia8e7b425b6a3cf3742c00178f28c97a19f46bab0
addshore [Fri, 29 Jun 2018 09:42:25 +0000 (10:42 +0100)]
Add @see $wgContentHandlerUseDB to RevisionStore params
Change-Id: Ic7c4a7a729b2cac6ac46ae9475167acfe6e8dd9e
addshore [Fri, 29 Jun 2018 09:31:27 +0000 (10:31 +0100)]
Ensure services are added to MediaWikiServicesTest::provideGetService
Change-Id: I3f6ded009ed98b615adb7c46d41bced450972b54
addshore [Fri, 29 Jun 2018 09:22:58 +0000 (10:22 +0100)]
MediaWikiServicesTest, remove out of date note
provideGetters is now automatically populated using the
provideGetService method so we don't need to actually add
the service there
Change-Id: I07e8f54e5c4aa7ff22d02312bf51ac8d1cc4b5c2
addshore [Wed, 27 Jun 2018 12:16:35 +0000 (13:16 +0100)]
Introduce RevisionStoreFactory & Tests
Bug: T194729
Change-Id: I0a8a441b803816281113e52a2a57cc07af8a1119
jenkins-bot [Fri, 29 Jun 2018 11:04:22 +0000 (11:04 +0000)]
Merge "Regression test for autopatrolling rollbacks"
jenkins-bot [Fri, 29 Jun 2018 10:42:02 +0000 (10:42 +0000)]
Merge "Correct $specialPageAliases for sa.wiki"
daniel [Fri, 29 Jun 2018 09:59:51 +0000 (11:59 +0200)]
Regression test for autopatrolling rollbacks
Bug: T198449
Change-Id: Ic280c38ac2ba0a0842c484f671e7e99f50cd54d5
Matěj Suchánek [Fri, 29 Jun 2018 07:14:15 +0000 (07:14 +0000)]
Mark rollbacking revision as patrolled
I just copy & pasted lines 1833-1838.
Bug: T198449
Change-Id: I5d356b074e048a2325a64bfe2c1e652c640c560f
Matěj Suchánek [Fri, 8 Jun 2018 13:34:41 +0000 (13:34 +0000)]
Prevent "Undefined offset notice"
The number provided by the query can be arbitrary, so let's narrow the
input validation to booleans.
Bug: T194616
Change-Id: If03e6e2d5bbcf4f2d85047cc23ee5388b39fe114
MarcoAurelio [Mon, 25 Jun 2018 21:42:30 +0000 (23:42 +0200)]
Add Manipuri/Meitei to Names.php
Bug: T198132
Change-Id: I43620c1f34eecda69c61ea0bb13a213e0e6a457d
Roan Kattouw [Fri, 29 Jun 2018 04:43:04 +0000 (21:43 -0700)]
RCFilters: Hide highlight containers when RCFilters is disabled
The mw-rcfilters-ui-highlights divs are given display: none; (if
highlights are disabled) or display: inline-block; (if they are enabled)
by the RCFilters CSS, but none of that CSS loads when RCFilters is
disabled, so in that case they default to display: block;. I don't know
why this doesn't cause them to break the line in Chrome and Firefox, but
I suspect that this is what causes the display issues in Edge that
people have been reporting.
This is a speculative fix because I'm not able to run Edge to verify.
Bug: T198440
Change-Id: I7b4d9b01d9b78828c273895a0093a2a7c0b4fc99
jenkins-bot [Fri, 29 Jun 2018 02:16:52 +0000 (02:16 +0000)]
Merge "objectcache: make MultiWriteBagOStuff handle duplicate add() operations"
Krinkle [Fri, 29 Jun 2018 01:52:16 +0000 (01:52 +0000)]
Merge "ForeignStructuredUpload: Stop using methods from CapsuleMultiselectWidget"
Krinkle [Fri, 29 Jun 2018 01:25:37 +0000 (01:25 +0000)]
Merge "Remove deprecated 'json' module"
jenkins-bot [Fri, 29 Jun 2018 00:30:58 +0000 (00:30 +0000)]
Merge "Hard-deprecate ApiBase::profile{In|Out}()"
jenkins-bot [Thu, 28 Jun 2018 23:02:26 +0000 (23:02 +0000)]
Merge "Make ProcessCacheLRU wrap MapCacheLRU"
jenkins-bot [Thu, 28 Jun 2018 22:42:02 +0000 (22:42 +0000)]
Merge "RC Filters: Check if app is initialized before calling change tags"
Timo Tijhof [Thu, 28 Jun 2018 21:50:22 +0000 (22:50 +0100)]
Remove deprecated 'json' module
This is an empty placeholder module. It was kept for backwards compatibility
with older extensions that were still supporting MediaWiki versions that in
turn supported older browsers that in turn did not yet implement the JSON
interface of the ES5 standard.
There is no longer any use of 'json' module anywhere in Wikimedia Git,
nor anywhere found by Codesearch, nor anywhere on-wiki in gadgets at WMF.
Bug: T127328
Change-Id: I8ba40a73dc900909e3fa3bd3ebe88616c9a26d3c
Max Semenik [Thu, 28 Jun 2018 20:57:46 +0000 (13:57 -0700)]
Hard-deprecate ApiBase::profile{In|Out}()
The only remaining calls are getting removed in I37641dee50a.
Change-Id: I3ee698781a4698d1ef8e74209b82fb1f984fb8e9
Aaron Schulz [Wed, 27 Jun 2018 14:00:10 +0000 (15:00 +0100)]
Make ProcessCacheLRU wrap MapCacheLRU
Change-Id: I190c824af471aee798e2f111b902f38532b8ac99
Translation updater bot [Thu, 28 Jun 2018 19:55:54 +0000 (21:55 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I401fa4fb518d8f772e3bd1cc06eda55a066d75e1
jenkins-bot [Thu, 28 Jun 2018 19:22:03 +0000 (19:22 +0000)]
Merge "Add key expiration and map resizing support to MapCacheLRU"
jenkins-bot [Thu, 28 Jun 2018 18:54:19 +0000 (18:54 +0000)]
Merge "Fix table locking in WikiPage::doDeleteArticleReal"
jenkins-bot [Thu, 28 Jun 2018 16:45:22 +0000 (16:45 +0000)]
Merge "Fix 'Tags' padding to keep it farther from the edge and document the source of the new right padding value"
Jayprakash12345 [Wed, 20 Jun 2018 16:38:40 +0000 (22:08 +0530)]
Correct $specialPageAliases for sa.wiki
Bug: T102320
Change-Id: I10bf5a0039235a5b149dcea6bd62176d3763acf9
Gergő Tisza [Thu, 28 Jun 2018 16:33:50 +0000 (18:33 +0200)]
Fix table locking in WikiPage::doDeleteArticleReal
This reverts a recent change that caused the table array and the
join array to have mismatching keys, so that the select was a
cartesian product of page and revision_comment_temp (ie. any
page deletion locked the whole revision_comment_temp table).
Bug: T198350
Change-Id: Ifb6f0409d4f210d3ecb1da03f59aaba7e229e89e
Aaron Schulz [Thu, 28 Jun 2018 09:23:06 +0000 (10:23 +0100)]
objectcache: make MultiWriteBagOStuff handle duplicate add() operations
Bug: T198280
Change-Id: Ib1bcde2b3fbfb452f80d8d840c494be2eb70eb87
Kosta Harlan [Thu, 28 Jun 2018 14:22:54 +0000 (10:22 -0400)]
RC Filters: Check if app is initialized before calling change tags
This only occurs when highlighting is enabled in the query parameters on page
load. If you load a watchlist page with highlighting enabled, you'll see that
FilterTagMultiselectWidget calls the parent onChangeTags method, and then we
end up at updateIfHeightChanged where a resize event occurs. This commit
checks to see if the app is still initializing before propagating this event.
Bug: T198399
Change-Id: I8d36875ecf859b40854fe57fecf824e648bb3bf8
jenkins-bot [Thu, 28 Jun 2018 13:06:20 +0000 (13:06 +0000)]
Merge "RELEASE-NOTES: Add note for breaking CategoryMultiselectWidget"