From f57044ee1c924a5215fbad0a2cd92f40affb7f23 Mon Sep 17 00:00:00 2001 From: Bryan Davis Date: Thu, 4 Feb 2016 09:19:25 -0700 Subject: [PATCH] mw.loader: Guard localStorage access with try/catch in mw.store.clear() We use try/catch appropriately in other places but it was missing in mw.store.clear(). If the user agent has localStorage disabled an exception will be thrown for any operation that touches the object. Change-Id: Idcd0e4c8ba9b0843b2ddcad0ae1781e4915e04fe --- resources/src/mediawiki/mediawiki.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/resources/src/mediawiki/mediawiki.js b/resources/src/mediawiki/mediawiki.js index b8349d0f91..90b93dceee 100644 --- a/resources/src/mediawiki/mediawiki.js +++ b/resources/src/mediawiki/mediawiki.js @@ -2251,7 +2251,9 @@ */ clear: function () { mw.loader.store.items = {}; - localStorage.removeItem( mw.loader.store.getStoreKey() ); + try { + localStorage.removeItem( mw.loader.store.getStoreKey() ); + } catch ( ignored ) {} }, /** -- 2.20.1