Volker E [Wed, 14 Nov 2018 03:23:59 +0000 (19:23 -0800)]
RCFilters: Removing unused images
Those images were replaced by their direct OOUI originals.
Change-Id: Ia53d5204366e69a76f31c17f52e63f349511592c
jenkins-bot [Tue, 13 Nov 2018 23:54:24 +0000 (23:54 +0000)]
Merge "Hard deprecate codepaths where tidy is disabled"
jenkins-bot [Tue, 13 Nov 2018 21:39:14 +0000 (21:39 +0000)]
Merge "doc: Modernise parameter names and documentation for 'replica' DBs"
jenkins-bot [Tue, 13 Nov 2018 21:18:02 +0000 (21:18 +0000)]
Merge "Special:AllMessages: Rename 'Go' to 'Filter'"
jenkins-bot [Tue, 13 Nov 2018 20:47:27 +0000 (20:47 +0000)]
Merge "JSON formatversion=2 is no longer experimental"
jenkins-bot [Tue, 13 Nov 2018 20:10:31 +0000 (20:10 +0000)]
Merge "TitlesMultiselectWidget: rename 'limit' config to 'tagLimit'"
jenkins-bot [Tue, 13 Nov 2018 20:10:24 +0000 (20:10 +0000)]
Merge "TitlesMultiselectWidget: pass through additional configs"
Thalia [Thu, 8 Nov 2018 14:28:21 +0000 (14:28 +0000)]
TitlesMultiselectWidget: rename 'limit' config to 'tagLimit'
To avoid conflicting with TitleWidget config.
Bug: T209057
Change-Id: Ia0dbc49f38a116202eb2658b7556fb7f0627f1bb
Thalia [Thu, 8 Nov 2018 13:52:55 +0000 (13:52 +0000)]
TitlesMultiselectWidget: pass through additional configs
Pass through 'limit' and 'showMissing' configs.
Also set 'showMissing' to false for partial blocks.
Bug: T208626
Bug: T208627
Change-Id: Ifa75e2d390bf349226ad69d68adcdcaf742ab560
jenkins-bot [Tue, 13 Nov 2018 16:59:33 +0000 (16:59 +0000)]
Merge "Add a Status and a $reason parameter to TitleMove hook"
Juan Osorio [Fri, 9 Nov 2018 22:45:55 +0000 (14:45 -0800)]
Removes Google web search from exception page
When a wiki is down, it is not necessarily useful to be able to
search the web. Additionally, there is general consensus that
the hard-coded Google search form should be removed.
Bug: T208871
Change-Id: I5bcae848de1144d4fc1116c475b2e2ab1ccc3f7d
Daimona Eaytoy [Thu, 8 Nov 2018 15:02:43 +0000 (16:02 +0100)]
Add a Status and a $reason parameter to TitleMove hook
So that using this hook it's possible to prevent the move, also
providing some more context.
Also, clean error message: instead of going with "you do not have
permission blah blah" for *every* kind of error, use it only when the
error is actually about permissions, and use a generic message
otherwise.
Bug: T208907
Change-Id: I4733724075b7514e9db59e7be772d9409aa9da87
jenkins-bot [Tue, 13 Nov 2018 02:44:02 +0000 (02:44 +0000)]
Merge "Comments, tests, and tweaks for JSON decoding quirks"
Brad Jorsch [Sat, 19 Nov 2016 00:50:43 +0000 (19:50 -0500)]
Use new externallinks.el_index_60 field
This adds a method to LinkFilter to build the query conditions necessary
to properly use it, and adjusts code to use it.
This also takes the opportunity to clean up the calculation of el_index:
IPs are handled more sensibly and IDNs are canonicalized.
Also weird edge cases for invalid hosts like "http://.example.com" and
corresponding searches like "http://*..example.com" are now handled more
regularly instead of being treated as if the extra dot were omitted,
while explicit specification of the DNS root like "http://example.com./"
is canonicalized to the usual implicit specification.
Note that this patch will break link searches for links where the host
is an IP or IDN until refreshExternallinksIndex.php is run.
Bug: T59176
Bug: T130482
Change-Id: I84d224ef23de22dfe179009ec3a11fd0e4b5f56d
Translation updater bot [Mon, 12 Nov 2018 20:55:50 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ice13adf03f6dd4f0cb26ddef0c83f8e661c82255
Volker E [Mon, 12 Nov 2018 01:54:54 +0000 (17:54 -0800)]
Special:AllMessages: Rename 'Go' to 'Filter'
Being more explicit about action of primary button.
Bug: T209255
Change-Id: Id1fa035aca6c89120c5178ce94dc12395dcfe04d
Translation updater bot [Sun, 11 Nov 2018 20:53:40 +0000 (21:53 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I8298aee1349476a791d61e9a5dc46b713646afb7
Translation updater bot [Sat, 10 Nov 2018 20:56:56 +0000 (21:56 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I5289942488e5f7d69985bae83ec063f14cbcf55d
jenkins-bot [Sat, 10 Nov 2018 18:14:17 +0000 (18:14 +0000)]
Merge "Provide a script to reset the page_random column"
Piotr Miazga [Thu, 8 Nov 2018 23:45:47 +0000 (18:45 -0500)]
Provide a script to reset the page_random column
Bug: T208909
Change-Id: I914ff44d1212c565e08ff17effbd682dfe7f70fb
Translation updater bot [Fri, 9 Nov 2018 20:55:06 +0000 (21:55 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ia81d27cabb414c2cac0d8a85c086cffd0cc96aa0
James D. Forrester [Thu, 8 Nov 2018 22:42:29 +0000 (14:42 -0800)]
Update OOUI to v0.29.5
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.29.5
Bug: T208966
Bug: T209057
Depends-On: I99cd8589f81daf98ee2a740ffe28159d4613211b
Change-Id: I99cd8589f81daf98ee2a740ffe28159d4613211a
Translation updater bot [Thu, 8 Nov 2018 20:57:48 +0000 (21:57 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I6616dd23be0d49bbfa1079a6251e728d78ae5abd
jenkins-bot [Thu, 8 Nov 2018 19:20:04 +0000 (19:20 +0000)]
Merge "Fix indenting and newlines"
jenkins-bot [Thu, 8 Nov 2018 16:01:20 +0000 (16:01 +0000)]
Merge "Add test for completionSearch with wgCapitalLinkOverrides"
Roan Kattouw [Wed, 7 Nov 2018 23:04:50 +0000 (15:04 -0800)]
ResourceLoader: Fail less hard when JSON serialization of config fails
Instead of throwing an exception on the PHP side, log an error on the JS
side.
Change-Id: I673f59d936e48072e78f6b061ac06f37274ded77
Translation updater bot [Wed, 7 Nov 2018 20:59:14 +0000 (21:59 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I8333ca780f85f780cf39efe10fa510596bdc3118
Bill Pirkle [Wed, 7 Nov 2018 19:04:21 +0000 (13:04 -0600)]
Comments, tests, and tweaks for JSON decoding quirks
PHP JSON decoding has surprising behavior on some edge cases.
Documented this via comments, added related tests, and tweaked
related CommentStore code.
Bug: T206411
Change-Id: I6927fdaf616b37a04d81a638a0ed257afac9b844
Fomafix [Mon, 1 May 2017 16:35:36 +0000 (18:35 +0200)]
Fix indenting and newlines
Like suggested in https://www.mediawiki.org/wiki/Manual:Coding_conventions#Line_continuation
Change-Id: I86db3c24ffc69737c6917cfc68300ff4695961cd
jenkins-bot [Wed, 7 Nov 2018 15:55:16 +0000 (15:55 +0000)]
Merge "eslintrc: Disallow calling String/Array/Object methods introduced in ES6 or later"
Bartosz Dziewoński [Fri, 28 Sep 2018 12:36:04 +0000 (14:36 +0200)]
eslintrc: Disallow calling String/Array/Object methods introduced in ES6 or later
This aims to disallow using the methods listed below, which are
supported by Chromium 69 but not supported by Internet Explorer 11.
Most of them were introduced in ECMAScript 6, but some are more recent
or experimental.
We keep breaking IE 11 support by using them. Recent examples include:
* mediawiki/core:
Ic85063dfbbcf26a99d343845c9fb801f1888d750
* mediawiki/extensions/MultimediaViewer:
I0954c42a37668b0eb46c3e864a2e13152a6dc68a
* mediawiki/extensions/UploadWizard:
I70d37a8f0abcc96b5e39fa71a93cda6f3421c87c
* VisualEditor/VisualEditor:
Ic1971549da37091c41a847229d18e95aff5c9952
This will unfortunately almost certainly cause false positives, but
hopefully not too many of them. Common false positives can be
disallowed more precisely using 'no-restricted-syntax' rather than
'no-restricted-properties'.
Disallowed methods:
String.prototype:
codePointAt
endsWith
includes
normalize
padEnd (ES 2017)
padStart (ES 2017)
repeat
startsWith
trimEnd (experimental/proposed)
trimLeft (experimental/proposed)
trimRight (experimental/proposed)
trimStart (experimental/proposed)
Array.prototype:
copyWithin
entries
fill
find
findIndex
flat (experimental/proposed)
flatMap (experimental/proposed)
includes (ES 2016)
keys
values
String:
fromCodePoint
raw
Array:
from
of
Object:
assign
entries (ES 2017)
getOwnPropertyDescriptors (ES 2017)
getOwnPropertySymbols
is
values (ES 2017)
I compiled the list based on running the following code in each
browser's console, since there doesn't seem to be an authoritative
list anywhere on the Internet:
console.log( Object.getOwnPropertyNames( String.prototype ) )
console.log( Object.getOwnPropertyNames( Array.prototype ) )
console.log( Object.getOwnPropertyNames( Object.prototype ) )
console.log( Object.getOwnPropertyNames( String ) )
console.log( Object.getOwnPropertyNames( Array ) )
console.log( Object.getOwnPropertyNames( Object ) )
Change-Id: Ic44c79834f99c52863fbc544ad657787f70fb9bb
jenkins-bot [Wed, 7 Nov 2018 15:31:30 +0000 (15:31 +0000)]
Merge "Remove excessive indenting of parameters on newlines"
jenkins-bot [Wed, 7 Nov 2018 15:14:20 +0000 (15:14 +0000)]
Merge "Render namespace lists in the user's language"
jenkins-bot [Wed, 7 Nov 2018 10:46:15 +0000 (10:46 +0000)]
Merge "Remove obsolete Special:Preferences styles after its transformation to OOUI"
jenkins-bot [Wed, 7 Nov 2018 05:06:29 +0000 (05:06 +0000)]
Merge "Use DB domain in JobQueueGroup and make WikiMap domain ID methods stricter"
jenkins-bot [Wed, 7 Nov 2018 05:02:57 +0000 (05:02 +0000)]
Merge "Improve handling of invalid titles in RefreshLinksJob"
Aaron Schulz [Sat, 13 Oct 2018 07:29:23 +0000 (00:29 -0700)]
Use DB domain in JobQueueGroup and make WikiMap domain ID methods stricter
Using domains means thats JobQueueDB has the right value to use for calls
like LoadBalancer::getConnection(). The full domain includes the schema in
the case of Postgres. This makes calls to getConnection() less awkward by
not relying on the fallback logic in reallyOpenConnection() for null schemas.
Make getWikiIdFromDomain/isCurrentWikiDomain account for the schema if it
is both defined and is not simply the generic "mediawiki" schema MediaWiki
uses by default. If all wikis use the default schema, the wiki IDs can get
by with DB/prefix alone, which various config and methods may be built around.
Otherwise, the config callbacks must account for schema and the config must
include it in various wiki domain ID lists to properly disambiguate wikis.
Also, clean up SiteConfiguration::siteFromDB() since it is not meant
to handle schemas unless the callback method was taylored to do so.
Finally, add more comments to DefaultSettings.php about already existing
limitations of wiki domain IDs and their components.
Change-Id: I8d94a650e5c99a19ee50551c5be9544318eb05b1
Volker E [Wed, 7 Nov 2018 01:12:38 +0000 (17:12 -0800)]
Remove obsolete Special:Preferences styles after its transformation to OOUI
These removed styles match no elements in the
Special:Preferences page since the OOUI transformation.
Bug: T208923
Change-Id: I6802334d0ef80b337cfd7bb9e957c468fce57ef0
jenkins-bot [Wed, 7 Nov 2018 01:56:52 +0000 (01:56 +0000)]
Merge "Update OOUI to v0.29.4"
jenkins-bot [Wed, 7 Nov 2018 01:24:16 +0000 (01:24 +0000)]
Merge "Revert "RCFilters: Use `display: flex` for better responsiveness on narrow canvas""
James D. Forrester [Wed, 7 Nov 2018 01:01:56 +0000 (17:01 -0800)]
Update OOUI to v0.29.4
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.29.4
Bug: T143623
Bug: T188886
Bug: T191650
Bug: T208436
Bug: T208507
Bug: T208595
Bug: T208618
Bug: T208627
Depends-On: Ic49477fbfff98e74958c95559768ea1830ebe51a
Change-Id: Ic49477fbfff98e74958c95559768ea1830ebe51b
VolkerE [Wed, 7 Nov 2018 00:05:22 +0000 (00:05 +0000)]
Revert "RCFilters: Use `display: flex` for better responsiveness on narrow canvas"
This reverts commit
d3cee1316f517ba643b8535fa8a30e6ad1a3f028.
Bug: T208898
Change-Id: Ie2c431b247027a16c65b258c610eb28e6737b29d
jenkins-bot [Tue, 6 Nov 2018 20:36:14 +0000 (20:36 +0000)]
Merge "resources: Extract ForeignResourceManager from manageForeignResources.php"
Aaron Schulz [Tue, 6 Nov 2018 19:53:37 +0000 (11:53 -0800)]
Improve handling of invalid titles in RefreshLinksJob
Run updates for as many titles as possible and mark the job as failed
if a title is invalid. Set the error message used by the job executer.
Bug: T208147
Change-Id: I7f5fafe9439d8a7b45166515532075202af7d013
Ed Sanders [Wed, 31 Oct 2018 14:50:03 +0000 (14:50 +0000)]
AbandonEditDialog: Rename i18n strings
This wasn't done in the previous patch so that
TranslateWiki picks up the repo move.
Change-Id: Ic6767dc61aeaad8e18c20b0afc1dd929654f4503
David Causse [Tue, 6 Nov 2018 13:35:03 +0000 (14:35 +0100)]
Add test for completionSearch with wgCapitalLinkOverrides
Bug: T208255
Change-Id: Id2299a013b2dc9b5391d400d7c7c4dc37185f714
Reedy [Tue, 6 Nov 2018 10:57:17 +0000 (10:57 +0000)]
Remove excessive indenting of parameters on newlines
Change-Id: I4e214b55b9936be2336a97192f9716b3ea7d6d61
jenkins-bot [Tue, 6 Nov 2018 07:20:19 +0000 (07:20 +0000)]
Merge "Use commit-and-wait when processing more than updateRowsPerQuery"
jenkins-bot [Mon, 5 Nov 2018 22:09:31 +0000 (22:09 +0000)]
Merge "OOUI: Backport I407b0d6fe7b81465054b640d4b5ac4bf352a9901"
jenkins-bot [Mon, 5 Nov 2018 22:09:24 +0000 (22:09 +0000)]
Merge "Localisation updates from https://translatewiki.net."
jenkins-bot [Mon, 5 Nov 2018 22:00:15 +0000 (22:00 +0000)]
Merge "RCFilters: Use `display: flex` for better responsiveness on narrow canvas"
jenkins-bot [Mon, 5 Nov 2018 21:36:57 +0000 (21:36 +0000)]
Merge "Preferences class deprecation, step 2"
jenkins-bot [Mon, 5 Nov 2018 21:36:15 +0000 (21:36 +0000)]
Merge "Preferences::miscPreferences: Hard-deprecate this"
jenkins-bot [Mon, 5 Nov 2018 21:36:09 +0000 (21:36 +0000)]
Merge "rdbms: Add @deprecate tag to MaintainableDBConnRef class alias"
jenkins-bot [Mon, 5 Nov 2018 21:36:03 +0000 (21:36 +0000)]
Merge "Ignore master connections for POST-nonwrite in $wgTrxProfilerLimits"
Translation updater bot [Mon, 5 Nov 2018 21:05:11 +0000 (22:05 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: If17e7446210675a8d91df4e3b6ae80cb35d3afa3
Kosta Harlan [Mon, 5 Nov 2018 20:44:40 +0000 (15:44 -0500)]
Use commit-and-wait when processing more than updateRowsPerQuery
This is needed to avoid triggering "does not have outer scope" errors when
addWatchBatchForUser() is invoked from WatchAction::doWatch() or
WatchAction::doUnwatch() in the context of uploading a file, moving a page, or
other instances when we don't have outer scope.
Bug: T208003
Change-Id: Ice5cb8fced64883476daea5cdac36e47dfcccb61
Bartosz Dziewoński [Mon, 5 Nov 2018 20:12:12 +0000 (21:12 +0100)]
OOUI: Backport I407b0d6fe7b81465054b640d4b5ac4bf352a9901
Bug: T208595
Change-Id: I480067d9897dde25e89058a4da6b065de11b9b31
jenkins-bot [Mon, 5 Nov 2018 19:46:01 +0000 (19:46 +0000)]
Merge "Sync up with Parsoid parserTests.txt"
Alangi Derick [Sun, 4 Nov 2018 15:50:26 +0000 (16:50 +0100)]
rdbms: Add @deprecate tag to MaintainableDBConnRef class alias
Added as per when this was aliased to ease removal
in the future. It was there since REL_1.29.
Bug: T195576
Change-Id: Ia9061cb9592b39d0f6bac1c96f87c9b0346c105b
Max Semenik [Thu, 18 Oct 2018 02:31:21 +0000 (19:31 -0700)]
Preferences class deprecation, step 2
Remove all functions that have been hard (or superhard, with exceptions)
deprecated previously. They all had no callers with one exception:
* getTimezoneOptions() is called from 3rd party extention, already broken
anyway.
Mark the remaining functions for removal in 1.34, where whole class
will become {{db-empty}}. They in principle have no callers already, but
let's follow the proper process and give extension developers a bit more
time.
Change-Id: I0e3e98ed1e6242b6ab7c5f21d71478c392fe89a9
James D. Forrester [Mon, 5 Nov 2018 18:53:02 +0000 (10:53 -0800)]
Preferences::miscPreferences: Hard-deprecate this
Change-Id: Ic1bdf7fc132a1410af1ac24a4c0b8fbad3a6158e
C. Scott Ananian [Tue, 26 Jun 2018 13:53:12 +0000 (09:53 -0400)]
Hard deprecate codepaths where tidy is disabled
Future parsers will not support the output generated with tidy disabled.
Parser tests using untidied output will also be deprecated (and
rewritten) in a follow-up patch.
No new release notes necessary since user-visible tidy configuration
was deprecated previously (in 1.32), and individual methods which had
disabled tidy during execution were individually release-noted as they
were updated.
Bug: T198214
Depends-On: I0f417f75a49dfea873e9a2f44d81796a48b9f428
Depends-On: If5c619cdd3e7f786687cfc2ca166074d9197ca11
Change-Id: I592e0e0dfef7d929f05c60ffe4d60e09725b39cc
jenkins-bot [Mon, 5 Nov 2018 18:19:17 +0000 (18:19 +0000)]
Merge "Upstream VE's MWCancelConfirmDialog as AbandonEditDialog"
jenkins-bot [Mon, 5 Nov 2018 18:07:29 +0000 (18:07 +0000)]
Merge "Hard deprecate OutputPage::parse() and OutputPage::parseInline()"
jenkins-bot [Mon, 5 Nov 2018 17:43:49 +0000 (17:43 +0000)]
Merge "Support multi-content diffs on Special:Undelete"
Arlo Breault [Mon, 5 Nov 2018 16:56:59 +0000 (11:56 -0500)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
68bfb079ab3c62d5cc79b05d496a4bc2966e9553
Change-Id: I54359f91c28ba5d622175dc1caf10a8ed8e91ad3
jenkins-bot [Mon, 5 Nov 2018 14:12:35 +0000 (14:12 +0000)]
Merge "RCFilters: Fix highlighted rows overlapping legend"
Volker E [Mon, 5 Nov 2018 04:43:22 +0000 (20:43 -0800)]
RCFilters: Fix unintendly wrapped ButtonSelectWidget
With I2102f6d3397 OOUI's ButtonSelectWidgets behave differently on
limited parent element horizontal space.
We re-introduce `white-space: nowrap` here specfically.
Bug: T208705
Change-Id: I154c2d9c5469a789d365c5ccb771a9fc0cc018a4
jenkins-bot [Sun, 4 Nov 2018 21:19:39 +0000 (21:19 +0000)]
Merge "installer: Use getUrl() for CSS link in WebInstallerOutput"
Translation updater bot [Sun, 4 Nov 2018 21:04:59 +0000 (22:04 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I10ac08f52ac9650f4897dc9aaffc7dc9a4dfbb68
Fomafix [Mon, 29 Oct 2018 06:18:50 +0000 (07:18 +0100)]
installer: Use getUrl() for CSS link in WebInstallerOutput
This change changes the CSS URL in the stylesheet link from
<link rel="stylesheet" href="/mediawiki/mw-config/index.php?css=1"/>
to
<link rel="stylesheet" href="/mediawiki/mw-config/?css=1"/>
on the website /mediawiki/mw-config/.
Change-Id: Ib46c4d944df862cf928d3ebd050ff2d1e16ba6a5
Ed Sanders [Wed, 31 Oct 2018 13:29:35 +0000 (13:29 +0000)]
Upstream VE's MWCancelConfirmDialog as AbandonEditDialog
So this dialog can be shared across editors.
Bug: T192333
Change-Id: Ib581528363a3fe5461529515835bd7fb1ce66e56
Zoranzoki21 [Fri, 2 Nov 2018 10:17:37 +0000 (11:17 +0100)]
Equalization translations for Serbian
Change-Id: I3c79ded77f16beee404ca3005ae7678838ab9d60
jenkins-bot [Sat, 3 Nov 2018 11:43:42 +0000 (11:43 +0000)]
Merge "Special:Preferences: Expose `.mw-navigation-hint` on keyboard focus only"
Translation updater bot [Sat, 3 Nov 2018 09:11:03 +0000 (10:11 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: I52eda764f5cba9b1f88bd6a2d3817f88214849ab
jenkins-bot [Sat, 3 Nov 2018 00:43:22 +0000 (00:43 +0000)]
Merge "Use new ScopedCallback::newScopedIgnoreUserAbort helper function"
jenkins-bot [Sat, 3 Nov 2018 00:43:17 +0000 (00:43 +0000)]
Merge "Update wikimedia/scoped-callback to 3.0.0"
Volker E [Fri, 2 Nov 2018 23:58:53 +0000 (16:58 -0700)]
RCFilters: Use `display: flex` for better responsiveness on narrow canvas
Bug: T197065
Change-Id: I0fdff660a480aeedc096bc4ec48b05569e67e595
jenkins-bot [Fri, 2 Nov 2018 23:49:50 +0000 (23:49 +0000)]
Merge "Don't infer parsoid-only parser tests based on presence of parsoid option."
jenkins-bot [Fri, 2 Nov 2018 22:42:17 +0000 (22:42 +0000)]
Merge "PHPVersionCheck: Remove obsolete load.php code and simplify"
Roan Kattouw [Fri, 2 Nov 2018 21:03:01 +0000 (14:03 -0700)]
RCFilters: Fix highlighted rows overlapping legend
While the new rows are being faded in, they each have an opacity not
equal to 1. Setting the opacity on something creates a new stacking
context, and because the rows are below the legend in the DOM, this made
them appear on top of the legend.
Fix this by setting a z-index on the legend so it stays on top.
Bug: T186841
Change-Id: I2eee201d1e0aed94974a85d6d46b86fd4a4db796
C. Scott Ananian [Tue, 4 Aug 2015 20:06:15 +0000 (16:06 -0400)]
Don't infer parsoid-only parser tests based on presence of parsoid option.
For historical reasons, we used a complicated test to try to determine
if a test is "parsoid only" based on the presence of the string "parsoid"
in the parser test options clause. But really test clauses should be
marked up specifically as html/php or html/parsoid, we don't need to
play hacky games any more. Remove some unnecessary code and simplify
the test logic.
Change-Id: Ia331e7e12a75aa19aeb96601712f169f2aa75bf9
jenkins-bot [Fri, 2 Nov 2018 18:57:48 +0000 (18:57 +0000)]
Merge "Upgrade wikimedia/xmp-reader to 0.6.1"
jenkins-bot [Fri, 2 Nov 2018 18:38:20 +0000 (18:38 +0000)]
Merge "Sync up with Parsoid parserTests.txt"
jenkins-bot [Fri, 2 Nov 2018 18:11:23 +0000 (18:11 +0000)]
Merge "Update deprecations after OutputPage::parse*As*() backport to 1.32"
C. Scott Ananian [Fri, 2 Nov 2018 17:31:44 +0000 (13:31 -0400)]
Sync up with Parsoid parserTests.txt
This now aligns with Parsoid commit
24b6363b9a99435479305fa98651b07e2ddb118a
Change-Id: I9090541605411af1ff3b4252b2e0902736e1ed48
C. Scott Ananian [Thu, 1 Nov 2018 20:30:57 +0000 (16:30 -0400)]
Update deprecations after OutputPage::parse*As*() backport to 1.32
Originally landed in 1.33 in
a3f63785eebfa2f729d42da880b6722736ef1e7d.
Backported to 1.32 in
cff9ab4b5c26dc87137aa2c04efd5d1f31226fe8.
Change-Id: I402c31b57904f6a6fd0b3a2c32a1c0a73c553254
Alangi Derick [Fri, 2 Nov 2018 12:39:02 +0000 (13:39 +0100)]
Fix typo in tests/includes/SampleTest.php in core
Minor typo fix in comments for setUp() and provideTitles()
methods in SampleTests.php file.
Change-Id: I09e0fb041d6809509e780d22bf8419497cd50ee7
Lucas Werkmeister [Wed, 24 Oct 2018 21:41:42 +0000 (23:41 +0200)]
Add start, end to allowed params of Special:MyContributions
I assume they were just omitted by accident.
Bug: T207895
Change-Id: I99c14849a6f312f0014298d92de773205d05ad04
jenkins-bot [Fri, 2 Nov 2018 01:59:01 +0000 (01:59 +0000)]
Merge "Handle <nowiki> and other markup consistently in image link/alt options"
stibba [Mon, 29 Oct 2018 21:18:29 +0000 (22:18 +0100)]
Use new ScopedCallback::newScopedIgnoreUserAbort helper function
Introduced in Ib6e307d76f93.
This patch updates FileBackend, LoadBalancer and LBFactory to use a public
function newScopedIgnoreUserAbort in ScopedCallback instead of all using
the exact same function but duplicated.
Bug: T184044
Change-Id: I27d7dc16abfe4b9447d7f3d8bd89f0de3ddeb662
Kunal Mehta [Fri, 2 Nov 2018 00:16:27 +0000 (17:16 -0700)]
Update wikimedia/scoped-callback to 3.0.0
Depends-On: Idf3ee1f785104257dec8c6bfead821244184b126
Change-Id: I005575a341d4eda4595dc36537c4f2996e32eb45
Kunal Mehta [Fri, 2 Nov 2018 00:13:15 +0000 (17:13 -0700)]
Upgrade wikimedia/xmp-reader to 0.6.1
Depends-On: I3eba0c81aed14f1087c46fb11088412cad5a505f
Change-Id: I215ab354b39a276aefc54fabad4e3ddcd792a796
Aaron Schulz [Thu, 1 Nov 2018 22:39:12 +0000 (15:39 -0700)]
Ignore master connections for POST-nonwrite in $wgTrxProfilerLimits
Unless an actuall write happens, avoid create log spam over things
like CentralAuthUser->getSafeReadDB().
Change-Id: I1cf43f4b1cdd12eb458458448f0f0ea328925b47
C. Scott Ananian [Fri, 26 Oct 2018 15:28:12 +0000 (11:28 -0400)]
Hard deprecate OutputPage::parse() and OutputPage::parseInline()
Depends-On: I2cc3a4631bcb45b7f8cd913e9b6dba14349e5e9e
Depends-On: Ieaac7a198cacec406a8240ed07b2d9f32ef9e56a
Depends-On: Ia4b63715380d97ccb3133bf39a260834c20b4f5a
Depends-On: I88fb74c3007360e2301c8bca7db6a940e966a735
Change-Id: If5c619cdd3e7f786687cfc2ca166074d9197ca11
C. Scott Ananian [Thu, 1 Nov 2018 21:26:10 +0000 (17:26 -0400)]
Replace deprecated call to OutputPage::parse() in HTMLForm
Use OutputPage::parseAsInterface() to tidy the output and make the
selection of user interface language explicit.
Follow-up to Ifeb1ca6eb8b5c743421b8f9e329f1e3658050e47.
Bug: T198214
Change-Id: Ia4b63715380d97ccb3133bf39a260834c20b4f5a
Translation updater bot [Thu, 1 Nov 2018 21:02:14 +0000 (22:02 +0100)]
Localisation updates from https://translatewiki.net.
Change-Id: Ibbaeb400c9e5a1c744d8690cccc56d8d2fb9d0cf
C. Scott Ananian [Wed, 31 Oct 2018 18:58:37 +0000 (14:58 -0400)]
JSON formatversion=2 is no longer experimental
It was introduced in MW 1.25 and was last changed in MW 1.26; it can be
considered stable now.
Change-Id: I6d99f95f22f5822b05fc0e12d9647303ccde1d95
David Barratt [Thu, 1 Nov 2018 19:37:46 +0000 (15:37 -0400)]
BlockRestriction::update() unnecessarily does a SELECT on the page table.
This unnecessary SELECT causes a performence issue where it takes an
exceedingly long time to perform an update.
Bug: T208526
Change-Id: I0238234146fc838067019351ea97046a7d37d6fc