Volker E [Wed, 18 Oct 2017 05:10:15 +0000 (22:10 -0700)]
jquery.badge: Align with Echo notifications style and WikimediaUI palette
Aligning badge style to Echo notifications, ensuring WCAG level AA conformance
and also to WikimediaUI color palette.
Bug: T152025
Change-Id: I279a607f3c1b13ea6e21e59df0c6d21e525f587e
jenkins-bot [Tue, 17 Oct 2017 22:37:31 +0000 (22:37 +0000)]
Merge "Add a few schemas to SQLite tests"
jenkins-bot [Tue, 17 Oct 2017 22:06:25 +0000 (22:06 +0000)]
Merge "Fix login button label to accept RawMessage."
Translation updater bot [Tue, 17 Oct 2017 20:08:59 +0000 (22:08 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I46a1a40150d9eda7a34d2a02e17f0aef1bf6d9a7
jenkins-bot [Tue, 17 Oct 2017 19:22:57 +0000 (19:22 +0000)]
Merge "RCFilters: Move parameter operations to ViewModel"
jenkins-bot [Tue, 17 Oct 2017 19:03:06 +0000 (19:03 +0000)]
Merge "RCFilters: Don't let new params filter out old page"
Cicalese [Tue, 17 Oct 2017 17:58:28 +0000 (17:58 +0000)]
Fix login button label to accept RawMessage.
The label is already a Message at this point. For Messages that
are not RawMessages, the call to wfMessage() does not do any harm.
However, for RawMessages, it causes the label to appear in <>.
Removing the call to wfMessage() does not harm regular Messages
and fixes the problem for RawMessages.
Change-Id: I943628e2a1fbf6fff579dd52c1058ca2ef125d34
jenkins-bot [Tue, 17 Oct 2017 14:09:23 +0000 (14:09 +0000)]
Merge "Remove mention of IE9 support"
jenkins-bot [Tue, 17 Oct 2017 14:01:11 +0000 (14:01 +0000)]
Merge "Add primary keys to site_stats"
jhsoby [Tue, 17 Oct 2017 12:51:38 +0000 (14:51 +0200)]
Updating native language name for Northern Sami
Bug: T156589
Change-Id: Iec69f8654d6eabb7b644726fd63f00edb01dc1e9
Eddie Greiner-Petter [Sat, 15 Jul 2017 20:57:06 +0000 (22:57 +0200)]
Add primary keys to site_stats
As discussed in I7d42aae434852a56b6f8dd559d8a5f3bce416021 primary keys
are needed to perform various schema changes on the site_stats table.
This patch aims to introduce primary keys for all supported dbms.
The respective *.sql patch files were tested locally against Postgres
and SQL Server 2016. Please note that neither the patch file for Oracle
DB nor the mediawiki upgrade through update.php was tested.
Bug: T56888
Change-Id: Id10e221f0dc120bc09afc22596fd1dbecbf6a61d
jenkins-bot [Tue, 17 Oct 2017 11:33:18 +0000 (11:33 +0000)]
Merge "Add option to hide missing pages while searching"
Ed Sanders [Tue, 17 Oct 2017 11:27:22 +0000 (12:27 +0100)]
Remove mention of IE9 support
Change-Id: I68a31292efa501b83ca9d5ebfbaa5e2c46120d34
jenkins-bot [Tue, 17 Oct 2017 10:55:52 +0000 (10:55 +0000)]
Merge "Align diff context colors to WikimediaUI color palette"
jenkins-bot [Tue, 17 Oct 2017 03:51:42 +0000 (03:51 +0000)]
Merge "Convert GitInfo to the new shell framework"
jenkins-bot [Tue, 17 Oct 2017 03:51:38 +0000 (03:51 +0000)]
Merge "Shell\Command: Better walltime fallback"
Max Semenik [Tue, 17 Oct 2017 03:29:58 +0000 (20:29 -0700)]
Convert GitInfo to the new shell framework
Change-Id: I2fdebe8748708412c59a9de4028cc2e280c8d0c8
Max Semenik [Mon, 16 Oct 2017 22:30:49 +0000 (15:30 -0700)]
Shell\Command: Better walltime fallback
Previously, it assumed that the only way times could be overridden is to
reduce the limits - which isn't the case for video transcoding.
Bug: T178314
Change-Id: I492a44f280a36ee666e9963788caac2bbc6bc6f3
addshore [Sat, 14 Oct 2017 16:27:42 +0000 (17:27 +0100)]
RevisionUnitTest for fetchFromConds
Change-Id: Ie151123d703933474a52c73beacb0ac70161c241
addshore [Sat, 14 Oct 2017 13:07:22 +0000 (14:07 +0100)]
RevisionUnitTest for various getters and setters
getId
setId
setUserIdAndName
getTextId
getParentId
Change-Id: I1890122c0eae16947a4782bc14baa8c3b9ce1391
addshore [Sat, 14 Oct 2017 12:35:05 +0000 (13:35 +0100)]
RevisionUnittest for select*Fields methods
Change-Id: I8ec1d35bb5e4706e5cfe72684bcac73c9f3d63cc
addshore [Sat, 14 Oct 2017 10:43:58 +0000 (11:43 +0100)]
RevisionUnitTest for userJoinCond and pageJoinCond
Change-Id: I4deb6192e56c6b6eb9c60d0ae3cd3aa472a84af6
addshore [Sat, 14 Oct 2017 10:40:56 +0000 (11:40 +0100)]
RevisionIntegrationTest for loadFromTimestamp
Change-Id: I65f4f7b44c476baaaaa9e185c7d506573b22b080
addshore [Sat, 14 Oct 2017 10:38:38 +0000 (11:38 +0100)]
RevisionIntegrationTest for loadFromTitle
Change-Id: I963dcd20cd01e99de3b1a22de43f9e2892abe9cc
addshore [Sat, 14 Oct 2017 10:35:11 +0000 (11:35 +0100)]
RevisionIntegrationTest for loadFromId & loadFromPageId
Change-Id: I31431267d761b5d97d7e298c3451341358d54bba
addshore [Sat, 14 Oct 2017 10:25:28 +0000 (11:25 +0100)]
RevisionIntegrationTest for newFromArchiveRow with ContentHandlerUseDB
Change-Id: I6edea4f1de69f5df33f6389f9d7a5be2717c0bb2
addshore [Sat, 14 Oct 2017 10:17:39 +0000 (11:17 +0100)]
RevisionIntegrationTest for newFromPageId
Change-Id: I09cf5fcbacab662e30acda1687ebcfe6b29f1900
jenkins-bot [Tue, 17 Oct 2017 00:50:43 +0000 (00:50 +0000)]
Merge "Cleanup page creation in RevisionIntegrationTest"
jenkins-bot [Tue, 17 Oct 2017 00:48:50 +0000 (00:48 +0000)]
Merge "Split Revision tests into Unit & Integration classes"
Moriel Schottlender [Tue, 3 Oct 2017 23:17:30 +0000 (16:17 -0700)]
RCFilters: Move parameter operations to ViewModel
Refactor the operation of the model to work with parameters. Since we
work with parameters, there's no need to display and store the entire
state but rather only the active parameters -- which is the same operation
that the URL is displaying.
* Make sure that all controllers (Controller and UriProcessor) adhere to
FiltersModel operation of minimization.
* Allow the FiltersViewModel to accept a parameter state to update itself.
* Simplify the operation of getting defaults and checking whether defaults
are empty.
* Make sure that the storage construct (split to params/highlights) does
not leak out of the saved queries model, the only place where it is
relevant.
* Add unit tests and correct existing unit tests.
Change-Id: Icec513c94630314e7873f9ffe27779cd39150713
Max Semenik [Sat, 9 Sep 2017 01:28:05 +0000 (18:28 -0700)]
Hard deprecate wfRunHooks()
Deprecated since 1.25, very few callers. Having to grep for 2
ways of calling a hook is harmful not only because it wastes developers'
time, but also because it makes it possible to forget to search for the
old way, resulting in mistakes. Better get rid of this.
Change-Id: Iab28bd5758475b780c2016847881757d64973862
jenkins-bot [Mon, 16 Oct 2017 22:06:59 +0000 (22:06 +0000)]
Merge "Fix tabindex applied twice on RC top section"
jenkins-bot [Mon, 16 Oct 2017 20:25:50 +0000 (20:25 +0000)]
Merge "Fix changes list misaligned arrow"
Stephane Bisson [Mon, 16 Oct 2017 11:09:55 +0000 (07:09 -0400)]
RCFilters: Don't let new params filter out old page
Bug: T177884
Change-Id: Id0ace30b837cf6c5fa7159aa40d80392187c4e16
petarpetkovic [Mon, 16 Oct 2017 15:09:00 +0000 (17:09 +0200)]
Fix changes list misaligned arrow
Bug: T176368
Change-Id: Ie2e938a1b869a58368bc1a5eeec054c90a90724f
addshore [Fri, 13 Oct 2017 15:39:24 +0000 (16:39 +0100)]
Cleanup page creation in RevisionIntegrationTest
Use the page that is already created by MediaWikiTestCase
to save time in tests.
There is no need to create a second page or a page per test
and have the overhead of the extra db calls.
Change-Id: I6c88edac09b9912a6e8b0673f2229a8d0819bf81
Fomafix [Sat, 7 Oct 2017 16:35:14 +0000 (18:35 +0200)]
Remove mw.page
mw.page was deprecated in
b3fb2770 in MediaWiki 1.30.
Change-Id: Ia2f040549bb83445a8efcd5841bb64cfc5eee50e
jenkins-bot [Mon, 16 Oct 2017 14:05:20 +0000 (14:05 +0000)]
Merge "Add lowercase variants to the autoloader for legacy history blob classes"
Ori Livneh [Sat, 14 Oct 2017 20:57:38 +0000 (16:57 -0400)]
Add lowercase variants to the autoloader for legacy history blob classes
Blobs in the text table created by MediaWiki <1.5 running on PHP 4 had class
names coerced to lowercase. In order to succcessfully resolve these class
names, the autoloader creates a copy of the autoload class array with
lowercased keys, which is pretty inefficient. So instead, make sure the
auto-generated autoload map contains lowercase variants for these specific
classes.
Bug: T166759
Change-Id: I6d751ef516e936e04c056d70a1ecd17960a39ceb
petarpetkovic [Mon, 16 Oct 2017 13:42:03 +0000 (15:42 +0200)]
Fix tabindex applied twice on RC top section
- Remove tabindex = 0 applied to ButtonElement and leave
only tabindex on ButtonElement-button, so keyboard focus
does not catch one time too much.
Bug: T175893
Change-Id: I5bf759dd2cdcb1a719f1ca7844253025813f8e9a
jenkins-bot [Mon, 16 Oct 2017 13:45:12 +0000 (13:45 +0000)]
Merge "RCFilters: Use mixins and variables in LESS files"
jenkins-bot [Mon, 16 Oct 2017 13:27:31 +0000 (13:27 +0000)]
Merge "Remove strong tag from "Other review tools""
petarpetkovic [Mon, 16 Oct 2017 11:30:20 +0000 (13:30 +0200)]
Remove strong tag from "Other review tools"
Bug: T175031
Change-Id: I0e9b75496d87c7312d0bb597650ed914a9dccf90
petarpetkovic [Mon, 16 Oct 2017 11:09:05 +0000 (13:09 +0200)]
Improve wording in Saved Filter Menu
- Change user message in saved filter menu from "No links saved yet" to
more clear "No filters saved yet".
Bug: T177540
Change-Id: I39846159183f51fa40efb62f9c8f2fbc79a9c282
petarpetkovic [Tue, 10 Oct 2017 13:57:38 +0000 (15:57 +0200)]
RCFilters: Use mixins and variables in LESS files
Bug: T156164
Change-Id: Ie979926fe2fb0f840e5bd5dacedf254312a0aa17
petarpetkovic [Mon, 9 Oct 2017 18:58:42 +0000 (20:58 +0200)]
Add option to hide missing pages while searching
Bug: T177469
Change-Id: I9e7dd451c61a6a88679628acbbf28d45c0a1e0e8
jenkins-bot [Mon, 16 Oct 2017 08:42:44 +0000 (08:42 +0000)]
Merge "Parser: Disable commafy for magic variables for month and day"
Santhosh Thottingal [Fri, 13 Oct 2017 11:43:22 +0000 (17:13 +0530)]
Parser: Disable commafy for magic variables for month and day
In Parser#getVariableValue for the following magic variables
Language#formatNum was called without commafy parameter:
currentmonth, currentmonth1, currentday, currentday2, localmonth,
localmonth1, localday, localday2
The default value for formatNum nocommafy is false, meaning formatNum
will do commafication. For the above context, commafy is not needed
since the passed values are often month values like 02, 03 etc.
Commafy is noop on this values.
Explicitly pass false value for formatNum's nocommafy argument.
Language#formatNum method documentation for nocommafy also recommends
setting it true in case of dates.
Change-Id: I3233d5458af8cef583e5d1d599d9408542ba08c9
jenkins-bot [Mon, 16 Oct 2017 06:18:22 +0000 (06:18 +0000)]
Merge "Fix escaping of i18n message shared-repo-from"
Brian Wolff [Mon, 16 Oct 2017 06:01:56 +0000 (06:01 +0000)]
Fix escaping of i18n message shared-repo-from
[Discovered using an experimental phan plugin]
Change-Id: Ia580dbd0646e2087c676f9e6989b5330d2149845
Translation updater bot [Sun, 15 Oct 2017 19:59:41 +0000 (21:59 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I8954aa5cdc07ec35f19b319de34e1a5d47a3589d
Reedy [Sun, 15 Oct 2017 17:36:53 +0000 (18:36 +0100)]
Fix covers __constructor -> __construct
Change-Id: I264154c7707def3986560901f3501756853fff11
Fomafix [Sun, 15 Oct 2017 08:52:43 +0000 (10:52 +0200)]
Replace HTTP by HTTPS in docs
Change-Id: I311c40f8aa90f308a0817f4c3ce1b9449b1f5ca7
Ori Livneh [Sun, 15 Oct 2017 01:41:58 +0000 (21:41 -0400)]
Fix letter-case of several namespace and class names
'Mediawiki\Widget\SelectWithInputWidget' is the only one that shows up
in the logs, but I tidied up a few others I came across.
Change-Id: I700dec858007a8013e6d7b9e37ddf518f223d8b7
Translation updater bot [Sat, 14 Oct 2017 19:54:47 +0000 (21:54 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: I1d8fca497113f640cf8e90ab6ca2a5e2d4ebeb55
jenkins-bot [Sat, 14 Oct 2017 05:14:54 +0000 (05:14 +0000)]
Merge "RCFilters: Fix RC jumpiness due to expanded/collapsed community links"
Timo Tijhof [Thu, 12 Oct 2017 00:01:58 +0000 (01:01 +0100)]
SpecialRunJobs: Use MediaWiki's built-in async/post-send mode
Disabling OutputPage is fine, but disabling MediaWiki's own
output handling from MediaWiki.php as well (with ignore_user_abort
and ob_flush) made this code incompatible with becoming an API module.
Make use of DeferredUpdates instead, MediaWiki's built-in post-send
mechanism.
Bug: T175146
Change-Id: Ia131341d447fd6501a070da89cd3a2af470e0f7d
Moriel Schottlender [Fri, 13 Oct 2017 23:20:33 +0000 (16:20 -0700)]
RCFilters: Fix RC jumpiness due to expanded/collapsed community links
Bug: T177117
Change-Id: Ie0761613ff8c731226e26a78afa500aef9619d01
jenkins-bot [Fri, 13 Oct 2017 21:54:02 +0000 (21:54 +0000)]
Merge "deferred: Introduce TransactionRoundDefiningUpdate"
Timo Tijhof [Thu, 12 Oct 2017 20:19:56 +0000 (21:19 +0100)]
deferred: Introduce TransactionRoundDefiningUpdate
This allows scheduling of updates that need to start their own
transaction round. Specifically for cases where the ability to
commit early is not enough (which is already possible via LBFactory
getEmptyTransactionTicket and commitAndWaitForReplication).
Change-Id: I0910587b61c8ddf825f91e92c2f93582cc7ebd80
Derk-Jan Hartman [Fri, 13 Oct 2017 20:34:00 +0000 (22:34 +0200)]
Fix margin of #jump-to-nav
The top margin is a correction for the bottom margin.
Follow-up to: Id58972b
Bug: T176444
Change-Id: Icfedfa1ede49de96210b8662a1886ab52c78b006
jenkins-bot [Fri, 13 Oct 2017 20:10:43 +0000 (20:10 +0000)]
Merge "Simplify OutputPage constructor"
Translation updater bot [Fri, 13 Oct 2017 19:56:25 +0000 (21:56 +0200)]
Localisation updates from https://translatewiki.net.
Change-Id: Ie065cfcf32cbd7f8e341766b545ac0f893cc508b
Max Semenik [Sat, 9 Sep 2017 02:12:37 +0000 (19:12 -0700)]
Simplify OutputPage constructor
Make it impossible to instantiate this class without passing it
context. This appears to be the oldest wfDeprecated() in MediaWiki.
All callers have been updated.
Change-Id: I00b9e283ad22c6274b358063b9f9e60fe93d5ee7
jenkins-bot [Fri, 13 Oct 2017 19:42:22 +0000 (19:42 +0000)]
Merge "Remove old workaround for HHVM"
Max Semenik [Wed, 21 May 2014 18:23:10 +0000 (11:23 -0700)]
Add a few schemas to SQLite tests
Change-Id: I09f2f98100b7bd74abc468b612dc6e90d95975c7
jenkins-bot [Fri, 13 Oct 2017 19:00:12 +0000 (19:00 +0000)]
Merge "Split sql fulltext index creation into two statements"
Erik Bernhardson [Tue, 10 Oct 2017 16:51:39 +0000 (09:51 -0700)]
Split sql fulltext index creation into two statements
MySQL prior to 5.6.8 (https://bugs.mysql.com/bug.php?id=67004) did
not support adding multiple fulltext indices at the same time on InnoDB.
Split them into two statements to work around this limitation.
Bug: T177477
Change-Id: Ib366fa04724abac6d740bea017274ad62730b9e5
jenkins-bot [Fri, 13 Oct 2017 18:15:34 +0000 (18:15 +0000)]
Merge "Hard deprecate wfBaseConvert()"
jenkins-bot [Fri, 13 Oct 2017 15:11:45 +0000 (15:11 +0000)]
Merge "RCFilters: Don't reload when removing highlighted item"
jenkins-bot [Fri, 13 Oct 2017 15:11:31 +0000 (15:11 +0000)]
Merge "Add missing retrun in getSummaryInputOOUI()"
jenkins-bot [Fri, 13 Oct 2017 15:04:11 +0000 (15:04 +0000)]
Merge "RCFilters: Use GroupWidget for grouping buttons and aggregating events"
addshore [Thu, 12 Oct 2017 12:23:33 +0000 (13:23 +0100)]
Split Revision tests into Unit & Integration classes
Change-Id: If10b102a1a0d680b5f067bf34c0fafcb59c09048
WMDE-Fisch [Fri, 13 Oct 2017 11:20:12 +0000 (13:20 +0200)]
Add missing retrun in getSummaryInputOOUI()
Change-Id: I26ad5bd4ed7e4d0e690c48354dc281f4636becd7
jenkins-bot [Fri, 13 Oct 2017 06:58:19 +0000 (06:58 +0000)]
Merge "Remove maintenance/checkSyntax.php"
jenkins-bot [Fri, 13 Oct 2017 06:47:05 +0000 (06:47 +0000)]
Merge "Update PsySh from 0.8.5 to 0.8.11"
jenkins-bot [Fri, 13 Oct 2017 04:24:59 +0000 (04:24 +0000)]
Merge "Move wfCountDown() into Maintenance class"
Max Semenik [Fri, 13 Oct 2017 02:54:05 +0000 (19:54 -0700)]
Remove maintenance/checkSyntax.php
Was useful years ago, but now we have much better tools.
Not used anywhere search can find.
Change-Id: Iaa094a686aeefd9a6071abc843ffc33c8daf2a5a
Max Semenik [Fri, 13 Oct 2017 02:38:26 +0000 (19:38 -0700)]
Hard deprecate wfBaseConvert()
No callers anywhere.
Change-Id: If804d1153ca8e9e82eda3af4d992e395ab112158
Max Semenik [Fri, 13 Oct 2017 00:38:34 +0000 (17:38 -0700)]
Remove old workaround for HHVM
The bug in question was fixed in HHVM 3.6.0, our minimum requirement is 3.6.5.
Change-Id: Id1d65cf438c7148064d747f09728ef4cb5f51b52
Moriel Schottlender [Fri, 13 Oct 2017 00:27:39 +0000 (17:27 -0700)]
RCFilters: Use GroupWidget for grouping buttons and aggregating events
Bug: T168849
Change-Id: I3d68121aa4b281751f6ea6cce2c68147855d6c68
Brad Jorsch [Wed, 12 Apr 2017 15:38:20 +0000 (11:38 -0400)]
ApiQueryLinks: Avoid MySQL order-by bug
MySQL (and MariaDB) have a strange bug where it will often get confused
and insist on filesorting if a field that is constant in the WHERE
clause is also present in ORDER BY. We've worked around this in several
places in the API, and in fact it was done in this very module in r34720
and r37250.
But when r67450 added the pltitles and tltemplates parameters, it didn't
adjust the logic for avoiding the DB bug. This does that now.
Change-Id: I9f37f8812a94cdd088d3940da43d1046ebd455d6
Max Semenik [Fri, 13 Oct 2017 00:24:46 +0000 (17:24 -0700)]
Move wfCountDown() into Maintenance class
Doing this allows to restrict it to maintenance scripts and support
quiet mode.
Change-Id: Iad0858ce1fdd64f746d5f9d4a7d6ed96f21e94df
jenkins-bot [Fri, 13 Oct 2017 00:04:42 +0000 (00:04 +0000)]
Merge "Update email mute copy on preferences page"
Gergő Tisza [Thu, 12 Oct 2017 23:25:09 +0000 (16:25 -0700)]
Update PsySh from 0.8.5 to 0.8.11
0.8.11 adds bracketed paste support for readline,
meaning that it can differentiate between
interaction-triggering characters (such as newline
or tab) which have been entered manually, and ones
which have been pasted so their special effect should
be suppressed. Also a bunch of small bugfixes and features.
Release summaries: https://github.com/bobthecow/psysh/releases
All changes: https://github.com/bobthecow/psysh/compare/v0.8.5...v0.8.11?expand=1
There are no dependency changes; I've skimmed the code
changes and all seem harmless.
Change-Id: I33456904787fd86458249ddfbb00c6b55592da07
jenkins-bot [Thu, 12 Oct 2017 22:43:55 +0000 (22:43 +0000)]
Merge "mw.rcfilters.Controller: Avoid ES6 method String#endsWith"
jenkins-bot [Thu, 12 Oct 2017 22:38:41 +0000 (22:38 +0000)]
Merge "Update OOjs UI to v0.23.5"
Bartosz Dziewoński [Thu, 12 Oct 2017 22:17:11 +0000 (00:17 +0200)]
mw.rcfilters.Controller: Avoid ES6 method String#endsWith
We still support ES5 browsers such as Internet Explorer 11 and Opera 12.
Bug: T178120
Change-Id: Ic85063dfbbcf26a99d343845c9fb801f1888d750
jenkins-bot [Thu, 12 Oct 2017 21:55:35 +0000 (21:55 +0000)]
Merge "Skin: Make skins aware of their registered skin name"
James D. Forrester [Thu, 12 Oct 2017 21:36:40 +0000 (14:36 -0700)]
Update OOjs UI to v0.23.5
Release notes:
https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.23.5
Also, replace uses of `OOUI\TextInputWidget( [ 'multiline' => true ] )`
with `OOUI\MultilineTextInputWidget()` to avoid deprecation warnings
(which cause unit tests to fail).
Depends-on: I990b14982ffb72fe981040d02c7023d13f721aaa
Change-Id: If8312c60e1547a6177f5491011badb6576f54b21
Dayllan Maza [Thu, 12 Oct 2017 16:25:18 +0000 (12:25 -0400)]
Update email mute copy on preferences page
Bug: T176365
Change-Id: Iabe26fe12ee212217ab6b05016638a683df94b05
jenkins-bot [Thu, 12 Oct 2017 21:23:19 +0000 (21:23 +0000)]
Merge "deferred: Improve DeferredUpdates test coverage"
jenkins-bot [Thu, 12 Oct 2017 20:53:18 +0000 (20:53 +0000)]
Merge "shell: Deduplicate code in Command.php by combining else paths"
Fomafix [Thu, 12 Oct 2017 10:51:05 +0000 (12:51 +0200)]
shell: Deduplicate code in Command.php by combining else paths
Also reduce indenting.
Change-Id: I33f83786c38bba0919372df0d5cdfa806d4361fc
Timo Tijhof [Thu, 12 Oct 2017 18:58:33 +0000 (19:58 +0100)]
deferred: Improve DeferredUpdates test coverage
From 1% of lines to 12% in deferred/.
From 6% of lines to 68% in DeferredUpdates.php.
* Adding relevant @covers tags to existing tests.
* Add coverage for MWCallableUpdate.
* Add coverage for MergeableUpdate.
Also:
* Make MergeableUpdate extend DeferrableUpdate.
1. Because PHPUnit doesn't support implementing multiple interfaces
in a mock, and would make the mock fail the typehint at run-time.
2. It DeferredUpdates doesn't support having a MergeableUpdate that isn't
itself a DeferrableUpdate given the only way to reach that code is past
methods that are type-hinted with DeferrableUpdate.
3. Making the interface extend DeferrableUpdate helps produce better and
earlier errors. Instead of run-time error:
> Argument 1 passed to addUpdate() must implement interface DeferrableUpdate
> instance of MergeableUpdate given
We get:
> Fatal error: Class .. contains 1 abstract method and must therefore be
> declared abstract or implement the remaining methods (doUpdate)
Change-Id: Ie384bf849a96bb37dc3e4a4154da2b02889e9fc8
Roan Kattouw [Thu, 12 Oct 2017 19:32:26 +0000 (12:32 -0700)]
Follow-up
d25a944635: fix PHP notice
Change-Id: Id4d58f4eb2a26cb2f9cf6d36194f3e0ae9c84135
jenkins-bot [Thu, 12 Oct 2017 19:29:24 +0000 (19:29 +0000)]
Merge "SpecialRunJobs: Remove unused JSON response"
jenkins-bot [Thu, 12 Oct 2017 19:29:20 +0000 (19:29 +0000)]
Merge "Remove useless commit calls in JobRunner"
Aaron Schulz [Thu, 12 Oct 2017 19:00:07 +0000 (12:00 -0700)]
Remove useless commit calls in JobRunner
These were meant as sanity checks, but would fail in those
unusual cases anyway with exceptions. Instead, have an
early check to make sure no explicit transaction rounds
are active when JobRunner:run is called.
Change-Id: I723c77c8d3ef7ec4dcf09ce6d549b4fd57bdf1c2
jenkins-bot [Thu, 12 Oct 2017 17:35:08 +0000 (17:35 +0000)]
Merge "Drop call of deprecated IE8-support method"